Making Actionbars

[10leej]

So looking into this I ran across this script here for making actionbars. It actually works but I'm wondering if there's a more efficient way to do this 5 more times so I can make 5 more bars in addition to having the default 5.

local addonName, addonTable = ...
 
addonTable.Funcs = {}
 
local MyFuncs = addonTable.Funcs
 
local f = CreateFrame("Frame", nil, UIParent)
 
function MyFuncs.OnEvent(self, event, ...)
    if event == "ACTIONBAR_PAGE_CHANGED" then
        if GetActionBarPage() ~= 1 then ChangeActionBarPage(1) end
    elseif event == "ADDON_LOADED" and ... == addonName then
        ActionBarUpButton:Disable()
        ActionBarDownButton:Disable()
    end
end
 
f:SetScript("OnEvent", MyFuncs.OnEvent)
f:SetScript("OnUpdate", function(self, elapsed)
    for i=1,12,1 do
        if not UnitAffectingCombat("player") then
            if MainMenuBar:IsShown() == 1 and _G["ExtraBarButton"..i]:IsShown() == nil then
                _G["ExtraBarButton"..i]:Show()
            elseif MainMenuBar:IsShown() == nil and _G["ExtraBarButton"..i]:IsShown() == 1 then
                _G["ExtraBarButton"..i]:Hide()
            end
        end
    end
end)
f:RegisterEvent("ACTIONBAR_PAGE_CHANGED")
f:RegisterEvent("ADDON_LOADED")
f:RegisterEvent("PLAYER_ENTERING_WORLD")
f:RegisterEvent("PLAYER_LOGIN")
 
for id=13,24 do
    local b = CreateFrame("CheckButton", "ExtraBarButton"..(id-12), UIParent, "ActionBarButtonTemplate")
 
    b:SetSize(36*UIParent:GetScale(), 36*UIParent:GetScale())
    b:SetAttribute("action", id)
    b:SetID(id)
    b:SetPoint("CENTER", _G["MultiBarBottomRightButton"..(id-12)], "CENTER", 0, 200)
    b:Show()
end

[Phanx]

Well, I don't know about the general idea, but these parts will definitely not work while in combat. You will get "action blocked" errors and the default action bars may even stop working.

ChangeActionBarPage(1)
ActionBarUpButton:Disable()
ActionBarDownButton:Disable()
_G["ExtraBarButton"..i]:Show()
_G["ExtraBarButton"..i]:Hide()

You can't hide, show, or disable secure/protected frames while in combat, and you can't change action bar pages while in combat, except in response to specific Blizzard-approved conditions (eg. the same ones you can check for in a macro) and using specific Blizzard-approved secure methods.

On top of that, using an OnUpdate script to hide things in combat is quite possibly the most inefficient way to do that. Here is a better way:

local f = CreateFrame("Frame") -- or use the one you already have
f:RegisterEvent("PLAYER_REGEN_DISABLED")
f:RegisterEvent("PLAYER_REGEN_ENABLED")
f:SetScript("OnEvent", function(self, event, ...) -- or add to the one you already have
     if InCombatLockdown() then return end -- safety check, not needed if frames are insecure
     SOME_OTHER_FRAME:SetShown(not UnitAffectingCombat("player")) -- hide OOC, remove "not" to show OOC instead
end)

This should work for both secure and insecure frames, since when PLAYER_REGEN_DISABLED fires to indicate entering combat, the UI isn't yet locked down, to allow addons to make changes beforehand, and when PLAYER_REGEN_ENABLED to indicate leaving combat, the UI lockdown has already been released.

Your other option would be to use a state driver:

local f = CreateFrame("Frame", "MyCombatHider", UIParent, "SecureHandlerStateTemplate")
f:SetAllPoints(true) -- not *really* needed but makes child placement easier
RegisterStateDriver(self, "visibility", "[combat] hide; show")
-- parent your other frames to MyCombatHider instead of UIParent

For swapping actionbar pages, you just can't automate that. While in combat, a hardware event (key press or mouse click) is required to change pages.

Disabling the pageup/down buttons should be safe, but only if you do it out of combat. There's no need to wait for ADDON_LOADED; you can just do it in the main chunk.

[Duugu]

Furthermore there is only a fixed number of action IDs available (120 or 130 or something). And almost all of them are in use.
That means you can't create additional action bars this way.

[10leej]

Originally Posted by Duugu Furthermore there is only a fixed number of action IDs available (120 or 130 or something). And almost all of them are in use. That means you can't create additional action bars this way.

Figured it was something like that.

Also Phanx as always thanks for the input

[Duugu]

Here's an overview on what I found out about action IDs:

1 - 12 MainMenuBar stance 2+4
13 - 19 MainMenuBar Page 2
20 - 24 Bags
25 - 36 MultiBarRight
37 - 48 MultiBarLeft
49 - 60 MultiBarBottomRight
61 - 72 MultiBarBottomLeft
73 - 84 MainMenuBar Stance 3
85 - 96 ??
97 - 108 MainMenuBar Stance 1
109- 120 ??

Don't know if the two ?? are free. One of them could be the pet bar.

I guess a class without any stances could use 73-84 and 97-108 as additional action buttons.

[e]
Afaik Geist uses this approach. It lists the action IDs as this:

1-12 Main Bar (Unused by Warriors or Monks)
13-24 Second Bar
25-36 Side Bar 1
37-48 Side Bar 2
49-60 Bottom Right Bar
61-72 Bottom Left Bar
73-84 Warrior Battle, Druid Cat, Rogue Stealth, Priest Shadowform
85-96 Warrior Defensive, Druid Tree
97-108 Warrior Berserker, Druid Bear
109-120 Druid Moonkin
121-132 Possess Bar (Unusable)

[10leej]

Ah though we had access to at least one more bar without affecting the stances. Guess not