Problems with Big Tables

[Endzeit]

Edit#2:
It works now.. but i got stutter when hover over items.. is there a way with a ~1800 table to improve performance?
-----
EDIT:
i found the problem.. this is working:

local setName =  {
[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },
-- [2......1778]
[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },
}
function addline_gametip()
local itemName,itemLink = GameTooltip:GetItem()
	if itemLink ~= nil then	   
		local itemString = string.match(itemLink, "item[%-?%d:]+");
		local _, itemId, enchantId, jewelId1, jewelId2, jewelId3, jewelId4, suffixId, uniqueId, linkLevel, reforgeId = strsplit(":", itemString);

 for i = 1, #setName do
j = 1 
while j <= 8 do

if (setName[i]['items'][j] ~= nil) and (format("%u",itemId) == format("%u", setName[i]['items'][j])) then
 		GameTooltip:AddLine("Transmog Set: " .. setName[i]['name'])
 		GameTooltip:Show();
 		end
j = j + 1
		end
 end
 end
 end

 

GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

-------

I'm working on my first wow addon and i'm a big newbie with lua and coding. I think im finished, but it dont work.

problems are the do while i think. here is my code:

local setName =  {
[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },
-- [2......1778]
[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },
}

function addline_gametip()
local itemName,itemLink = GameTooltip:GetItem()
	if itemLink ~= nil then	   
		local itemString = string.match(itemLink, "item[%-?%d:]+");
		local _, itemId, enchantId, jewelId1, jewelId2, jewelId3, jewelId4, suffixId, uniqueId, linkLevel, reforgeId = strsplit(":", itemString);

 for i = 1, #setName do
j = 1 
while j <= 8 do
 if (itemId == setName[i]['items'][j]) then
 		GameTooltip:AddLine("Transmog Set: " .. setName[i]['name'])
 		GameTooltip:Show();
 		end
j = j + 1
		end
 end
 end
 end


GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

hope someone can help me

[Mazzop]

cannot help on technical side and i am not sure if i get, what you trying to do
but what if you do table other way around and index by itemID with aray of sets name that item is in
adding tooltip then would be trivial

[elcius]

lua has no problem with very large tables, just make an itemid to setid lookup table.

local setName =  {
[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },
-- [2......1778]
[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },
}
 
-- make lookup table, ideally this would be pre-made
local itemSet = {};
for i,set in pairs(setName) do
    for j, id in pairs(set['items']) do
        itemSet[id] = i;
    end
end
 
function addline_gametip()
    local itemName,itemLink = GameTooltip:GetItem();
    if not itemLink then return end
    
    local itemId = itemLink:match('item:(%d+)');
    local setIndex = itemSet[tonumber(itemId)];
    
    if setIndex and setName[setIndex] then
        GameTooltip:AddLine("Transmog Set: " .. setName[setIndex]['name']);
    end
 end
 
 
GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

[Endzeit]

wow this works great. thanks

Next Step i want to add Message, when one of this Items received Loot.

function AddLootMsg(self, event, message, ...)
    local itemName,itemLink = GetItemInfo(itemID);
    if not itemLink then return end
    local itemId = itemLink:match('item:(%d+)');
    local setIndex = itemSet[tonumber(itemId)];
 
        if setIndex and setName[setIndex] then
        DEFAULT_CHAT_FRAME:AddMessage("Hello, World!");
    end
end
 
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT", AddLootMsg);

this is not working..
whats the different between GetItemInfo(itemID); and GameTooltip:GetItem(); ?
Can i use the same lookup table or i need a new one?
Can i use the same locals agains?

[suicidalkatt]

Originally Posted by elcius lua has no problem with very large tables, just make an itemid to setid lookup table. ~ Snip

While your method would be ideal, it doesn't really do what the author intended.

I believe they want to have the tooltip show every set that contains a particular itemID not just the first one that returns true.

local setName =  {
[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },
-- [2......1778]
[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },
}
 
-- make lookup table, this will create a list that looks something like this
--[[
local table = {
    [14090] = {201,560,888} -- Item id = Table of setName[index] values
}
]]
local itemSet = {}
do 
    for i,set in pairs(setName) do -- Looks through all the set
        for j, id in pairs(set['items']) do -- looks though just the items table within
            if not itemSet[id] then itemSet[id] = {} end -- creates a table within itemSet for each id (only once)
            tinsert(itemSet[id], i) -- inserts each set index into the table
        end
    end
end
 
function addline_gametip()
    local itemName,itemLink = GameTooltip:GetItem();
    if not itemLink then return end
    
    local itemId = tonumber(itemLink:match('item:(%d+)'));
    if itemSet[itemId] then -- if a set is found
        for i, setIndex in pairs(itemSet[itemId]) do -- for each index the id has
            GameTooltip:AddLine("Transmog Set: " .. setName[setIndex]['name']); -- add a line to the game tooltip
        end
    end
 end
 
 
GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

[Endzeit]

thanks suicidalkatt & elcius.

While your method would be ideal, it doesn't really do what the author intended. I believe they want to have the tooltip show every set that contains a particular itemID not just the first one that returns true.

1 set = 1 itemid. Both variants are correct for me. ItemId 123456 can not be in 2 Sets in my table.

function AddLootMsg(self, event, message, ...)
     if not string.match(message,'Hbattlepet') then
    local lootid = select(3, string.find(message, "item:(%d+):"))
    
    local itemName,itemLink = GetItemInfo(lootid);
    if not itemLink then return end
    
    
    local itemId = tonumber(itemLink:match('item:(%d+)'));
    
    if itemSet[itemId] then -- if a set is found
        for i, setIndex in pairs(itemSet[itemId]) do -- for each index the id has
        message = message:gsub("\124r.", "\124r (|cff9400D3Transmog Set: " .. setName[setIndex]['name'] .. "|cff00aa00).")
        return false, message, ...
 
    end
end
end
end
 
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT", AddLootMsg);

thats my code for chat_msg_loot so far.. in my first tests it works.. have someone also an improvement for this code?

[SDPhantom]

Since all the code is doing is matching items to set names, the lookup table doesn't need to be so complicated to use. Here's my example. There can be more optimizations depending on how you want the tooltip to look.

local TransmogSets={
    {
        name="Mystic's Regalia (Recolor)",
        items={14090, 26008, 14094},
    },
    {
        name="Imperial Plate",
        items={31436, 30002, 12424, 12425, 12422, 12427, 12429},
    },
--  And so on ...
};
 
--  Lookup Table
local ItemSetNames={}; do
    for _,set in ipairs(TransmogSets) do--  Scan through all sets
        for _,itemid in ipairs(set.items) do--  Scan through items
--          Add set name to list in lookup table
            if not ItemSetNames[itemid] then ItemSetNames[itemid]={}; end
            table.insert(ItemSetNames[itemid],set.name);
        end
    end
 
--  Sorts set names
    for _,list in pairs(ItemSetNames) do table.sort(list); end
end
 
--  Tooltip Hook
GameTooltip:HookScript("OnTooltipSetItem",function(self)
    local _,link=self:GetItem();
    if not link then return; end--  Exit if we have no item
 
    local id=tonumber(link:match("|Hitem:(%d+)")) or 0;--   Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] then
        for i,name in ipairs(ItemSetNames[id]) do
--          Only show our label on the first line
            self:AddDoubleLine(i<=1 and "Transmog Set:" or " ",name);
        end
    end
end);
 
--  Chat Hook
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,...)
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] then return false,msg.." (|cff9400d3Transmog Sets: "..table.concat(ItemSetNames[id],", ").."|r).",...; end
end);

Edit: Replaced string.join() section with more efficient table.concat() call.

[Endzeit]

--  Chat Hook
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,...)
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] then return false,msg.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end
end);

works.. but it also show loot from other player.. this should not happen. i tried this:

--  Chat Hook
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,...)
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] and LOOT_ITEM_PUSHED_SELF or LOOT_ITEM_SELF ~= nil then return false,msg.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end
end);

this works for myself.. but get lua errors if other player loot items.