OnClick only registering for the left mouse button?

[jostor]

Hey! I dislike the new 5.0 "feature" that changed the minimap button in battlegrounds which you use to show the scoreboard, and right click to for example leave the BG or interact with your queue to other BGs and so on. It no longer simply shows the scoreboard with a left click, it has an annoying menu with the scoreboard button way too close to the "Leave Battleground" button, and what I wanted to do was simply change it so that with the left mouse button you open the scoreboard, but with the right mouse button you open the regular menu as you normally would. For LFG instances (which now uses the same button) it should open the menu regardless of which button was used.

The first part was easy, getting the scoreboard to open with the left button, that part is working fine. However, the right mouse button simply does nothing, since my OnClick function doesn't have any code for it, but is there a simple way to make it work like it normally would, either by simply adding it into my if-clause, or having OnClick only registering the left mouse button.

Here's my code:

local frameCurrentlyShown = false
QueueStatusMinimapButton:SetScript("OnClick", function(self, button)
    isInstance, instanceType = IsInInstance()
        
    if isInstance and instanceType == "pvp" and button == "LeftButton" then
        if frameCurrentlyShown then
            WorldStateScoreFrame:Hide()
            frameCurrentlyShown = false
        else
            WorldStateScoreFrame:Show()
            frameCurrentlyShown = true
        end
    else 
        -- Show the regular menu
    end
 
end)

Simply running DropDownList1:Show() (DropDownList1 is the name of the regular frame that pops up...) doesn't work, I assume since the frame also has to be filled with information.

[Maggz]

just seems your handling the if statements and button definaitions improperly here is a small example and it probably wont work as ive not tested anything about it but here goes

local frameCurrentlyShown = false
QueueStatusMinimapButton:SetScript("OnClick", function(self, button)
    isInstance, instanceType = IsInInstance()
    if isInstance and instanceType == "pvp" 
        if button == "LeftButton" then
            if frameCurrentlyShown then
                DOSTUFF1() -- used to click if instance type is PVP and its frame is shown (left click)
            else
                DOSOMTHING1() -- used to click if instance is PVP and its frame isnt shown (left click)
            end
        else
            DOSOMETHING2() -- used to click if instance is PVP and frame shown isnt an issue and function was a right click.
        end
    end
end)

you could even define the last section further for other arguments and obtain a right and left click button function if your also not on PVP.

having too many arguements in one line like you had tends to be a bit of an issue, again i havent tried any of your code i just put it into a text editor and tried to do something that made sense to me. I am sure others have other ideas that may work even cleaner.

[Dridzt]

local QueueStatusMinimapButton_OnClick_orig = QueueStatusMinimapButton_OnClick
QueueStatusMinimapButton_OnClick = function(...)
  local _, instanceType = IsInInstance()
  local _, button = ...
  if instanceType == "pvp" and button == "LeftButton" then
    local shown = WorldStateScoreFrame:IsVisible() and WorldStateScoreFrame:Hide() or WorldStateScoreFrame:Show()
  else
    QueueStatusMinimapButton_OnClick_orig(...)
  end
end

Warning: drycoded

Alternative version of the same thing in case the button is using 'new style' <OnShow function='blah'/> handler.

local QueueStatusMinimapButton_OnClick_orig = QueueStatusMinimapButton:GetScript("OnClick")
QueueStatusMinimapButton:SetScript("OnClick", function(...)
  local _, instanceType = IsInInstance()
  local _, button = ...
  if instanceType == "pvp" and button == "LeftButton" then
    local shown = WorldStateScoreFrame:IsVisible() and WorldStateScoreFrame:Hide() or WorldStateScoreFrame:Show()
  else
    QueueStatusMinimapButton_OnClick_orig(...)
  end
end)

[p3lim]

:RegisterForClicks('LeftButton', 'RightButton')

[Dridzt]

function QueueStatusMinimapButton_OnLoad(self)
	self:RegisterForClicks("LeftButtonUp", "RightButtonUp");
	self:SetFrameLevel(self:GetFrameLevel() + 1);
end

It's already registered for Left|Right, don't think that was his problem despite the misleading title.

[jostor]

Originally Posted by Dridzt local QueueStatusMinimapButton_OnClick_orig = QueueStatusMinimapButton_OnClick QueueStatusMinimapButton_OnClick = function(...) local _, instanceType = IsInInstance() local _, button = ... if instanceType == "pvp" and button == "LeftButton" then local shown = WorldStateScoreFrame:IsVisible() and WorldStateScoreFrame:Hide() or WorldStateScoreFrame:Show() else QueueStatusMinimapButton_OnClick_orig(...) end end Warning: drycoded Alternative version of the same thing in case the button is using 'new style' <OnShow function='blah'/> handler. local QueueStatusMinimapButton_OnClick_orig = QueueStatusMinimapButton:GetScript("OnClick") QueueStatusMinimapButton:SetScript("OnClick", function(...) local _, instanceType = IsInInstance() local _, button = ... if instanceType == "pvp" and button == "LeftButton" then local shown = WorldStateScoreFrame:IsVisible() and WorldStateScoreFrame:Hide() or WorldStateScoreFrame:Show() else QueueStatusMinimapButton_OnClick_orig(...) end end)

Thank you, saving the original function was the part I was missing.

Final code (seems to be working fine as far as my testing goes):

local QueueStatusMinimapButton_OnClick_orig = QueueStatusMinimapButton:GetScript("OnClick")
QueueStatusMinimapButton:SetScript("OnClick", function(...)
    local isInstance, instanceType = IsInInstance()
    local _, button = ...
        
    if isInstance and instanceType == "pvp" and button == "LeftButton" then
        if WorldStateScoreFrame:IsVisible() then
            WorldStateScoreFrame:Hide()
        else
            WorldStateScoreFrame:Show()
        end
    else 
        QueueStatusMinimapButton_OnClick_orig(...)
    end
 
end)