Honorable Kill Combat Text

zmga · 08-13-14, 01:48 PM

I was wondering if anybody knew where this function is located in blizzard's default UI, or if anybody has any idea about what frame(s) may be involved.

Honorable Kills combat text doesn't seem to be included in the Blizzard_CombatText.xml/lua or anywhere else that would make sense. I also ran a general search using the potential events that may trigger it and didn't come up with anything.

Just to clarify, I'm talking about the text appearing on gaining honor that reads "HK Prviate" or "HK Scout" and not the honor gained (on me) that is toggleable via the in game menu.

I was hoping to either edit this frame directly or at least have a good enough sense of what's going on to be able to disable it and remake it myself.

ravagernl · 08-13-14, 03:53 PM

Originally Posted by zmga

Just to clarify, I'm talking about the text appearing on gaining honor that reads "HK Prviate" or "HK Scout" and not the honor gained (on me) that is toggleable via the in game menu.

I was hoping to either edit this frame directly [...]

That is part of the game world, like the damage text you can not modify these texts. The only thing that I think is possible, is overwriting the font with a transparent font. However, that will also disable all other texts on the 3d world, like snared, rooted, +xp, +rep, let alone combat damage/healing.

zmga · 08-14-14, 07:01 PM

Thanks for the quick response,

I've tested it and it is possible to use a transparent font to remove the HK text, but like you say it will remove all text that uses the font. (damage, miss, parry, xp, etc).

However I'm running into trouble actually changing the font on my own. Currently I've only managed to change the font using addons gdfont or xdamagefont. They both use the following code:

gdFont = CreateFrame("Frame", "gdFont");

local GD_FONT_NUMBER = "Interface\\AddOns\\gdFont\\Fonts\\SKURRI.ttf";

function gdFont:ApplySystemFonts()

DAMAGE_TEXT_FONT = GD_FONT_NUMBER;

end

gdFont:SetScript("OnEvent",

function()

if (event == "ADDON_LOADED") then

gdFont:ApplySystemFonts()

end
end);

gdFont:RegisterEvent("ADDON_LOADED");

gdFont:ApplySystemFonts()

It seems to me that the only thing going on here is that the global variable DAMAGE_TEXT_FONT is being changed to a custom file path. But there is definitely something else happening because simply changing the global doesn't do anything.

I tried to rewrite a function that would change the global variable and executed it OnLoad or using the event ADDON_LOADED without any success (outside of changing the string associated with the global)

Moreover the when I removed that last line of code "gdFont:ApplySystemFonts()" (which looked redundant) the addon ceased to work.

Anybody know why this is the case?

Phanx · 08-14-14, 08:27 PM

Reloading the UI only reloads the UI. Since the overhead text that shows HKs is not rendered as part of the UI, it's not affected by reloading the UI, and it won't pick up on changes to the DAMAGE_TEXT_FONT global during play. You'll need to log out and back in to apply any changes.

Removing the last line in that code makes it stop working, because you have to set DAMAGE_TEXT_FONT in the main chunk. If you wait for ADDON_LOADED, you're probably too late. If that's the entirety of the addon, then it can be stripped down to a single line of code without losing any functionality:

Code:

DAMAGE_TEXT_FONT = "Interface\\AddOns\\gdFont\\Fonts\\SKURRI.ttf"