Player in HP% & Target HP in CurrentHP/HP%

[shoegum]

Hello,

I am trying to combine these two functions. I would like the player frame to follow the first function, which has the health displayed as a percent value. I would like the target frame to follow the second function, which has the health displayed as current health + percent value.

How can these be combined so Player Frame receives the "percent function" and Target/Focus Frames receive the "current health + percent function"? If someone coule help right it and rename the new format if (GhettoFramesSaveX.hformat==2) This is because the only way I know how to change format is thru the config menu provided by the author's original work.

The lua code has been pulled from the addon Ghetto Frames.

If Framelist = {"Target", "Focus", "Player"} could be separated so Function A effects "Target/Focus" and Function B effects "Player"

if (GhettoFramesSaveX.hformat==1) then--percent
        FrameList = {"Target", "Focus", "Player"}
         function UpdateHealthValues(...)
        for i = 1, select("#", unpack(FrameList)) do
            local FrameName = (select(i, unpack(FrameList)))
            if (0 < UnitHealth(FrameName)) then 
                local Health = UnitHealth(FrameName)
                local HealthMax = UnitHealthMax(FrameName)
                local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
                _G[FrameName.."FrameHealthBar"].TextString:SetText(format("%.0f",HealthPercent).."%")
            
            end
        end
 end
 
         hooksecurefunc("TextStatusBar_UpdateTextStringWithValues", UpdateHealthValues)
 
 
   end

if (GhettoFramesSaveX.hformat==3) then --currenthealth + percent
   FrameList = {"Target", "Focus", "Player"}
         function UpdateHealthValues(...)
for i = 1, select("#", unpack(FrameList)) do
local FrameName = (select(i, unpack(FrameList)))
       if (0 < UnitHealth(FrameName)) then 
       if UnitHealth(FrameName) < 1000 then
            local Health = UnitHealth(FrameName)
            local HealthMax = UnitHealthMax(FrameName)
            local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
            _G[FrameName.."FrameHealthBar"].TextString:SetText(Health.." ("..format("%.0f",HealthPercent).."%)")
        elseif (UnitHealth(FrameName) < 1000000) then
            local Health = (UnitHealth(FrameName))/1000
            local HealthMax = (UnitHealthMax(FrameName))/1000
            local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
            _G[FrameName.."FrameHealthBar"].TextString:SetText(format("%.0f",Health).."k ("..format("%.0f",HealthPercent).."%)")
        elseif (1000000<=UnitHealth(FrameName)) then
            local Health = (UnitHealth(FrameName))/1000000
            local HealthMax = (UnitHealthMax(FrameName))/1000000
            local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
            _G[FrameName.."FrameHealthBar"].TextString:SetText(format("%.0f",Health).."m ("..format("%.0f",HealthPercent).."%)")
        end      
end
end
end
hooksecurefunc("TextStatusBar_UpdateTextStringWithValues", UpdateHealthValues)
end

[shoegum]

Would this work?

FrameList = {"Player"}
         function UpdateHealthValues(...)
        for i = 1, select("#", unpack(FrameList)) do
            local FrameName = (select(i, unpack(FrameList)))
            if (0 < UnitHealth(FrameName)) then 
                local Health = UnitHealth(FrameName)
                local HealthMax = UnitHealthMax(FrameName)
                local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
                _G[FrameName.."FrameHealthBar"].TextString:SetText(format("%.0f",HealthPercent).."%")
            
            end
        end
 end
        FrameList = {"Target", "Focus"}
    function UpdateHealthValues(...)
        for i = 1, select("#", unpack(FrameList)) do
            local FrameName = (select(i, unpack(FrameList)))
            if (0 < UnitHealth(FrameName)) then 
            if UnitHealth(FrameName) < 1000 then
                local Health = UnitHealth(FrameName)
                local HealthMax = UnitHealthMax(FrameName)
                local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
                _G[FrameName.."FrameHealthBar"].TextString:SetText(Health.." ("..format("%.0f",HealthPercent).."%)")
        elseif (UnitHealth(FrameName) < 1000000) then
            local Health = (UnitHealth(FrameName))/1000
            local HealthMax = (UnitHealthMax(FrameName))/1000
            local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
            _G[FrameName.."FrameHealthBar"].TextString:SetText(format("%.0f",Health).."k ("..format("%.0f",HealthPercent).."%)")
        elseif (1000000<=UnitHealth(FrameName)) then
            local Health = (UnitHealth(FrameName))/1000000
            local HealthMax = (UnitHealthMax(FrameName))/1000000
            local HealthPercent = (UnitHealth(FrameName)/UnitHealthMax(FrameName))*100
            _G[FrameName.."FrameHealthBar"].TextString:SetText(format("%.0f",Health).."m ("..format("%.0f",HealthPercent).."%)")
        end      
end
end
end
hooksecurefunc("TextStatusBar_UpdateTextStringWithValues", UpdateHealthValues)
end

Edit: After setting this to option #2. It works with no errors in bug-sack.

The player health first appeared as Current Health/Total Health; but going into the game menu Esc>Interface>Status Text>Drop Down Menu then set to Percentage the unit frames are showing up exactly how I want. The player frame is shown just as a Percentage while my Target and Focus frames are showing Current Health/Percentage.

If anyone can confirm this I would greatly appreciate it as I have no knowledge of coding and just cut and pasted what I thought was reasonable.

[Lombra]

Well, if it works, it works. What do you want confirmed? :P There are definitely ways to make that code better, though, but first; have you tried the "percent + absolute" option in interface options? It would be easier to modify the player frame to use only percentage and let the existing code handle the rest, than the other way around, if that works for you.

[semlar]

You could do something like this..

local caps = {'k', 'm', 'b', 't'}
hooksecurefunc('TextStatusBar_UpdateTextStringWithValues', function(f, text, value, _, maxValue)
    if f == PlayerFrameHealthBar then
        text:SetFormattedText('%.0f%%', value / maxValue * 100)
    elseif f == TargetFrameHealthBar or f == FocusFrameHealthBar then
        local breaks = min(#caps, floor((strlen(value) - 1) / 3))
        text:SetFormattedText('%.0f%s (%.0f%%)', value / 1000 ^ breaks, breaks > 0 and caps[breaks] or '', value / maxValue * 100)
    end
end)

[shoegum]

Hey great ideas. Thank you so very much.