Thread Tools Display Modes
12-31-14, 02:02 AM   #1
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
Using LibBabble for Translations

There are some Libs for Translations. I think it's better to Use this one, insteed of adding translations:


See:

http://www.wowace.com/search/?scope=...rch=LibBabble-
  Reply With Quote
12-31-14, 04:53 AM   #2
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
Added Support in last Commint for LibBabble-Boss
  Reply With Quote
12-31-14, 01:02 PM   #3
atl77
A Chromatic Dragonspawn
Join Date: Oct 2014
Posts: 179
Originally Posted by gOOvER View Post
Added Support in last Commint for LibBabble-Boss
Pull Request denied, reasons here: https://github.com/Rythal/Carbonite/pull/202
  Reply With Quote
01-01-15, 12:38 AM   #4
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
And why you close it? i can revert the 3 lines.

Please reopen, i don't want to loose the other work.
  Reply With Quote
01-01-15, 12:50 AM   #5
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
Re-opened it.

Still new to git but I believe you should of still had your groover/Master which could of been used to push a new commit after the library was removed.
  Reply With Quote
01-01-15, 01:42 AM   #6
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
Yes, your right. But so i would open a new PR

Lib Remove and Translations Carbonite.Weekly up2date for all languages
  Reply With Quote
01-01-15, 03:16 AM   #7
atl77
A Chromatic Dragonspawn
Join Date: Oct 2014
Posts: 179
I would advise against translating debug messages, since you would have to look them up when someone mentions them, which would be a waste of time. Otherwise, I have no objection against merging this.
  Reply With Quote
01-01-15, 04:34 AM   #8
gOOvER
A Theradrim Guardian
 
gOOvER's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 62
I did not translate all Strings. Some, i mean, are also usefull for Users for Info, when something is not working
  Reply With Quote

WoWInterface » Featured Projects » Carbonite » Carbonite: Dev Talk » Using LibBabble for Translations

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off