Thread Tools Display Modes
08-20-17, 01:04 PM   #1
KrysEmlyn
A Fallenroot Satyr
Join Date: Nov 2011
Posts: 28
Exclamation Map Scale Keybinding Isn't Working

I've updated to the latest version of Carbonite today and I set a keybinding of "Control+T" for the restoring the map scale to the saved map scale. Carbonite spits an error if I try to use the keybinding:

Code:
Carbonite\NxMap.lua:2668: attempt to index local 'self' (a nil value)
Carbonite\NxMap.lua:2668: in function `NXMapKeyScaleRestore'
[string "NxMAPSCALERESTORE"]:1: in function <[string "NxMAPSCALERESTORE"]:1>

Locals:
self = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'self' (a nil value)"
Can this be fixed, please?
  Reply With Quote
08-20-17, 04:41 PM   #2
jeffy162
A Pyroguard Emberseer
 
jeffy162's Avatar
AddOn Author - Click to view addons
Join Date: May 2009
Posts: 2,364
It MAY not have to be "fixed". Did you try another modifier (shift or alt) key combination? I know control is used for something to do with the map (or at least it used to be when I played yet). Besides, testing that out first would help, maybe, a little bit.

By-the-way, what happens when you right click the map and try restoring your map scale in the right click menu?
__________________
Ahhhh, the vagueries of the aging mind. Wait.... What was I saying?


Carbonite <----- GitHub main module (Maps ONLY) download link. The other modules are also available on GitHub.
Carbonite-CLASSIC<----- GitHub link to Carbonite Classic. Thanks to ircdirk for this!

Last edited by jeffy162 : 08-20-17 at 04:46 PM. Reason: More blah blah blah.
  Reply With Quote
08-20-17, 07:13 PM   #3
KrysEmlyn
A Fallenroot Satyr
Join Date: Nov 2011
Posts: 28
Jeffy,

Using the Alt or Shift modifier keys results in the same error:
Code:
Carbonite\NxMap.lua:2668: attempt to index local 'self' (a nil value)
Carbonite\NxMap.lua:2668: in function `NXMapKeyScaleRestore'
[string "NxMAPSCALERESTORE"]:1: in function <[string "NxMAPSCALERESTORE"]:1>

Locals:
self = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'self' (a nil value)"
Further testing of just using letter keys without modifiers also results in this same error.

Right-clicking the mini map and selecting Restore Map Scale works just fine, though.
  Reply With Quote
08-21-17, 07:47 AM   #4
jeffy162
A Pyroguard Emberseer
 
jeffy162's Avatar
AddOn Author - Click to view addons
Join Date: May 2009
Posts: 2,364
Hmmm..... Have you eliminated other addon interference? With Carbonite I mean.
__________________
Ahhhh, the vagueries of the aging mind. Wait.... What was I saying?


Carbonite <----- GitHub main module (Maps ONLY) download link. The other modules are also available on GitHub.
Carbonite-CLASSIC<----- GitHub link to Carbonite Classic. Thanks to ircdirk for this!
  Reply With Quote
08-29-17, 06:56 PM   #5
KrysEmlyn
A Fallenroot Satyr
Join Date: Nov 2011
Posts: 28
I have not eliminated other addon interference, but I discovered a code change in the Carbonite Maps Github repository. Applying that code change does allow the keybind for restoring the map scale to function like it used to.
  Reply With Quote
08-30-17, 08:29 AM   #6
ircdirk
A Molten Giant
 
ircdirk's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2014
Posts: 823
Originally Posted by KrysEmlyn View Post
I have not eliminated other addon interference, but I discovered a code change in the Carbonite Maps Github repository. Applying that code change does allow the keybind for restoring the map scale to function like it used to.
Propose Pull Request on GitHub Carbonite repo to fix this problem.
  Reply With Quote
08-30-17, 08:24 PM   #7
KrysEmlyn
A Fallenroot Satyr
Join Date: Nov 2011
Posts: 28
The fix I mentioned has already been rolled into Carbonite:
Code:
 function Nx:NXMapKeyScaleRestore()
-	local map = self.Map:GetMap (1)
+	local map = Nx.Map:GetMap (1)
 	map:Menu_OnScaleRestore()
 end
(Copied from the GitHub repository)

I copied this change into my local copy yesterday to test that it works as I think I saw a comment about having the change tested. I'll be downloading the alpha version that was put out today, which contains this fix.
  Reply With Quote

WoWInterface » Featured Projects » Carbonite » Carbonite: Maps (Main AddOn) » Map Scale Keybinding Isn't Working

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off