Help with an addon i am making.

[darrare]

Im making an addon that tracks combat stats for a hunter such as agility, ap, crit, mastery, haste, etc.

i have it displaying correctly, but my only problem is i have no way for it to update at a reasonable rate.

local function updateFunction()
AgilityLine.text:SetText("Agility = ".. getRangedAgility())
AttackPowerLine.text:SetText("AP = ".. getRangedAttackPower())
CritLine.text:SetText("Crit = ".. getRangedCrit() .."%")
MasteryLine.text:SetText("Mastery = ".. getRangedMastery())
HasteLine.text:SetText("Haste = ".. getHaste() .."%")
end

i have this function that updates it correctly, but i have no idea how to impliment a way to make it only update when it should, and not 60 times a second.

any help would be appreciated

[Yafis]

You have update on OnUpdate?

[darrare]

Originally Posted by Yafis You have update on OnUpdate?

not sure i understand, is OnUpdate some sort of built in function?

[SDPhantom]

For now, you need to create a frame that'll run the code in its OnUpdate handler.

local lastupdate=0;--   Local storing how long since our last update
local frame=CreateFrame("Frame");-- Our frame
 
frame:SetScript("OnUpdate",function(self,elapsed)
    lastupdate=lastupdate+elapsed;--    Add elapsed to update local
    if lastupdate>1 then--  If it's been a second, update
        AgilityLine.text:SetText("Agility = ".. getRangedAgility());
        AttackPowerLine.text:SetText("AP = ".. getRangedAttackPower());
        CritLine.text:SetText("Crit = ".. getRangedCrit() .."%");
        MasteryLine.text:SetText("Mastery = ".. getRangedMastery());
        HasteLine.text:SetText("Haste = ".. getHaste() .."%");
 
        lastupdate=0;-- Reset to zero
    end
end);

In WoD, we'll be getting a new C_Timer system to handle this.
When this happens, your code would look like this.

C_Timer.NewTicker(1,function()--    Register a function to update every second
    AgilityLine.text:SetText("Agility = ".. getRangedAgility());
    AttackPowerLine.text:SetText("AP = ".. getRangedAttackPower());
    CritLine.text:SetText("Crit = ".. getRangedCrit() .."%");
    MasteryLine.text:SetText("Mastery = ".. getRangedMastery());
    HasteLine.text:SetText("Haste = ".. getHaste() .."%");
end);

Note: To enable Lua syntax highlighting on these forums, surround the code with [highlight=lua] [/highlight].
This is also visible as a Lua button on the right side of the formatting toolbar in the message editor.

[Phanx]

I'm pretty sure there are events that fire when these stats changed, so there's no reason to use an OnUpdate script here. Just register for the event(s) that tell you when your stats change, and update when they fire:

local f = CreateFrame("Frame")
f:RegisterEvent("HEY_YOUR_STATS_CHANGED") -- not the real event name
f:RegisterEvent("SOME_OTHER_EVENT")
f:SetScript("OnEvent", function(self, event, ...)
     -- update the display here
end)

Use the /eventtrace command in-game, do something that changes your stats, and look in the window to see which event fired. I recommend either doing this far away from other players, or leaving /eventtrace open for a minute beforehand and removing all the irrelevant events that are filling the window (hover and click the X).

[Resike]

The event you looking for is "UNIT_STATS".

[Cybeloras]

You will also need COMBAT_RATING_UPDATE since UNIT_STATS will only cover changes in agility.

[MaLarsson]

I feel that it is a good practice to always check which events you want to listen to before beginning with the code.
Wowwiki has a list of all the events: http://www.wowwiki.com/Events_A-Z_(Full_List)
You can try adding something like this to your code:

local frame, events = CreateFrame("Frame", nil, UIParent), {}
 
function events:UNIT_STATS(unitID)
   if unitID == "player" then
      updateFunction()
   end
end
 
function events:COMBAT_RATING_UPDATE()
   updateFunction()
end
 
for k, v in pairs(events) do
   frame:RegisterEvent(k)
end