Jewelcrafting

[Tonyleila]

Searching for the right gem realy sucks. I always know the stats I need but not the name of the gem. So GemHelper looks like a nice addon but its realy too much for my needs.

Cool woud be a namechange inside the original skill window. Instead of the gem name it shoud show the stats of the gem but the name is still searchable. Anyone know an addon like this or know if this is even possible?
Other idea woud be to show the gem tooltip on mouseover so you don't have to klick each gem to know the stats.

Woud look like the right one:

[p3lim]

local disabled = true
local button

local tip = CreateFrame('GameTooltip', 'GemStatsTip')
local line1 = tip:CreateFontString()
local line2 = tip:CreateFontString()
local line3 = tip:CreateFontString()

tip:AddFontStrings(tip:CreateFontString(), tip:CreateFontString())
tip:AddFontStrings(line1, tip:CreateFontString())
tip:AddFontStrings(line2, tip:CreateFontString())
tip:AddFontStrings(line3, tip:CreateFontString())

local JEWELCRAFTING_S = GetSpellInfo(25229)
local GEM_S = '%+[0-9]+.*'

local match = string.match

local function GetGemStats(id)
	tip:SetOwner(WorldFrame, 'ANCHOR_NONE')
	tip:SetTradeSkillItem(id)

	if(tip:IsShown()) then
		return match(line1:GetText() or '', GEM_S) or match(line2:GetText() or '', GEM_S) or match(line3:GetText() or '', GEM_S)
	end
end

local function Update()
	if(GetTradeSkillLine() ~= JEWELCRAFTING_S) then
		if(button) then
			button:Hide()
		end

		return
	else
		button:Show()
	end

	if(not IsTradeSkillReady()) then return end
	if(disabled) then return end

	local filterBar = TradeSkillFilterBar:IsShown()
	for index = 1, TRADE_SKILLS_DISPLAYED, 1 do
		local buttonIndex = filterBar and index + 1 or index

		local button = _G['TradeSkillSkill' .. buttonIndex]
		if(button) then
			local stats = GetGemStats(button:GetID())
			if(stats) then
				_G['TradeSkillSkill' .. buttonIndex .. 'Text']:SetText(stats)
			end
		end
	end
end

local f = CreateFrame('Frame')
f:RegisterEvent('ADDON_LOADED')
f:SetScript('OnEvent', function(self, event, name)
	if(name == 'Blizzard_TradeSkillUI') then
		button = CreateFrame('Button', 'SomeRandomButton123', TradeSkillFrame, 'UIPanelButtonTemplate')
		button:SetPoint('TOPRIGHT', TradeSkillFrameCloseButton, 'TOPLEFT', 4, -6)
		button:SetSize(22, 20)
		button:SetText('J')
		button:SetScript('OnClick', function()
			disabled = not disabled
			TradeSkillFrame_Update()
		end)

		hooksecurefunc('TradeSkillFrame_Update', Update)
	end
end)

Keep in mind you have to change JEWELCRAFTING_S to whatever "Jewelcrafting" is in your locale.
And the search function doesn't see this, it still looks for the name.

[myrroddin]

Originally Posted by p3lim Keep in mind you have to change JEWELCRAFTING_S to whatever "Jewelcrafting" is in your locale.

local jewelcrafting = GetSpellInfo(755)

[Tonyleila]

thank you both! But can't get this to work on german client :/
Can anyone post full lua file again?

[Phanx]

In p3lim's code, replace this:

local JEWELCRAFTING_S = 'Jewelcrafting'

with this:

local JEWELCRAFTING_S = GetSpellInfo(755)

If that still doesn't work, please be more specific about what isn't working in German, and make sure you have BugSack turned on to catch errors.

[Tonyleila]

It for me it not changing anything looks as if the addon is not there but is shown in the addon list. So this is the code how i cange it.

EDIT:
This is how the german tooltip looks like - maybe its different?


juwe.toc

## Interface: 50200
## Notes: Jewelcrafting gems stats instead of names
## Version: 1.0
## Title: Juwe
## Author: p3lim
juwe.lua

juwe.lua

local tip = CreateFrame('GameTooltip', 'GemStatsTip')
    local line1 = tip:CreateFontString()
    local line2 = tip:CreateFontString()
    local line3 = tip:CreateFontString()
     
    tip:AddFontStrings(tip:CreateFontString(), tip:CreateFontString())
    tip:AddFontStrings(line1, tip:CreateFontString())
    tip:AddFontStrings(line2, tip:CreateFontString())
    tip:AddFontStrings(line3, tip:CreateFontString())
     
local JEWELCRAFTING_S = GetSpellInfo(755)
    local GEM_S = '%+[0-9]+.*'
     
    local match = string.match
     
    local function GetGemStats(id)
        tip:SetOwner(WorldFrame, 'ANCHOR_NONE')
        tip:SetTradeSkillItem(id)
     
        if(tip:IsShown()) then
            return match(line1:GetText() or '', GEM_S) or match(line2:GetText() or '', GEM_S) or match(line3:GetText() or '', GEM_S)
        end
    end
     
    local function Update()
        if(GetTradeSkillLine() ~= JEWELCRAFTING_S) then return end
        if(not IsTradeSkillReady()) then return end
     
        local filterBar = TradeSkillFilterBar:IsShown()
        for index = 1, TRADE_SKILLS_DISPLAYED, 1 do
            local buttonIndex = filterBar and index + 1 or index
     
            local stats = GetGemStats(_G['TradeSkillSkill' .. buttonIndex]:GetID())
            if(stats) then
                _G['TradeSkillSkill' .. buttonIndex .. 'Text']:SetText(stats)
            end
        end
    end
     
    local f = CreateFrame('Frame')
    f:RegisterEvent('ADDON_LOADED')
    f:SetScript('OnEvent', function(self, event, name)
        if(name == 'Blizzard_TradeSkillUI') then
            hooksecurefunc('TradeSkillFrame_Update', Update)
        end
    end)

[Stanzilla]

Originally Posted by Phanx In p3lim's code, replace this: local JEWELCRAFTING_S = 'Jewelcrafting' with this: local JEWELCRAFTING_S = GetSpellInfo(755) If that still doesn't work, please be more specific about what isn't working in German, and make sure you have BugSack turned on to catch errors.

755 is Health Funnel, though. You want 25229.