Better Saved Variables Tutorial?

[p3lim]

The following worked perfectly for me

function pMinimap:ADDON_LOADED(event)
	pMinimapDB = pMinimapDB or {}
	for k,v in pairs(defaults) do
		if(type(pMinimapDB[k]) == 'nil') then
			pMinimapDB[k] = v
		end
	end

	self:UnregisterEvent(event)

	-- rest of the addon here

end

[Slakah]

Originally Posted by p3lim The following worked perfectly for me function pMinimap:ADDON_LOADED(event) pMinimapDB = pMinimapDB or {} for k,v in pairs(defaults) do if(type(pMinimapDB[k]) == 'nil') then pMinimapDB[k] = v end end self:UnregisterEvent(event) -- rest of the addon here end

yup that would work.

Just a quick note though pMinimap:ADDON_LOADED will be called multiple times even though you've unregistered the event, check the addonarg matches your own addonname before doing anything.

[p3lim]

Originally Posted by Slakah yup that would work. Just a quick note though pMinimap:ADDON_LOADED will be called multiple times even though you've unregistered the event, check the addonarg matches your own addonname before doing anything.

Tested it with a simple print inside the function, only ran once

[slizen]

Originally Posted by p3lim Tested it with a simple print inside the function, only ran once

Yes, it runs once when the first addon loads, which might or might more likely not be pMinimap. It works fine though unless you need to do something that requires your specific addon to be loaded before doing it.

[Akryn]

Originally Posted by slizen Yes, it runs once when the first addon loads, which might or might more likely not be pMinimap. It works fine though unless you need to do something that requires your specific addon to be loaded before doing it.

which of course you do, in this case.

just to clarify...ADDON_LOADED fires for all frames that have it registered every time any addon loads, which means it almost certainly will fire numerous times -- and your handler for it will execute numerous times -- before your own saved variables have been loaded

[Seerah]

Yes, when ADDON_LOADED or VARIABLES_LOADED fires, you should check to make sure that it was for your addon/variables. I, personally, prefer to use the PLAYER_LOGIN event. It will only fire once, and pretty much everything should be loaded and ready by then.

[slizen]

I'm pretty sure all enabled addon's saved variables are ready by the time the first ADDON_LOADED fires, since p3lim says it works even without a addon name check.

[Akryn]

Originally Posted by slizen I'm pretty sure all enabled addon's saved variables are ready by the time the first ADDON_LOADED fires, since p3lim says it works even without a addon name check.

it's possible that they changed how the event works, but i doubt it.
VARIABLES_LOADED is the event that fires when all addons have had their saved variables loaded. ADDON_LOADED fires after each successive addon's variables are loaded (and when LOD addons load). thus, for VARIABLES_LOADED, you don't need to do a check; for ADDON_LOADED, you should, assuming that you actually need your variables to have been loaded.

[Slakah]

Originally Posted by slizen I'm pretty sure all enabled addon's saved variables are ready by the time the first ADDON_LOADED fires, since p3lim says it works even without a addon name check.

The addonname check is to prevent the "OnEvent" function being called more than once.

[Seerah]

Originally Posted by Akryn it's possible that they changed how the event works, but i doubt it. VARIABLES_LOADED is the event that fires when all addons have had their saved variables loaded. ADDON_LOADED fires after each successive addon's variables are loaded (and when LOD addons load). thus, for VARIABLES_LOADED, you don't need to do a check; for ADDON_LOADED, you should, assuming that you actually need your variables to have been loaded.

Ah, yes, that's right.
http://www.wowwiki.com/Events_that_f...oading_process

[slizen]

Originally Posted by Slakah The addonname check is to prevent the "OnEvent" function being called more than once.

Yes, but if it's the case that all addons's saved variables are loaded when the first ADDON_LOADED fires you can just skip the addon name check and unregister ADDON_LOADED right after it has fired for the first time.

[Seerah]

But that's not how the event works, as documented by the wowwiki link I posted above.

[Akryn]

And if you want to do it that way, you can just use VARIABLES_LOADED, and not worry about name checks or unregistering the event. VARIABLES_LOADED, or PLAYER_LOGIN or PLAYER_ENTERING_WORLD (but don't use that one) or something, is actually better than ADDON_LOADED unless your addon is LOD, imo.