SVN Feedback - Page 2

Broessel01 · 05-22-08, 02:59 PM

Originally Posted by Seerah

are you copy/pasting it in or typing?

I type all.

Cladhaire · 05-22-08, 03:39 PM

Originally Posted by Mikord

This is an excellent addition to WoWInterface. Thank you to all those who worked to implement it.

One suggestion I have is to install a pre-revprop-change hook to allow svn:log updates to correct commit log errors.

The typical command to do this is:

svn propset --revprop -r <revision> svn:log "This is the corrected log message."

For a linux type of environment, the hook could look like this:

Code:

#!/bin/sh
REPOS="$1"
REV="$2"
USER="$3"
PROPNAME="$4"

if [ "$PROPNAME" = "svn:log" ]; then exit 0; fi

echo "Changing revision properties other than svn:log is prohibited" >&2
exit 1

It would need to be named pre-revprop-change and made executable. It is typically located in a svn/hooks directory.

This hook would allow the svn:log unversioned revision property to be changed (with appropriate user/pass permissions of course) and disallow changing any others thereby allowing log updates without compromising other properties.

Thanks, I'm fully aware of how to set up revprops to work, but I fail to see why there is a specific need for it. Its extremely rare to need to alter the log after the fact. That being said, I will consider it.

***Dolby*** · 05-22-08, 03:39 PM

Try generating a new password see if that fixes things for you Broessel01.

Mikord · 05-22-08, 07:14 PM

Originally Posted by Cladhaire

Thanks, I'm fully aware of how to set up revprops to work, but I fail to see why there is a specific need for it. Its extremely rare to need to alter the log after the fact. That being said, I will consider it.

I thank you for considering it.

I would have to disagree with you about the rarity of needing to alter a log message however. You seem quite familiar with SVN and as such I'm sure you know it is actually quite common for log entries to have typos, accidental omissions, useless entries, etc.

Allowing a repository admin to clean up these errors provides a much cleaner log history when you need it 6 months later.

Whether or not it's implemented, I'm still extremely pleased with the system and the fact WoWI is offering it. Excellent job all around.

**Seerah** · 05-22-08, 08:56 PM

Originally Posted by Dolby

Whoops, fixed

Thanks, Dolby! <3

Broessel01 · 05-23-08, 03:19 PM

Originally Posted by Dolby

Try generating a new password see if that fixes things for you Broessel01.

Can't login

***Dolby*** · 05-23-08, 05:26 PM

What SVN client are you using? I was able to login to your account just fine... http://svn.wowinterface.com/listing....%2F&rev=2&sc=0 (see my test commit under your name?, once you get it working I can reset the SVN to remove my test commit if you want)

Broessel01 · 05-23-08, 07:21 PM

Originally Posted by Dolby

What SVN client are you using? I was able to login to your account just fine... http://svn.wowinterface.com/listing....%2F&rev=2&sc=0 (see my test commit under your name?, once you get it working I can reset the SVN to remove my test commit if you want)

Thx, but now i works

Dreadlorde · 05-26-08, 07:58 AM

Could we get the option ro rename projects?

***Dolby*** · 05-26-08, 10:53 AM

Originally Posted by Dreadlorde

Could we get the option ro rename projects?

Good idea, will add that to my list.

JoshBorke · 05-31-08, 09:49 AM

When comparing to previous, the style of the page changes depending on where your mouse is located.

Specifically it is one style when over the diff area and another style when in the options above (SVN Options, Portal, etc)

Cralor · 06-09-08, 01:39 PM

This is not working right on the Light theme.

Overall it is nice, though.

Thanks!

dafire · 06-19-08, 09:49 AM

svn 1.5.0 is out and adds sparse checkouts and merge tracking.

I think merge tracking might be great for people who create branches of other addons or compilations that change original addons to track and merge changes to the original addons .9

acapela · 08-26-09, 06:43 AM

trying to add a WoWI user to the "team" for my SVN repository, a new collaborator to whom i wish to grant commit authority.

i traverse to this website feature via "Projects>SVN Options>Team Permissions" for the project i want to modify.

however, entering their user name, either their "plain" WoWI user name or the SVN user name (with the 5-digit number at the end), and clicking the "Add" button, seems to have no effect. the page refreshes, no error message results (that i can see), but no new user name appears under "Team Directory Permissions", etc. i have done this before, successfully, without difficulty (some time ago). so, from my perspective, behavior seems to have changed.

the repository is open to public view (does that preclude user-level control like this?). did not see anything listed for this specifically under "Help>SVN Help". what am i doing wrong?

***Dolby*** · 08-26-09, 11:55 AM

The user your trying to add needs to have a SVN account enabled. All they need to do is visit the SVN area, enable it and generate a password. Then you can add them.

*Remember: The user your adding must already have SVN enabled on their account. You may add the same user multiple times.

acapela · 08-26-09, 03:24 PM

Originally Posted by Dolby

The user your trying to add needs to have a SVN account enabled. All they need to do is visit the SVN area, enable it and generate a password. Then you can add them.

hmm, i had understood this had already happened (as described in my post, i tried to add them using the SVN user ID they supplied, in the form that has the 5-digit number embedded in it).

could they have created an SVN user ID, and believed it was "enabled", but then experienced some delay before it became valid? a delay that is still in progress?

anyway, i just tried adding them again, using the ID as they supplied it to me, with the same result (silent lack of results). if approving a new SVN user ID is a multi-day process, or something, this could explain what is happening.

Cladhaire · 08-26-09, 03:44 PM

Creating the SVN account is instantaneous and requires no approval. Do you have javascript disabled for that page? Enable it and try again. When you type their name it will come up in the suggestions.

***Dolby*** · 08-26-09, 06:53 PM

Can you PM me the username or userid your trying to add so that I may check their SVN account? What web browser are you using? What SVN project are you trying to add them to?

There is no approval process for creating an SVN account.

I've just added a few team members to my test project and that code hasn't been changed for a very long time. So I'll need the above info to continue to diagnose the problem.