in progress

[ObbleYeah]

trying out a font

[10leej]

Originally Posted by ObbleYeah trying out a font

I like it.

[ObbleYeah]

decided on a whim to try !beautycase and my texture for button skinning. Actionbar, Watchframe etc. are using !bc, buffs are not. I think the difference is clear enough visually:

just need to work out how to lower the frame strata on the !bc skins for certain objects at some point.

wish i didn't have to rely on rescaling the UI so that the frames lose their crispness, but everything becomes comically oversized at my resolution otherwise.

[10leej]

Which version of !Beauty case are you using?

[ObbleYeah]

the one hosted on WowI. Is there another one?

[10leej]

Originally Posted by ObbleYeah the one hosted on WowI. Is there another one?

Yeah the one in the neav ui download. Uses a different function and I believe it allows you to control the from level as well. What happened is that Neal never updated the standalone and didn't put ballagarba (current maintainer) on that project.

[ObbleYeah]

hmn, i'll check his git. thanks

[ObbleYeah]

finally got type-coloured debuffs working by rewriting and updating an ancient version of pBuff :roll eyes:
might host this at some point once the last few kinks are ironed out.

[ObbleYeah]

me again, been skinning things


posting because I'm interested in skinning that icon in the raid warning (which is Deadly Boss Mods) but dunno if it's possible. Is there a simple way to accomplish that? I vaguely found this snippet in affli's tukui DBM skin which crops the blizz borders, but doesn't do anything beyond that.

local croprwicons=true          -- crops shitty blizz borders from icons in RaidWarning messages
local rwiconsize=18
 
if (croprwicons) then
    local replace=string.gsub
    local old=RaidNotice_AddMessage
    RaidNotice_AddMessage=function(noticeFrame, textString, colorInfo)
        if textString:find(" |T") then
            textString=replace(textString,"(:12:12)",":"..rwiconsize..":"..rwiconsize..":0:0:64:64:5:59:5:59")
        end
        return old(noticeFrame, textString, colorInfo)
    end
end

[Phanx]

Originally Posted by ObbleYeah ... I'm interested in skinning that icon in the raid warning (which is Deadly Boss Mods) but dunno if it's possible. Is there a simple way to accomplish that? I vaguely found this snippet in affli's tukui DBM skin which crops the blizz borders, but doesn't do anything beyond that.

What do you want it to do beyond that?

Also, why bother creating a local replace upvalue to string.gsub instead of just using gsub directly? Messages aren't added to the raid warning function frequently enough for an upvalue to offer any benefit, so you're better off not cluttering up your code with one, but if you really must, at least use the correct function name... replace was an actual (and distinct from gsub) string function prior to Cataclysm (?) but is now deprecated.

[ObbleYeah]

Sorry, should have been more explicit. I want - if possible - to add an overlay border texture to the icon in a raid warning; rather than just trim the edges of it. The code is not my own and I did wonder myself why the original author used that particular local.

I get the feeling it might be a tricky request because it all seems to be handled as a text string - but I'd be happy to hear otherwise.

[Phanx]

Originally Posted by ObbleYeah I want - if possible - to add an overlay border texture to the icon in a raid warning; rather than just trim the edges of it. ... I get the feeling it might be a tricky request because it all seems to be handled as a text string - but I'd be happy to hear otherwise.

It's not possible to overlap textures in a font string. You'd have to remove the embedded texture from the string, and then manually create a real texture object, anchor it to the left side of the font string, and set it to display the same texture, and then hide or update it for future messages that included no texture, or a different texture. This would require more than just hooking the AddMessage method -- you'd need to go deeper into the underlying ScrollingMessageFrame architecture of the RaidWarningFrame to access the actual font string object(s). And since those messages are animated -- the "bounce in" effect -- you'd also need to hook into the code doing the animation, and have it animate the texture in addition to the font string. This is all probably more effort than it's worth, by several orders of magnitude.

[ObbleYeah]

yikes, yes - perhaps i'll just hide the icon!

[ObbleYeah]

Alright then, how about this instead.

I work up some simple script today that gives the border round items on the character frame colour based on their rarity (a la oGlow or Fizzle), and have this:

local SkinButtons = CreateFrame("Frame", nil, UIParent)
    SkinButtons:RegisterEvent('VARIABLES_LOADED')
    SkinButtons:RegisterEvent("ADDON_LOADED")
    SkinButtons:RegisterEvent('PLAYER_ENTERING_WORLD')
    SkinButtons:RegisterEvent('UNIT_INVENTORY_CHANGED')
 
    -- Border colouring for items on the character pane
    local function ColourBorders(slotID, self)
        local quality = GetInventoryItemQuality("player", slotID)
        if quality then
                local r, g, b, _ = GetItemQualityColor(quality)
                self:SetBeautyBorderColor(r, g, b)
            else
                self:SetBeautyBorderColor(103/255, 103/255, 103/255)
        end
    end
 
    SkinButtons:SetScript("OnEvent", function(self, event, AddOn)
        
        for slotId, TheSlotButtons in pairs ({
            -- durable
            CharacterHeadSlot,
            CharacterShoulderSlot,
            CharacterChestSlot,
            CharacterWristSlot,
            CharacterMainHandSlot,
            CharacterSecondaryHandSlot,
            CharacterHandsSlot,
            CharacterWaistSlot,
            CharacterLegsSlot,
            CharacterFeetSlot,
            -- non durable
            CharacterNeckSlot,
            CharacterBackSlot,
            CharacterShirtSlot,
            CharacterTabardSlot,
            CharacterFinger0Slot,
            CharacterFinger1Slot,
            CharacterTrinket0Slot,
            CharacterTrinket1Slot,
        }) do
                TheSlotButtons:CreateBeautyBorder(21)
                TheSlotButtons:SetBeautyBorderPadding(3, 3, 3, 3, 3, 3, 3, 3)
                TheSlotButtons:SetBeautyBorderDraw("OVERLAY")
                ColourBorders(slotId, TheSlotButtons)
            end
        end 
 
    end)

Now clearly these are being coloured in the wrong order, since those non-epic colours correspond to my legendary cloak and common tshirt... but are being placed elsewhere. And the trinket gets a fallback colouring instead. What on earth is going on here?

[semlar]

Firstly, you shouldn't use "pairs" when the order matters, use "ipairs".

That's not the problem here though. You have the slots in the wrong order, but rather than reordering them you should be able to just call TheSlotButtons:GetID() to get the slot id for the frame (this is lazy advice, it's more efficient to put them in the proper order).

I would move that table outside of the function though, because right now you're creating a table every time the event fires and that's going to create a lot of garbage.

[ObbleYeah]

Ah! Thanks, for some reason didn't think that the actual order of the table would matter. Found the right order via oGlow and pulled it out into a separate table now.

It appears that it was the tabard that was using the fallback colour when it should be epic. Is CharacterTabardSlot the wrong call to use?

[semlar]

I would either do something like this..

local CharacterSlots = {
    -- durable
    CharacterHeadSlot = CharacterHeadSlot:GetID(),
    CharacterShoulderSlot = CharacterShoulderSlot:GetID(),
    CharacterChestSlot = CharacterChestSlot:GetID(),
    CharacterWristSlot = CharacterWristSlot:GetID(),
    CharacterMainHandSlot = CharacterMainHandSlot:GetID(),
    CharacterSecondaryHandSlot = CharacterSecondaryHandSlot:GetID(),
    CharacterHandsSlot = CharacterHandsSlot:GetID(),
    CharacterWaistSlot = CharacterWaistSlot:GetID(),
    CharacterLegsSlot = CharacterLegsSlot:GetID(),
    CharacterFeetSlot = CharacterFeetSlot:GetID()
    -- non durable
    CharacterNeckSlot = CharacterNeckSlot:GetID(),
    CharacterBackSlot = CharacterBackSlot:GetID(),
    CharacterShirtSlot = CharacterShirtSlot:GetID(),
    CharacterTabardSlot = CharacterTabardSlot:GetID(),
    CharacterFinger0Slot = CharacterFinger0Slot:GetID(),
    CharacterFinger1Slot = CharacterFinger1Slot:GetID(),
    CharacterTrinket0Slot = CharacterTrinket0Slot:GetID(),
    CharacterTrinket1Slot = CharacterTrinket1Slot:GetID(),
}
 
-- Border colouring for items on the character pane
local function ColourBorders(button, slot)
    local quality = GetInventoryItemQuality('player', slot)
    if quality then
        local r, g, b = GetItemQualityColor(quality)
        button:SetBeautyBorderColor(r, g, b)
    else
        button:SetBeautyBorderColor(103/255, 103/255, 103/255)
    end
end
 
local SkinButtons = CreateFrame('Frame')
SkinButtons:RegisterEvent('VARIABLES_LOADED')
SkinButtons:RegisterEvent('ADDON_LOADED')
SkinButtons:RegisterEvent('PLAYER_ENTERING_WORLD')
SkinButtons:RegisterEvent('UNIT_INVENTORY_CHANGED')
 
SkinButtons:SetScript('OnEvent', function(self, event, ...)
    for button, slot in pairs(CharacterSlots) do
        button:CreateBeautyBorder(21)
        button:SetBeautyBorderPadding(3, 3, 3, 3, 3, 3, 3, 3)
        button:SetBeautyBorderDraw('OVERLAY')
        ColourBorders(button, slot)
    end
end)

Or just pull the slotID out of the frame using button:GetID() in the "ColourBorders" function.

[ObbleYeah]

Alright, I'm tightening up the last few things for this - so I'll probably be posting a couple of my standing issues in the next couple of days for stuff I've yet to fix even after a lot of fiddling.

I modified the chat bubbles a while back to display names over the top (based on code from BubbleBobble) and it's all more or less working, but I have two things i'd like to fix.

Firstly, there's an issue where new bubbles that pop up will still display names from older messages. You can sort of see what I mean here. Do I need to introduce some kind of method that wipes information after the function is activated each time or something?

Secondly, how do I hide realm names? There's a small function I wrote (or more likely, "procured" then bludgeoned) but it doesn't seem to be working - though there's no errors to speak of.

Here's the code:

-- events table
    local events = {
        CHAT_MSG_SAY = "chatBubbles",
        CHAT_MSG_YELL = "chatBubbles",
        CHAT_MSG_PARTY = "chatBubblesParty",
        CHAT_MSG_PARTY_LEADER = "chatBubblesParty",
        CHAT_MSG_MONSTER_SAY = "chatBubbles",
        CHAT_MSG_MONSTER_YELL = "chatBubbles",
        CHAT_MSG_MONSTER_PARTY = "chatBubblesParty",
    }
    
    -- hides realm names
    local function hideRealmName(self, event, msg, sender, ...)
        local realmName = string.gsub(GetRealmName(), " ", "")
        if msg:find("-" .. realmName) then
            return false, gsub(msg, "%-"..realmName, ""), sender, ...
        end
    end
 
    local function styleBubble(frame)
        for i = 1, frame:GetNumRegions() do
            local region = select(i, frame:GetRegions())
            local pn = {region:GetPoint()} 
            if (region:GetObjectType()=="Texture") then
                region:SetDrawLayer("OVERLAY")
                region:ClearAllPoints()
                -- fix the gap between bubble and tail texture by nudging up the yoffset
                region:SetPoint(pn[1],pn[2],pn[3],pn[4], pn[5]+2)
            elseif (region:GetObjectType()=="FontString") then
                frame.textstring = region
            end
        end
            
        frame:SetBackdrop({
            bgFile = "Interface\\Tooltips\\UI-Tooltip-Background",
            edgeFile = nil,
            edgeSize = 0,
            insets = {
                left = 5, right = 5, top = 5, bottom = 5;
                }
        })
        frame:SetBackdropColor(0, 0, 0, 0.8)
        frame:CreateBeautyBorder(22)
        frame:SetBeautyBorderColor(r, g, b)
        frame:SetScale(.95)
            
        frame.sender = frame:CreateFontString()
        frame.sender:SetPoint("BOTTOMRIGHT", frame, "TOPRIGHT", -7, 2)
        frame.sender:SetFont(STANDARD_TEXT_FONT, 13)
        frame.sender:SetShadowOffset(1.7,-1.2)
        frame.sender:SetShadowColor(0,0,0)
        frame.sender:SetJustifyH("RIGHT")
    end
        
    local function UpdateNameBubble(frame, guid, name)
        local class
        if (guid~= nil) and (guid~="") then
            _, class, _, _, _, _ = GetPlayerInfoByGUID(guid)
        end
            
        if name then
            local color = RAID_CLASS_COLORS[class] or { r = 1, g = .8, b = 0 }
            frame.sender:SetText(("|cFF%2x%2x%2x%s|r"):format(color.r*255, color.g*255, color.b*255, name))
            if (frame:GetWidth() < frame.sender:GetWidth()) then
                frame.textstring:SetWidth(frame.sender:GetWidth() + 10)
            end
        end
    end
 
    local function isChatBubble(frame)
        if frame:GetName() then return end
        if not frame:GetRegions() then return end
        return frame:GetRegions():GetTexture()==("Interface\\Tooltips\\ChatBubble-Background")
    end
    
    local bubbleHook = CreateFrame("Frame")
    
    for event, cvar in pairs(events) do
        bubbleHook:RegisterEvent(event)
    end
 
    bubbleHook:SetScript("OnEvent", function(self, event, msg, sender, _, _, _, _, _, _, _, _, _, guid)
        if GetCVarBool(events[event]) then
            local last = 0
            local numKids = 0
            hideRealmName(self, event, msg, sender)
            bubbleHook:SetScript("OnUpdate", function(self, elapsed)
                last = last + elapsed
                if last > .1 then
                    last = 0
                    local newNumKids = WorldFrame:GetNumChildren()
                    if newNumKids ~= numKids then
                        for i=numKids + 1, newNumKids do
                            local frame = select(i, WorldFrame:GetChildren())
 
                            if isChatBubble(frame) then
                                styleBubble(frame)
                                UpdateNameBubble(frame, guid, sender)
                            end
                        end
                        numKids = newNumKids
                    end
                end
            end)
        end
    end)

[Phanx]

Well, your realm name hiding function doesn't work because it just returns some values, and you're not actually doing anything with those values. You're not even calling the function in the same function that sets the sender text. Also, since there's only one place you need to call it, you may as well save yourself the overhead of creating and calling a function, and just include the code there directly:

local function UpdateNameBubble(frame, guid, name)		
	if not name then return end -- check this first since everything depends on it

	local class, _ -- global _ is bad, mmkay
	if (guid) and (guid~="") then -- no need to explicitly check against nil
		_, class = GetPlayerInfoByGUID(guid) -- no need to assign all the values to _, just stop after the last one you want
	end

	local color = (CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS)[class] or { r = 1, g = .8, b = 0 } -- supporting custom class colors is trivial, so just do it

	-- just strip the realm name directly here:
	name = string.match(name, "^([^%-]+)")

	frame.sender:SetText(("|cFF%2x%2x%2x%s|r"):format(color.r*255, color.g*255, color.b*255, name))

	local senderWidth = frame.sender:GetStringWidth() -- use a variable to avoid repeated function calls
	if (frame:GetWidth() < senderWidth) then
		 frame.textstring:SetWidth(senderWidth + 10)
	end
end

I didn't look through the rest of the code for leaked globals etc. but you may want to do that yourself, since leaking globals with generic names like _ is the #1 way to guarantee that your addon causes UI taint.

Also, recreating your OnUpdate script inside every run of the OnUpdate script is really inefficient. Set the OnUpdate script once -- not inside the OnEvent script -- and then just use Hide() and Show() on the frame to stop/start the OnUpdate script running as needed.

[ObbleYeah]

Yikes, I hadn't realised just how off-piste I was with that code. I'll see if it clears up issues with the wrong names being displayed too. Could leaked globals also be the cause of an occasional c stack overflow error? Get one now and then and have to reload the ui.


Thanks, as ever!