Quantcast
C_PetJournal changes - WoWInterface
 
Thread Tools Display Modes
05-13-16, 07:25 AM   #1
Gello
A Firelord
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 492
C_PetJournal changes

Some C_PetJournal functions were renamed:

IsFlagFiltered -> IsFilterChecked
IsPetSourceFiltered -> IsPetSourceChecked
IsPetTypeFiltered -> IsPetTypeChecked
SetFlagFilter -> SetFilterChecked
SetPetSourceFilter -> SetPetSourceChecked
(SetPetTypeFilter was not renamed which I believe is an oversight)

The filter flags were renamed too:

LE_PET_JOURNAL_FLAG_COLLECTED -> LE_PET_JOURNAL_FILTER_COLLECTED
LE_PET_JOURNAL_FLAG_NOT_COLLECTED -> LE_PET_JOURNAL_FILTER_NOT_COLLECTED

The functions to clear and add all filters were combined into a single function that takes true/false to set/clear all filters:

ClearAllPetSourcesFilter - Removed
AddAllPetSourcesFilter - Removed
SetAllPetSourcesChecked - New

ClearAllPetTypesFilter - Removed
AddAllPetTypesFilter - Removed
SetAllPetTypesChecked - New

A few new functions:

PetNeedsFanfare - New
GetNumPetsNeedingFanfare - New
ClearFanfare - New
GetNumMaxPets - New (Returns 1000; likely 1500 after player has used a Pocket Pet Portal)

Pets can be wrapped in the journal much like items can be wrapped in container slots. This is referred to as "Fanfare" in the default code. A player can unwrap a pet with "Unwrap" in the pet's right-click menu, by attempting to summon the pet, or by clicking its model. Some context for its functions:

-- This is only used in MainMenuBarMicroButtons.lua to alert when a pet needs unwrapped
numPetsNeedingFanfare = C_PetJournal.GetNumPetsNeedingFanfare()

-- This is used throughout Blizzard_PetCollection.lua to show the wrapped icon instead of the pet icon
needsFanfare = C_PetJournal.PetNeedsFanfare(petID)

-- This is called during PetJournal_UnwrapPet in Blizzard_PetCollection.lua after a delay when unwrapping a pet:
C_PetJournal.ClearFanfare(petID)

As yet I'm not sure what causes them to be wrapped. The ones we ordinarily get in the mail when we create a character were wrapped and already in the journal when creating a beta template character.

Some other observations:
  • There appear to be no changes to C_PetBattles.
  • No new returns for GetPetInfoByIndex/PetID/SpeciesID. Pet BreedIDs are still not exposed.
  • The GUID of petIDs remains unchanged from WoD: BattlePet-0-000000000000.
  • There still appears to be no way to empty a battle pet slot like we could in MoP.
 
06-18-16, 12:32 PM   #2
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view addons
Join Date: Nov 2006
Posts: 19
Did LE_PET_JOURNAL_FLAG_FAVORITES get changed?

Also, any idea what changed with C_MountJournal.GetMountInfo()?
 
06-18-16, 12:56 PM   #3
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 930
Originally Posted by Kharthus View Post
Also, any idea what changed with C_MountJournal.GetMountInfo()?

Changed to C_MountJournal.GetMountInfoByID

https://github.com/Gethe/wow-ui-sour...e4be1c72ddR172
https://www.diffchecker.com/oxjtkczh (R1003)

Not sure if someone already had posted about it, Gello probably already knew about it
http://www.wowinterface.com/forums/s...3248&page=4#63
 
06-18-16, 06:26 PM   #4
Gello
A Firelord
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 492
Originally Posted by Kharthus View Post
Did LE_PET_JOURNAL_FLAG_FAVORITES get changed?
LE_PET_JOURNAL_FLAG_FAVORITES was removed during WoD. The default journal no longer has a favorite filter.
 
06-19-16, 09:01 AM   #5
Kharthus
A Deviate Faerie Dragon
AddOn Author - Click to view addons
Join Date: Nov 2006
Posts: 19
I updated most of the entries on wow.gamepedia.com with the mount and pet journal changes.

I also included SetPetTypeFilter->SetPetTypeChecked for now. I'll revert it if they decide to leave that one as an outlier.
 
 

WoWInterface » Site Forums » Archived Beta Forums » Legion Beta archived threads » C_PetJournal changes

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off