Journal

[Kendian]

Is anyone else getting a lua error when they mouse over loot in dungeon journal? I get it with any or no addons enabled.

Message: ...zzard_EncounterJournal\Blizzard_EncounterJournal.lua:867: attempt to call method 'IsEquippedItem' (a nil value)
Time: 01/15/12 17:12:47
Count: 392
Stack: ...zzard_EncounterJournal\Blizzard_EncounterJournal.lua:867: in function <...zzard_EncounterJournal\Blizzard_EncounterJournal.lua:864>

Locals: self = EncounterJournalEncounterFrameInfoLootScrollFrameButton6 {
0 = <userdata>
showingTooltip = true
bossTexture = <unnamed> {
}
slot = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Slot {
}
encounterID = 285
bosslessTexture = <unnamed> {
}
boss = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Boss {
}
name = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Name {
}
link = "[Ward of Incantations]"
index = 10
itemID = 72809
icon = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Icon {
}
armorType = EncounterJournalEncounterFrameInfoLootScrollFrameButton6ArmorClass {
}
}
(*temporary) = nil
(*temporary) = EncounterJournalEncounterFrameInfoLootScrollFrameButton6 {
0 = <userdata>
showingTooltip = true
bossTexture = <unnamed> {
}
slot = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Slot {
}
encounterID = 285
bosslessTexture = <unnamed> {
}
boss = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Boss {
}
name = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Name {
}
link = "[Ward of Incantations]"
index = 10
itemID = 72809
icon = EncounterJournalEncounterFrameInfoLootScrollFrameButton6Icon {
}
armorType = EncounterJournalEncounterFrameInfoLootScrollFrameButton6ArmorClass {
}
}
(*temporary) = "attempt to call method 'IsEquippedItem' (a nil value)"

[Seerah]

Do you get this error with all addons disabled? I do not get an error, and I was just looking at loot in the EJ last night.

[Vlad]

Seems you have an addon that changes IsEquippedItem, more exactly sets that API to nil, so it does not exist.

http://wowprogramming.com/docs/api/IsEquippedItem

You can if you have, search all your .lua files in Interface\Addons and see what addons use that API, by searching for "IsEquippedItem" -maybe you find something saying "IsEquippedItem = nil" or similar.

[Ketho]

Originally Posted by Kendian Message: ...zzard_EncounterJournal\Blizzard_EncounterJournal.lua:867: attempt to call method 'IsEquippedItem' (a nil value)

I didn't know there also was a widget/method version of IsEquippedItem

[Seerah]

http://wowprogramming.com/docs/widge...IsEquippedItem

For compare tips, I presume.

[Xrystal]

Sounds like it might be linked to this section of the EncounterJournal.lua file:

function EncounterJournal_Loot_OnUpdate(self)

    if GameTooltip:IsOwned(self) then

        if IsModifiedClick("COMPAREITEMS") or

                 (GetCVarBool("alwaysCompareItems") and not self:IsEquippedItem()) then

            GameTooltip_ShowCompareItem();

        else

            ShoppingTooltip1:Hide();

            ShoppingTooltip2:Hide();

            ShoppingTooltip3:Hide();

        end

 

        if IsModifiedClick("DRESSUP") then

            ShowInspectCursor();

        else

            ResetCursor();

        end

    end

end

[Kendian]

Yep, checked, double checked, no addons. Even removed interface/wtf so it would repopulate, still error. Ran repair, did a fresh install, it's driving me up a frakking wall~

[Dridzt]

Sounds like a Blizzard bug?

Going by Xrystal's code snippet they're trying to call IsEquippedItem() as a method of 'self' whereas the function signature is IsEquippedItem(item).

Only thing you can do is disable the game option to always compare items.

If it is indeed verified as a Blizzard bug, report it on the official forums and for the meantime make a request at the authors of BlizzBugsSuck to include a fix for it.

[Dridzt]

I can't reproduce it and the code Xrystal posted should never run (the relevant script handler is commented out in the xml)

So all I can suggest is to delete the Blizzard_* addon folders and let the game recreate them next time you start.

Also if you're playing on Windows 7 or Vista make sure you check the virtualized folders as well if you let the game install to the default location.

Edit: Making a mini addon out of this should fix it (although like I said the game client should never run that function anyway)

local eventframe=CreateFrame("Frame")
eventframe:SetScript("OnEvent", 
function(self,event,...) 
	return self[event] and self[event](...)
end)
eventframe:RegisterEvent("ADDON_LOADED")
function eventframe.ADDON_LOADED(...)
	if ... == "Blizzard_EncounterJournal" then
		_G.EncounterJournal_Loot_OnUpdate=function(...) 
				local button = ...
				if GameTooltip:IsOwned(button) then
					if IsModifiedClick("COMPAREITEMS") or
							 (GetCVarBool("alwaysCompareItems") and not IsEquippedItem(button.itemID)) then
						GameTooltip_ShowCompareItem();
					else
						ShoppingTooltip1:Hide();
						ShoppingTooltip2:Hide();
						ShoppingTooltip3:Hide();
					end
			
					if IsModifiedClick("DRESSUP") then
						ShowInspectCursor();
					else
						ResetCursor();
					end
				end
			end
		eventframe.UnregisterEvent("ADDON_LOADED")
		eventframe.ADDON_LOADED = nil
	end
end

Drycoded!

[Saiket]

It's a bug in Blizzard's code; self in that snipped refers to an EncounterItemTemplate button instead of GameTooltip like Blizzard probably meant to use.

The error only occurs if you have the "alwaysCompareItems" CVar enabled (and aren't holding shift), so you could disable that setting for now to avoid the problem. I don't think there's any checkbox in the default UI to toggle it, so you'll have to run this slash command instead:

/console alwaysCompareItems 0

Once that's disabled, you won't see item comparison tooltips unless you hold shift while mousing over items.