Adding new things to global functions?

[unlimit]

local thelist = {};
thelist["am_i"] = true;
thelist["in_the"] = true;
thelist["list"] = true;
 
function IntheList(name)
    return thelist[name];
end

Let's say I have two addons. I would like to, from my addon, be able to add my words into "thelist", but it's a local variable. However, IntheList(name) is a global function, is there anyway override the global function from MY addon and make it return "thelist[name] AND theotherlist[name];"?, or manually (without editing the original addon) to add my words into thelist?

qts;dfr (question too stupid, didn't finish reading): Is there a way to make IntheList(name) return from anything OTHER than just thelist[name] without editing the original addon?

[Seerah]

Sure. Since it's a global function, you can either completely replace it or hook it.

[unlimit]

Hooking seems to be what I'm after, but I honestly have no idea on how that works. I've tried looking up examples of Hooksecurefunc, but it's like reading Chinese in Spanish to me.

hooksecurefunc("IntheList()", function()
    return theotherlist[name]; end
);

doesn't seem to work.

Interface\AddOns\TrueAui\test.lua:24: hooksecurefunc(): InTheList() is not a function

Stack trace:
-----------
Interface\AddOns\TrueAui\test.lua:24: in main chunk

[Seerah]

Get rid of the parentheses. They're not a part of your function name.

[unlimit]

Yeah, I tried that, but it just ends up throwing out the same error. I definitely know that function is there, but I'm thinking it just hates me. C_C

Interface\AddOns\TrueAui\test.lua:6: hooksecurefunc(): RDXDB.IsProtectedPkg is not a function

Stack trace:
-----------
Interface\AddOns\TrueAui\test.lua:6: in main chunk

HOW DARE YOU GIVE ME THIS ERROR, WOW-CLIENT. YOU. LIE. TO. ME.



File #1

-- Some packages are protected
local protectedPkg = {};
protectedPkg["scripts"] = true;
protectedPkg["default"] = true;
protectedPkg["desktops"] = true;
 
function RDXDB.IsProtectedPkg(name)
    return protectedPkg[name];
end

File #2

local truePkg = {};
truePkg["true_core"] = true;
truePkg["true_unitframes"] = true;
truePkg["true_multiframes"] = true;
 
hooksecurefunc("RDXDB.IsProtectedPkg", function()
    return truePkg[name]; end
);

[Saiket]

Originally Posted by unlimit File #2 local truePkg = {}; truePkg["true_core"] = true; truePkg["true_unitframes"] = true; truePkg["true_multiframes"] = true;   hooksecurefunc("RDXDB.IsProtectedPkg", function()     return truePkg[name]; end );

hooksecurefunc takes either a variable name implicitly located in _G, or a table and a key. You would need to use it like this:

hooksecurefunc(RDXDB, "IsProtectedPkg", function()

Even if you did fix that though, it still wouldn't work since hooks from hooksecurefunc discard your return values and preserve the original ones. You would have to manually (insecurely) hook the function like this:

local RDXDBIsProtectedPkg = RDXDB.IsProtectedPkg;
function RDXDB.IsProtectedPkg(name, ...)
  return RDXDBIsProtectedPkg(name, ...) or mylist[name]
end

An insecure hook is fine in this case since RDX's function is insecure to begin with. I wasn't sure if you wanted to add to or entirely replace returns from the original function, so my example just adds to them.

[unlimit]

Thanks Saiket, and Seerah for helping me through this!

If I may ask, what does the ... signify as a function operator? (I think that's what it's called)

[Saiket]

Originally Posted by unlimit Thanks Saiket, and Seerah for helping me through this! If I may ask, what does the ... signify as a function operator? (I think that's what it's called)

`...` is called a vararg expression. It contains all extra arguments to the function without needing to give them each names. I used it to pass all input to the original function as a safety precaution, since we can't be sure that future versions of RDXDB.IsProtectedPkg won't use more arguments.

[unlimit]

Ah! I see, cool stuff! Thanks for the quick reply!

[SDPhantom]

Originally Posted by Saiket local RDXDBIsProtectedPkg = RDXDB.IsProtectedPkg; function RDXDB.IsProtectedPkg(name, ...)   return RDXDBIsProtectedPkg(name, ...) or mylist[name] end

You may need to be careful, if RDXDBIsProtectedPkg() returns an actual value instead of nil that would represent false, it'll propagate to searching mylist anyway. The best way to do this is check it against nil before deciding which to return. The following will only fall back to mylist when RDXDBIsProtectedPkg() returns nil while preserving data instead of an accidental boolean conversion in some cases.

local RDXDBIsProtectedPkg = RDXDB.IsProtectedPkg;
function RDXDB.IsProtectedPkg(name,...)
    local val=RDXDBIsProtectedPkg(name,...);
    if val~=nil then
        return val;
    else
        return mylist[name];
    end
end