Archaeology race info

myrroddin · 08-30-17, 04:21 PM

I thought I'd save the returns from GetArchaeologyRaceInfo() now that it has changed. Just a little utility to poke at for data later.

But I have a bug in my code which I can't spot. It keeps saying my SV is nil.

Lua Code:

1x ARI73\ARI73-1.0.lua:13: attempt to index global 'ARI73DB' (a nil value)
ARI73\ARI73-1.0.lua:13: in function `?'
ARI73\ARI73-1.0.lua:34: in function <ARI73\ARI73.lua:33>

Here is my ToC file:

Lua Code:

## Interface: 70300
## Title: Archaeology Race Info 7.3
## Notes: Utility to save the new return values of the API
## Author: Paul "Myrroddin" Vandersypen
## Version: 1.0
## SavedVariables: ARI73DB
 
ARI73.lua

and the main addon

Lua Code:

local addonName, addon = ...
 
local f = CreateFrame("Frame")
f:RegisterEvent("ADDON_LOADED")
f:RegisterEvent("PLAYER_ENTERING_WORLD")
 
function addon:PLAYER_ENTERING_WORLD()
    local raceCount = GetNumArchaeologyRaces()
 
    for i = 1, raceCount do
        local raceName, textureID, itemID, numFragsCol, numFragsReq, maxFrags = GetArchaeologyRaceInfo(i)
        local keystoneName = GetItemInfo(itemID)
        ARI73DB[raceName] = ARI73DB[raceName] or {}
 
        ARI73DB[raceName]["raceIndex"] = i or 0
        ARI73DB[raceName]["textureID"] = textureID or 0
        ARI73DB[raceName]["keystoneID"] = itemID or 0
        ARI73DB[raceName]["keystoneName"] = keystoneName or ""
        ARI73DB[raceName]["maxFragments"] = maxFrags or 0
    end
    f:UnregisterEvent("PLAYER_ENTERING_WORLD")
end
 
function addon:ADDON_LOADED(event, name)
    if name ~= addonName then
        return
    end
 
    ARI73DB = ARI73DB or {}
    f:UnregisterEvent("ADDON_LOADED")
end
 
f:SetScript("OnEvent", function(self, event, ...)
    addon[event](self, ...)
end)

Terenna · 08-30-17, 04:34 PM

What happens if you put the function addon:ADDON_LOADED(event, name) above the addon:PLAYER_ENTERING_WORLD() function?

Which event fires first?

If PEW fires first, it is trying to index a non existent table for first time users and is the reason for your error. Therefore that line ARI73DB = ARI73DB or {} in your ADDON_LOADED function needs to happen before you start writing data to it.

myrroddin · 08-30-17, 05:41 PM

Oh, I bet you are correct. I suspect PEW does fire before AL. I'll fix and test.

Alright, I have fixed that issue, but the SV is still nil. However, the error is gone.

Lua Code:

local addonName, addon = ...
 
local f = CreateFrame("Frame")
f:RegisterEvent("ADDON_LOADED")
 
function addon:GetData()
    local raceCount = GetNumArchaeologyRaces()
 
    for i = 1, raceCount do
        local raceName, textureID, itemID, numFragsCol, numFragsReq, maxFrags = GetArchaeologyRaceInfo(i)
        local keystoneName = GetItemInfo(itemID)
        ARI73DB[raceName] = ARI73DB[raceName] or {}
 
        ARI73DB[raceName]["raceIndex"] = i or 0
        ARI73DB[raceName]["textureID"] = textureID or 0
        ARI73DB[raceName]["keystoneID"] = itemID or 0
        ARI73DB[raceName]["keystoneName"] = keystoneName or ""
        ARI73DB[raceName]["maxFragments"] = maxFrags or 0
    end
end
 
function addon:ADDON_LOADED(event, name)
    if name ~= addonName then
        return
    end
 
    ARI73DB = ARI73DB or {}
    addon:GetData()
    f:UnregisterEvent("ADDON_LOADED")
end
 
f:SetScript("OnEvent", function(self, event, ...)
    addon[event](self, ...)
end)

Fizzlemizz · 08-30-17, 05:54 PM

Essentialy when the code runs is when the addon is being loaded so the ADDON_LOADED event is pretty much redundant save for XML frames.

You can check for saved variables in the PLAYER_LOGIN event which only fires once after all addons are loaded and before PEW.

myrroddin · 08-30-17, 06:30 PM

Originally Posted by Fizzlemizz

You can check for saved variables in the PLAYER_LOGIN event which only fires once and after your addon is loaded and before PEW.

I should have refreshed the thread before editing the above! Hang on, I will test with PL instead.

EDIT: success!! Thank you Fizzlemizz!!

If you want to know the data, here is the contents of my saved variables file:

Lua Code:

ARI73DB = {
    ["Nerubian"] = {
        ["raceIndex"] = 14,
        ["keystoneID"] = 64396,
        ["textureID"] = 461835,
        ["keystoneName"] = "Nerubian Obelisk",
        ["maxFragments"] = 0,
    },
    ["Fossil"] = {
        ["raceIndex"] = 16,
        ["keystoneID"] = 0,
        ["textureID"] = 461833,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Highmountain Tauren"] = {
        ["raceIndex"] = 2,
        ["keystoneID"] = 130904,
        ["textureID"] = 1445577,
        ["keystoneName"] = "Highmountain Ritual-Stone",
        ["maxFragments"] = 200,
    },
    ["Ogre"] = {
        ["raceIndex"] = 4,
        ["keystoneID"] = 109584,
        ["textureID"] = 1030618,
        ["keystoneName"] = "Ogre Missive",
        ["maxFragments"] = 250,
    },
    ["Troll"] = {
        ["raceIndex"] = 11,
        ["keystoneID"] = 63128,
        ["textureID"] = 461841,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Pandaren"] = {
        ["raceIndex"] = 8,
        ["keystoneID"] = 79868,
        ["textureID"] = 633002,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Mogu"] = {
        ["raceIndex"] = 7,
        ["keystoneID"] = 79869,
        ["textureID"] = 633000,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Draenei"] = {
        ["raceIndex"] = 17,
        ["keystoneID"] = 64394,
        ["textureID"] = 461829,
        ["keystoneName"] = "Draenei Tome",
        ["maxFragments"] = 0,
    },
    ["Demonic"] = {
        ["raceIndex"] = 1,
        ["keystoneID"] = 130905,
        ["textureID"] = 1445573,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Mantid"] = {
        ["raceIndex"] = 9,
        ["keystoneID"] = 95373,
        ["textureID"] = 839111,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Dwarf"] = {
        ["raceIndex"] = 18,
        ["keystoneID"] = 52843,
        ["textureID"] = 461831,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Tol'vir"] = {
        ["raceIndex"] = 12,
        ["keystoneID"] = 64397,
        ["textureID"] = 461839,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Night Elf"] = {
        ["raceIndex"] = 15,
        ["keystoneID"] = 63127,
        ["textureID"] = 461837,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Highborne"] = {
        ["raceIndex"] = 3,
        ["keystoneID"] = 130903,
        ["textureID"] = 1445575,
        ["keystoneName"] = "Ancient Suramar Scroll",
        ["maxFragments"] = 200,
    },
    ["Orc"] = {
        ["raceIndex"] = 13,
        ["keystoneID"] = 64392,
        ["textureID"] = 462321,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Vrykul"] = {
        ["raceIndex"] = 10,
        ["keystoneID"] = 64395,
        ["textureID"] = 461843,
        ["keystoneName"] = "",
        ["maxFragments"] = 0,
    },
    ["Arakkoa"] = {
        ["raceIndex"] = 6,
        ["keystoneID"] = 109585,
        ["textureID"] = 1030616,
        ["keystoneName"] = "Arakkoa Cipher",
        ["maxFragments"] = 250,
    },
    ["Draenor Clans"] = {
        ["raceIndex"] = 5,
        ["keystoneID"] = 108439,
        ["textureID"] = 1030617,
        ["keystoneName"] = "Draenor Clan Orator Cane",
        ["maxFragments"] = 250,
    },
}

myrroddin · 08-30-17, 07:01 PM

One thing to note: I haven't unlocked all the races' archaeology on my Demon Hunter yet, therefore, your "maxFragments" may vary. It seems to default to nil or 0 if that is the case.