Need help with debugging Cata changes...

[Sythalin]

Seems Blizz finally got around to nixing "this" from their old libraries, which is screwing up my dropdown menus now (they were built off the old templates). So I've been spending the last hour or so trying to figure out how to fix them for "self". I've almost got it, until an option in a dropdown is clicked:

Error:

Message: Interface\FrameXML\UIDropDownMenu.lua:915: attempt to index local 'filterText' (a nil value)
Time: 09/02/10 00:15:31
Count: 2
Stack: Interface\FrameXML\UIDropDownMenu.lua:915: in function `UIDropDownMenu_SetText'
Interface\FrameXML\UIDropDownMenu.lua:506: in function `UIDropDownMenu_Refresh'
Interface\FrameXML\UIDropDownMenu.lua:561: in function `UIDropDownMenu_SetSelectedValue'
Interface\AddOns\CFM\CFM_GUI.lua:1167: in function `CFM_ToBoxClick'
Interface\AddOns\CFM\CFM_GUI.lua:1019: in function `func'
Interface\FrameXML\UIDropDownMenu.lua:636: in function `UIDropDownMenuButton_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals: frame = CFM_PropFrame {
 selectedValue = 0
 0 = <userdata>
}
text = "CENTER"
filterText = nil
(*temporary) = "CFM_PropFrameText"
(*temporary) = nil
(*temporary) = "CFM_PropFrame"
(*temporary) = "attempt to index local 'filterText' (a nil value)"

Code:

--[[ RELATIVEPOINT DATA ]]          
    dm = CreateFrame("Frame", "CFM_ToBox", f, "UIDropDownMenuTemplate")
        dm:SetPoint("LEFT", CFM_ToText, "RIGHT", -10, -2)
        dm:SetScale(.75)
        UIDropDownMenu_SetWidth(dm,105)
        UIDropDownMenu_Initialize(dm, CFM_ToDropInit)
 
function CFM_ToDropInit(self)
    local level = level or 1
    local info = UIDropDownMenu_CreateInfo()
    info.text = "CENTER"
    info.value = 0
    info.func = function(self) CFM_ToBoxClick(self) end    -- LINE 1019
    info.owner = self:GetParent()
    info.checked = nil
    info.icon = nil
    UIDropDownMenu_AddButton(info, level)
end
 
function CFM_ToBoxClick(self)
    UIDropDownMenu_SetSelectedValue(self.owner, self.value)  -- LINE 1167
    if (self.value == 0) then
        activeProfile[selFrame].relativePoint = "CENTER"
    end
    CFM_ApplySettings(selFrame)
end

I've looked for API changes for the drop menus, but haven't seem to find them. The old version still works in live.

[Torhal]

Methinks you need to be more descriptive with your function parameters.

Inside of

function CFM_ToDropInit(self)

...you then define this:

info.func = function(self) CFM_ToBoxClick(self) end

Which "self" is being referenced there? The parameter for CFM_ToDropInit(), or the new one declared for info.func?

You could also forego what you have now with this:

info.func = CFM_ToBoxClick

...which would probably work exactly as you intended with the added benefit of not generating an anonymous function every time CFM_ToDropInit() is called.

[Sythalin]

Originally Posted by Torhal Methinks you need to be more descriptive with your function parameters. Inside of function CFM_ToDropInit(self) ...you then define this: info.func = function(self) CFM_ToBoxClick(self) end Which "self" is being referenced there? The parameter for CFM_ToDropInit(), or the new one declared for info.func?

Hrm, point taken. I'll toy with that tomorrow. Too late and too tired to think clearly at this point. I was just following what I could find on dropdowns at the time.

[Torhal]

Meh. Seems you read my post before I edited it - please re-read

[Sythalin]

Originally Posted by Torhal Meh. Seems you read my post before I edited it - please re-read

I saw it. No worries. Like I said, I'll play with it tomorrow.

[Sythalin]

Still ends in the "filterText = nil" error after trying the suggested and several other changes. Grrr....

Here's the dropdown from the original that needs to be converted from this.

dm = CreateFrame("Frame", "CFM_ToBox", f, "UIDropDownMenuTemplate")
        dm:SetPoint("LEFT", CFM_ToText, "RIGHT", -10, -2)
        dm:SetScale(.75)
        UIDropDownMenu_SetWidth(dm,105)
        UIDropDownMenu_Initialize(dm, CFM_ToDropInit)
 
function CFM_ToDropInit()
    local level = level or 1
    local info = UIDropDownMenu_CreateInfo()
    
    info.text = "CENTER"
    info.value = 0
    info.func = function() CFM_ToBoxClick() end
    info.owner = this:GetParent()
    info.checked = nil
    info.icon = nil
    UIDropDownMenu_AddButton(info, level)
 
    info.text = "TOP"
    info.value = 1 -- and so on....
end
 
function CFM_ToBoxClick()
    UIDropDownMenu_SetSelectedValue(this.owner, this.value)
    if (this.value == 0) then
        activeProfile[selFrame].relativePoint = "CENTER"
    elseif (this.value == 1) then -- and so on....
    end
    CFM_ApplySettings(selFrame)
end

I haven't had issues getting it converted up until the CFM_ToBoxClick call when someone chooses an option. Always ends in the filterText = nil error; I'm guessing something has been added that I can't seem to find.

[Torhal]

It may be something to do with the UIDropDownTemplate, which you honestly don't need to use. For a rather comprehensive tutorial on DropDownMenus, see this thread.

[Sythalin]

Originally Posted by Torhal It may be something to do with the UIDropDownTemplate, which you honestly don't need to use. For a rather comprehensive tutorial on DropDownMenus, see this thread.

Thanks for the link. I was looking for an explanation like this since I started working with dropboxes, finding the "official" guides confusing and bloated. I'll skim it over and post back on it.

[Vrul]

info.owner = this:GetParent()

Your issue is that the this in that code is not the self passed to the initialization function. Use:

info.owner = self

[Sythalin]

Originally Posted by ChaosInc Thanks for the link. I was looking for an explanation like this since I started working with dropboxes, finding the "official" guides confusing and bloated. I'll skim it over and post back on it.

Awesome info. However, it just covers the popup menu and not the original option/button frame (if that makes sense), which I have to go look up in the XML files. It's easier to just use the template to start with for what I want to do. I'll keep the info in mind for later reference (such as LDB mods).

However:

info.func = CFM_ToBoxClick

info.owner = self

The combination of both of these have solved the problem. Thanks guys.

[Tomate]

Thanks for the help in this topic.
It helps me a lot.