Need help with EventHandling

[bennasi]

I am new to addon developpment and am trying to make an addon to play some sounds on some events. I coded this piece of code but only the crit heal and lifesaver work when I delete the rest. Does anyone see mistake(s) I made and help me out?

thnx a lot.

local frame = CreateFrame("FRAME", "FooAddonFrame");
frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");
frame:RegisterEvent("PLAYER_ENTERING_WORLD");
frame:RegisterEvent("PLAYER_ENTERING_BATTLEGROUND");
local guid = UnitGUID("player");
local waar = false;
local function eventHandler(self, event, ...)
if (event == "COMBAT_LOG_EVENT_UNFILTERED") then
 local lol = select(2, ...)
 local guidlol = select(3, ...)
 if guid == guidlol then
 if lol == "SPELL_HEAL" then
     local lol2 = select(15, ...)
     if lol2 == 1 then
     PlaySoundFile("Interface\\AddOns\\WillemSound\\megaheal.wav")
     end
     if waar == true then
      PlaySoundFile("Interface\\AddOns\\WillemSound\\lifesaver.wav");
      waar = false;
     end
 end
 if lol == "SPELL_CAST_START" then
 local leven = UnitHealth("mouseover");
 local maxleven = UnitHealthMax("mouseover");
 local ondervijf = ((maxleven / 100) * 20);
 if leven < ondervijf and leven ~= 0 then
 waar = true;
 end
 end
end
end

if (event == "PLAYER_ENTERING_WORLD") then
PlaySoundFile("Interface\\AddOns\\WillemSound\\outofgum.wav")
end

if (event == "PLAYER_ENTERING_BATTLEGROUND") then
PlaySoundFile("Interface\\AddOns\\WillemSound\\medieval.wav")
end

end
frame:SetScript("OnEvent", eventHandler);

[Taroven]

If you're not getting Lua errors, the natural assumption is that the code you want isn't being fired.

You might want to try a less generic event handler.

local frame = CreateFrame('Frame', 'FrameName', UIParent)
frame:SetScript('OnEvent', function (self,event,...)
local f = self[event]
if f then
f(self,...)
end)
-- Creating a frame returns a table, so you can add stuff onto it as you please. This event handler calls frame.EVENTNAME with a reference to the frame (self) and the events args (...) when an event occurs. Lots easier to work with than a whole bunch of if/then statements, if you ask me.

-- colon = implied 'self'
function frame:COMBAT_LOG_UNFILTERED(timestamp, event, srcguid,srcname,srcflags, destguid,destname,destflags, spellid,spellname)
-- stuff
end

-- alternative syntax #1 - does the exact same thing
function frame.PLAYER_ENTERING_WORLD(self)
-- more stuff
end

-- alternative syntax #2 - again, same
frame.PLAYER_ENTERING_BATTLEGROUND = function (self)
-- yet more stuff
end

-- remember to register your events.

When all else fails, put a print('Hey, it works!') where the code seems not to work. If the message occurs ingame, you know it's at least trying to do something.

[Zwacky]

your local function eventHandler(...) function is just a function and isn't connected with the frame, that has all the events.

Taroven's approach is right.
just do

frame:SetScript('OnEvent', function (self,event,...)

instead of

local function eventHandler(self, event, ...)

and you should be fine

(of course closing the frame:SetScript thing with a end) )

[ravagernl]

Originally Posted by Zwacky your local function eventHandler(...) function is just a function and isn't connected with the frame, that has all the events. Taroven's approach is right. just do frame:SetScript('OnEvent', function (self,event,...) instead of local function eventHandler(self, event, ...) and you should be fine (of course closing the frame:SetScript thing with a end) )

Actually his last line of code sets the event handler correctly.