oUF_Kygo, a few tips wanted

[Phanx]

Originally Posted by Kygo Ran into a problem adding LFDRole. It shows all 4 icons for everyone, not sure what or how do add it "correctly".

The problem is this:

	health.LFDRole = LFDRole

Elements must be "attached" directly to the frame, not the health bar or any other child frame/region. Even if the actual texture object is parented to the health bar, the "LFDRole" key still must be defined on the frame, not the health bar.

Originally Posted by Kygo On a scale 1-10, how difficult would it be to add element files to the code? I.e for Runes, Soul Shards, Holy power and eclipsebar. Or would it just be easier to add code directly to the main file doing the same things?

I'm not really sure what you mean by "add element files" -- all of the elements you listed are supported by oUF, so you just have to create the objects. If you look in the oUF file for each element (holy power and soul shards are part of the class icons element, which also does monk chi; eclipse and runes have their own dedicated elements) you'll find a basic example you can use as a starting point.

[Kygo]

Originally Posted by Phanx The problem is this: health.LFDRole = LFDRole Elements must be "attached" directly to the frame, not the health bar or any other child frame/region. Even if the actual texture object is parented to the health bar, the "LFDRole" key still must be defined on the frame, not the health bar.

Okey, did not know that!

Originally Posted by Phanx I'm not really sure what you mean by "add element files" -- all of the elements you listed are supported by oUF, so you just have to create the objects. If you look in the oUF file for each element (holy power and soul shards are part of the class icons element, which also does monk chi; eclipse and runes have their own dedicated elements) you'll find a basic example you can use as a starting point.

Embed was the word I ment!

Saw in another thread (over a year old tho) about the lack of Burning Ember support nativly in oUF that you could either look on how people did add support for it in their unit frames or pull the default frame from Blizzards unit frames.
How could I embed for instance your BurningEmbers.lua into my code?
Or even write my own statusbars for them.


Did look in the classicons.lua in \oUF\elements, and wrote it into my code, used some parts on how-to from the CPoint section in my code. Holy Power,Chi and Soul Shards works, can't test if Shadow Ord works tho.
And I did just realize it was Burning Embers I ment over Soul Shards (now that I tested the classicons example!)

[Phanx]

Elements that are included in oUF don't need to be duplicated in your layout. If you want to include third-party elements, like my BurningEmbers element, you'd just copy the whole file (in my case, Elements\BurningEmbers.lua) into your addon, and then create your own objects on your frame and hook it up to your frame just like you did for the ClassIcons element. I didn't bother with an example in the comment header, but you can use either bars, like the default Runes element:

https://github.com/haste/oUF/blob/ma...ar.lua#L27-L38

or simple textures, like the default ClassIcons element:

https://github.com/haste/oUF/blob/ma...ns.lua#L18-L30

Either of those examples will work; just rename them, and (in the case of class icons) reduce the number of sub-objects to 4. If your sub-objects are statusbars, the element will set their values to show partial embers. Otherwise, it will just show/hide them for full embers.

There's also oUF Warlock Spec bars, but since it hasn't been updated since 2012, I'm not sure whether it still works:

http://www.wowinterface.com/download...SpecsBars.html

[Kygo]

Originally Posted by Phanx Elements that are included in oUF don't need to be duplicated in your layout. If you want to include third-party elements, like my BurningEmbers element, you'd just copy the whole file (in my case, Elements\BurningEmbers.lua) into your addon, and then create your own objects on your frame and hook it up to your frame just like you did for the ClassIcons element.

Got Burning Embers to work! Did use your BurningEmbers.lua file.


EclipseBar is written and working aswell now.
Also found that "SetReverseFill(1)" is a valid argument!


These two elements loads on classes they should not load on.
Did try to add "and unitClass == "WARLOCK" or unitClass == "PALADIN" or unitClass == "MONK" for the classIcons and "if unit == "player" and unitClass == "DRUID" in the EclipseBar, but with the "unitClass" segments they wont load at all.
Got the latest oUF from https://github.com/haste/oUF

Thought with this (from oUF\elements\eclipsebar, line 95 - 102) I should'nt need a "if class" segment but apperently I do..

	if(not form) then
		local ptt = GetSpecialization()
		if(ptt and ptt == 1) then -- player has balance spec
			showBar = true
		end
	elseif(form == MOONKIN_FORM) then
		showBar = true
	end

	-------------------------------
	--	Shards, Holy Power, Chi	 --
	-------------------------------

	if unit == "player" then
		local ClassIcons = {}
		for index = 1, 5 do
			local Icon = health:CreateTexture(nil, "OVERLAY")
			Icon:SetSize(16, 16)
			Icon:SetPoint("TOPLEFT", frame, "BOTTOMLEFT", index * Icon:GetWidth(), 0, 20)
			Icon:SetTexture("Interface\\AddOns\\oUF_Kygo\\Media\\NCPoint")
			ClassIcons[index] = Icon
			
			
		end
	
		frame.ClassIcons = ClassIcons
	end

	-----------------------------
	-- 		Eclipse Bar		   --
	-----------------------------
	
	if unit == "player" then
	
		local EclipseBar = CreateFrame("Frame", nil, frame)
		EclipseBar:SetPoint("BOTTOM", health)
		EclipseBar:SetSize(140, 10)
		
		local SolarBar = CreateFrame("StatusBar", nil, EclipseBar)
		SolarBar:SetPoint("RIGHT", health, "RIGHT",  0, -22)
		SolarBar:SetStatusBarTexture("Interface\\AddOns\\oUF_Kygo\\Media\\Neal")
		SolarBar:SetStatusBarColor(0, 191, 255)
		SolarBar:SetReverseFill(1)
		SolarBar:SetSize(140, 10)
		
		local LunarBar = CreateFrame("StatusBar", nil, EclipseBar)
		LunarBar:SetPoint("LEFT", health, 0, -22)
		LunarBar:SetSize(140, 10)
		LunarBar:SetStatusBarTexture("Interface\\AddOns\\oUF_Kygo\\Media\\Neal")
		LunarBar:SetStatusBarColor(255, 255, 0)
   
		EclipseBar.LunarBar = LunarBar
		EclipseBar.SolarBar = SolarBar
		frame.EclipseBar = EclipseBar
   
		local spark = SolarBar:CreateTexture(nil, "OVERLAY")
		spark:SetSize(5, 10)
		spark:SetPoint("LEFT", SolarBar)
		spark:SetTexture("Interface\\PlayerFrame\\Direction_Eclipse")
		
		frame.spark = spark
		
		local perEclipse = SolarBar:CreateFontString(nil, "OVERLAY", "GameFontNormal")
		perEclipse:SetPoint("CENTER", EclipseBar, 0, -16)
		perEclipse:SetFont("Interface\\AddOns\\oUF_Kygo\\Media\\neuropol.ttf", 10)
		perEclipse:SetTextColor(1, 1, 1)
		frame:Tag(perEclipse, "[pereclipse]")
		
	end

[Phanx]

Originally Posted by Kygo Did try to add "and unitClass == "WARLOCK" or unitClass == "PALADIN" or unitClass == "MONK" for the classIcons and "if unit == "player" and unitClass == "DRUID" in the EclipseBar, but with the "unitClass" segments they wont load at all.

You need to enclose multiple class checks in parentheses, or it won't work as intended. The way you've written it will only load if you're playing a warlock, since it's the equivalent of this:

if (unit == "player" and unitClass == "WARLOCK") or (unitClass == "PALADIN") or (unitClass == "MONK") then

Writing it this way should fix it:

if unit == "player" and (unitClass == "WARLOCK" or unitClass == "PALADIN" or unitClass == "MONK") then

On a side note, based on the name you gave it, I'm guessing you're defining unitClass inside your Spawn callback for each frame. This means that it will be nil for most frames, since information about other units' classes may not be available yet when the frames are being created, or the unit might not exist at all yet (for example, you can't have a target while logging in). Since the player frame is the only one where you're creating some elements conditionally, you should just define a class variable once for the player unit at the top of your file and refer to that:

local _, playerClass = UnitClass("player")

[Kygo]

Originally Posted by Phanx You need to enclose multiple class checks in parentheses, or it won't work as intended.

Now I know that aswell!

Did split the four classes up into their own "if" statements so I could set diffrent settings for each of them.

[Phanx]

Originally Posted by Kygo Did split the four classes up into their own "if" statements so I could set diffrent settings for each of them.

Most likely 90% of that code is the same for all classes, so you should avoid duplication, and just add sub-conditions inside for the few things you want to change:

if player and (one of these classes) then
     -- basic stuff

     if warlock then
          -- warlock stuff
     elseif monk then
          -- monk stuff
     elseif paladin then
          -- paladin stuff
     end

     -- more basic stuff
end

[Phanx]

Finally got around to testing the aura bars and fixing them up today.

https://gist.github.com/Phanx/2f6904b6c6a568fa6630

[Kygo]

Originally Posted by Phanx Most likely 90% of that code is the same for all classes, so you should avoid duplication, and just add sub-conditions inside for the few things you want to change: if player and (one of these classes) then -- basic stuff if warlock then -- warlock stuff elseif monk then -- monk stuff elseif paladin then -- paladin stuff end -- more basic stuff end

That is pretty much how I did it Currently have 1 overflow line of code in each of the classes, gonna fix it up later on today

Originally Posted by Phanx Finally got around to testing the aura bars and fixing them up today. *Link removed, see Phanx post for it*

Lovely! Gonna check them out asap!

[Kygo]

Awesome work Phanx! Works as a charm

Something I'm wondering about, how would I go around to fetch time remaning and aura name for two fontstrings?
Did some google-ing, could'nt find any real answer on how to fetch these strings

[Phanx]

Originally Posted by Kygo ... how would I go around to fetch time remaning and aura name for two fontstrings? Did some google-ing, could'nt find any real answer on how to fetch these strings

You'd get them from UnitAura. Assuming you wanted to show that info on the bars, you'd want to create the font strings in the PostCreateIcon function, something like:

	local time = bar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
	time:SetPoint("RIGHT", -4, 0)
	bar.time = time

	local name = bar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
	name:SetPoint("LEFT", 4, 0)
	name:SetPoint("RIGHT", time, "LEFT", -2, 0)
	bar.name = name

Then in the PostUpdateAura function, use the values you're already getting from UnitAura. Set the name font string to display the name in the same place, and for auras with no duration, make sure you clear the time text. Then, update the time text in the OnUpdate function; it'll have a lot of digits after the decimal point, so you'll want to use SetFormattedText to restrict it to the number of decimal values you actually want to show.

[Kygo]

Originally Posted by Phanx You'd get them from UnitAura. Assuming you wanted to show that info on the bars, you'd want to create the font strings in the PostCreateIcon function, ..

Added.
Did react to something (maybe it's supposed to happen?) when i wrote this
(Using Notepad++ with language set to LUA)

local time = bar:CreateFontString..
time:SetPoint..
time:SetTextcolor..
bar.time = time

Originally Posted by Phanx Then in the PostUpdateAura function, use the values you're already getting from UnitAura. Set the name font string to display the name in the same place.

Are you refering to "local function auras_PostUpdateIcon.."? If you're not, then I have missed that one.

Originally Posted by Phanx ..use SetFormattedText ..

Alright. So something like this: "time:SetFormattedText(m:s)" ? (Havent gotten this far yet, still trying to figure half of this out )

[Phanx]

Originally Posted by Kygo Did react to something (maybe it's supposed to happen?) when i wrote this (Using Notepad++ with language set to LUA)

There is a global "time" function in Lua. Since you're not using it anywhere in your code, it doesn't matter, but if you prefer your editor not highlight it as a built-in global, just use another name.

Originally Posted by Kygo Are you refering to "local function auras_PostUpdateIcon.."?

Yes.

Originally Posted by Kygo So something like this: "time:SetFormattedText(m:s)" ?

fontstring:SetFormattedText(...) is the same as (but faster than) doing fontstring:SetText(string.format(...)) so just refer to the documentation for string.format to see what arguments you need to provide:

http://wowpedia.org/API_format
https://www.gnu.org/software/libc/ma...nt-Conversions

Or just look at other addons that display formatted time strings:

https://github.com/haste/oUF/blob/ma...stbar.lua#L371

[Kygo]

Originally Posted by Phanx Finally got around to testing the aura bars and fixing them up today. https://gist.github.com/Phanx/2f6904b6c6a568fa6630

Decided to fix this addon today.
Did notice that aurabars dosen't work properly anymore (did try to figure it out on my own, changed some values here and there that I thought would affect it, only broke it..).
The names and the bars show up as they should, but only on the player frame. Time shows up aswell but no countdown, just a static number.

Whole code that im using atm: http://pastebin.com/CFmayDw8
Aurabars code starts at line 12-93 and then 379-401

Merry christmas in after hand and happy new years!

[Kygo]

Found a workaround for the aurabars not showing up on the target.
Did swap out

local ok = canApplyAura

to which works at least for now.

local ok = duration and duration > 0 and duration < 330

Something I can't wrap my head around is the fontstring format deal. Been trying various of lines.
The code I've been fiddling around with the most is

bar.timer:SetFormattedText("%.1f", duration)

and

bar.timer:SetFormattedText("%.1f", timeLeft)

See attachment to get a look on how it looks currently (it's just a static duration text)

Phanx gave me a couple of links to examples, but still having a hard time wrapping my head around it.

The error the above SetFormatted... code gives me. And if I swap "bar.timer" to "timer.bar" it gives the same error except it attempts to index field "bar".

3x oUF_Kygo\Frames.lua:53: attempt to index field 'timer' (a nil value)
oUF_Kygo\Frames.lua:53: in function 'PostCreateIcon'
oUF\elements\aura.lua:130: in function <oUF\elements\aura.lua:83>
oUF\elements\aura.lua:159: in function <oUF\elements\aura.lua:141>
oUF\elements\aura.lua:293: in function <oUF\elements\aura.lua:287>
oUF\elements\aura.lua:389: in function <oUF\elements\aura.lua:314>
oUF\elements\aura.lua:430: in function 'func'
oUF\ouf-1.6.8.lua:158: in function <oUF\ouf.lua:149>
(tail call): ?

[Phanx]

Originally Posted by Kygo Did notice that aurabars dosen't work properly anymore (did try to figure it out on my own, changed some values here and there that I thought would affect it, only broke it..)

The original code is working fine for me; I'm not sure why it wouldn't work for you, as nothing about the UnitAura API has changed. I went ahead and added name and time text, and some coloring, and a few other minor improvements, and added some explanatory comments:

https://gist.github.com/Phanx/2f6904b6c6a568fa6630

[Kygo]

Originally Posted by Phanx The original code is working fine for me; I'm not sure why it wouldn't work for you, as nothing about the UnitAura API has changed. I went ahead and added name and time text, and some coloring, and a few other minor improvements, and added some explanatory comments: https://gist.github.com/Phanx/2f6904b6c6a568fa6630

I think it was me that broke it
The new code works amazingly And cheers for the comments, made it a bit easier to understand what each thing does

[Kygo]

Could I put my own "custom" tags and other variables (such as texture paths, font paths and text color based on class) into a separate file?
Want to reduce the clutter and clean up the code a bit for my own sanity.
Trying to fiddle with it myself, but not really sure how to call for instance a texture path from "Settings.lua" to "Frames.lua"... Did look through a couple of oUF layouts I knew had a separate file for settings but it didn't really clear things up.

What I've got so far with "Settings.lua"

local addon, ns = ...
 
 
    Textures = {
        BTexture = [[Interface\\AddOns\\oUF_Kygo\\Media\\normTex2.tga]]
        bgFile = [[Interface\\AddOns\\oUF_Kygo\\Media\\backdrop.tga]]
        edgeFile = [[bgFile = Interface\\AddOns\\oUF_Kygo\\Media\\backdrop_edge.tga]]
        Icon = [[Interface\\AddOns\\oUF_Kygo\\Media\\Neal_border.blp]] --ClassIcons (Soul Shards, Holy power etc)
        CPoint = [[Interface\\AddOns\\oUF_Kygo\\Media\\NCPoint.blp]]
}
    
    ClassPowerText = {
        Priest = {26/255, 160/255, 255/255} --Mana
        Shaman = {26/255, 160/255, 255/255} -- Mana
        Warlock = {26/255, 160/255, 255/255} -- Mana
        Paladin = {26/255, 160/255, 255/255} -- Mana
        MonkMistweaver = {26/255, 160/255, 255/255} --How to check if monk is MW or not status: Unknown atm 
        Mage = {26/255, 160/255, 255/255} -- Mana
        DruidResto/Balance = {26/255, 160/255, 255/255} -- Mana
        Warrior = {255/255, 26/255, 48/255} -- Rage
        DruidGuardian = {255/255, 26/255, 48/255} --Rage
        Hunter = {255/255, 128/255, 64/255} -- Focus
        Rogue = {255/255, 225/255, 26/255} -- Energy
        DruidFeral = {255/255, 225/255, 26/255} -- Energy
        DeathKnight = {0.00, 0.82, 1.00} -- Runic Power
}
 
    Tags = {
    oUF.Tags.Events["shorthp"] = "UNIT_HEALTH"
    oUF.Tags.Methods["shorthp"] = function(unit)
        if not UnitIsDeadOrGhost(unit) then
            local hp = UnitHealth(unit)
            return AbbreviateLargeNumbers(hp)
        end
    end
 
    oUF.Tags.Events["shortpp"] = "UNIT_POWER"
    oUF.Tags.Methods["shortpp"] = function(unit)
        if not UnitIsDeadOrGhost(unit) then
            local pp = UnitPower(unit)
            return AbbreviateLargeNumbers(pp)
        end
    end
 
    oUF.Tags.Events["shortname"] = "UNIT_NAME"
    oUF.Tags.Methods["shortname"] = function(unit)
        local name = UnitName(unit)
        return string.sub(UnitName(unit), 1, 20)
    end
 
    oUF.Tags.Events["readycheckicon"] = "DoReadyCheck"
    oUF.Tags.SharedEvents["IsInGroup"] = true
    oUF.Tags.Methods["readycheckicon"] = function(unit)
        if unit == "player" and IsInGroup() then
            return [[|TInterface\RAIDFRAME\ReadyCheck-Ready|t]]
        end
    end
 
    oUF.Tags.Events["rsicon"] = "PLAYER_UPDATE_RESTING"
    oUF.Tags.SharedEvents["PLAYER_UPDATE_RESTING"] = true
    oUF.Tags.Methods["rsicon"] = function(unit)
        if unit == "player" and IsResting() then
            return [[|TInterface\CharacterFrame\UI-StateIcon:0:0:0:-6:64:64:28:6:6:28|t]]
        end
    end
    oUF.Tags.Events["combaticon"] = "PLAYER_REGEN_DISABLED PLAYER_REGEN_ENABLED"
    oUF.Tags.SharedEvents["PLAYER_REGEN_DISABLED"] = true
    oUF.Tags.SharedEvents["PLAYER_REGEN_ENABLED"] = true
    oUF.Tags.Methods["combaticon"] = function(unit)
        if unit == "player" and UnitAffectingCombat("player") then
            return [[|TInterface\CharacterFrame\UI-StateIcon:0:0:0:0:64:64:37:58:5:26|t]]
        end
    end
 
    oUF.Tags.Events["leadericon"] = "GROUP_ROSTER_UPDATE"
    oUF.Tags.SharedEvents["GROUP_ROSTER_UPDATE"] = true
    oUF.Tags.Methods["leadericon"] = function(unit)
        if UnitIsGroupLeader(unit) then
            return [[|TInterface\GroupFrame\UI-Group-LeaderIcon:0|t]]
        elseif UnitInRaid(unit) and UnitIsGroupAssistant(unit) then
            return [[|TInterface\GroupFrame\UI-Group-AssistantIcon:0|t]]
        end
    end
 
    oUF.Tags.Events["mastericon"] = "PARTY_LOOT_METHOD_CHANGED GROUP_ROSTER_UPDATE"
    oUF.Tags.SharedEvents["PARTY_LOOT_METHOD_CHANGED"] = true
    oUF.Tags.SharedEvents["GROUP_ROSTER_UPDATE"] = true
    oUF.Tags.Methods["mastericon"] = function(unit)
        local method, pid, rid = GetLootMethod()
        if method ~= "master" then return end
        local munit
        if pid then
            if pid == 0 then
                munit = "player"
            else
                munit = "party" .. pid
            end
        elseif rid then
            munit = "raid" .. rid
        end
        if munit and UnitIsUnit(munit, unit) then
            return [[|TInterface\GroupFrame\UI-Group-MasterLooter:0:0:0:2|t]]
        end
    end
 
}
 
ns.Settings = Settings

[Ekaterina]

It doesn't look like you are defining the Settings variable you are trying to add to your namespace table anywhere. Also, you've left off the commas on your tables, so this would throw an error that lua was expecting the tables to end after the first entry.

I'm not so sure about the oUF tags - not having coded for oUF myself, but I think you just leave those in the main chunk of the file, or their own tags file if you wish to completely separate them out. You are already adding them to a table by registering them with oUF. Phanx will no doubt correct me if I'm wrong.

Try the edited code below.

local addon, ns = ...
 
 
--[[
      Settings table
      This should contain your textures, fonts and custom colors.
      This can also be used to contain your positioning, whether or not a unit frame is enabled, etc
 
]]
 local Settings = {}
 
    Settings.Textures = {
        BTexture = [[Interface\\AddOns\\oUF_Kygo\\Media\\normTex2.tga]],
        bgFile = [[Interface\\AddOns\\oUF_Kygo\\Media\\backdrop.tga]],
        edgeFile = [[bgFile = Interface\\AddOns\\oUF_Kygo\\Media\\backdrop_edge.tga]],
        Icon = [[Interface\\AddOns\\oUF_Kygo\\Media\\Neal_border.blp]], --ClassIcons (Soul Shards, Holy power etc)
        CPoint = [[Interface\\AddOns\\oUF_Kygo\\Media\\NCPoint.blp]],
}
    
    Settings.ClassPowerText = {
        Priest = {26/255, 160/255, 255/255}, --Mana
        Shaman = {26/255, 160/255, 255/255}, -- Mana
        Warlock = {26/255, 160/255, 255/255}, -- Mana
        Paladin = {26/255, 160/255, 255/255}, -- Mana
        MonkMistweaver = {26/255, 160/255, 255/255}, --How to check if monk is MW or not status: Unknown atm 
        Mage = {26/255, 160/255, 255/255}, -- Mana
        DruidResto/Balance = {26/255, 160/255, 255/255}, -- Mana
        Warrior = {255/255, 26/255, 48/255}, -- Rage
        DruidGuardian = {255/255, 26/255, 48/255}, --Rage
        Hunter = {255/255, 128/255, 64/255}, -- Focus
        Rogue = {255/255, 225/255, 26/255}, -- Energy
        DruidFeral = {255/255, 225/255, 26/255}, -- Energy
        DeathKnight = {0.00, 0.82, 1.00}, -- Runic Power
}
 
 
ns.Settings = Settings
 
-- oUF_Kygo Tags
 
 
oUF.Tags.Events["shorthp"] = "UNIT_HEALTH"
oUF.Tags.Methods["shorthp"] = function(unit)
    if not UnitIsDeadOrGhost(unit) then
         local hp = UnitHealth(unit)
          return AbbreviateLargeNumbers(hp)
      end
end
 
    oUF.Tags.Events["shortpp"] = "UNIT_POWER"
    oUF.Tags.Methods["shortpp"] = function(unit)
        if not UnitIsDeadOrGhost(unit) then
            local pp = UnitPower(unit)
            return AbbreviateLargeNumbers(pp)
        end
    end
 
    oUF.Tags.Events["shortname"] = "UNIT_NAME"
    oUF.Tags.Methods["shortname"] = function(unit)
        local name = UnitName(unit)
        return string.sub(UnitName(unit), 1, 20)
    end
 
    oUF.Tags.Events["readycheckicon"] = "DoReadyCheck"
    oUF.Tags.SharedEvents["IsInGroup"] = true
    oUF.Tags.Methods["readycheckicon"] = function(unit)
        if unit == "player" and IsInGroup() then
            return [[|TInterface\RAIDFRAME\ReadyCheck-Ready|t]]
        end
    end
 
    oUF.Tags.Events["rsicon"] = "PLAYER_UPDATE_RESTING"
    oUF.Tags.SharedEvents["PLAYER_UPDATE_RESTING"] = true
    oUF.Tags.Methods["rsicon"] = function(unit)
        if unit == "player" and IsResting() then
            return [[|TInterface\CharacterFrame\UI-StateIcon:0:0:0:-6:64:64:28:6:6:28|t]]
        end
    end
    oUF.Tags.Events["combaticon"] = "PLAYER_REGEN_DISABLED PLAYER_REGEN_ENABLED"
    oUF.Tags.SharedEvents["PLAYER_REGEN_DISABLED"] = true
    oUF.Tags.SharedEvents["PLAYER_REGEN_ENABLED"] = true
    oUF.Tags.Methods["combaticon"] = function(unit)
        if unit == "player" and UnitAffectingCombat("player") then
            return [[|TInterface\CharacterFrame\UI-StateIcon:0:0:0:0:64:64:37:58:5:26|t]]
        end
    end
 
    oUF.Tags.Events["leadericon"] = "GROUP_ROSTER_UPDATE"
    oUF.Tags.SharedEvents["GROUP_ROSTER_UPDATE"] = true
    oUF.Tags.Methods["leadericon"] = function(unit)
        if UnitIsGroupLeader(unit) then
            return [[|TInterface\GroupFrame\UI-Group-LeaderIcon:0|t]]
        elseif UnitInRaid(unit) and UnitIsGroupAssistant(unit) then
            return [[|TInterface\GroupFrame\UI-Group-AssistantIcon:0|t]]
        end
    end
 
    oUF.Tags.Events["mastericon"] = "PARTY_LOOT_METHOD_CHANGED GROUP_ROSTER_UPDATE"
    oUF.Tags.SharedEvents["PARTY_LOOT_METHOD_CHANGED"] = true
    oUF.Tags.SharedEvents["GROUP_ROSTER_UPDATE"] = true
    oUF.Tags.Methods["mastericon"] = function(unit)
        local method, pid, rid = GetLootMethod()
        if method ~= "master" then return end
        local munit
        if pid then
            if pid == 0 then
                munit = "player"
            else
                munit = "party" .. pid
            end
        elseif rid then
            munit = "raid" .. rid
        end
        if munit and UnitIsUnit(munit, unit) then
            return [[|TInterface\GroupFrame\UI-Group-MasterLooter:0:0:0:2|t]]
        end
    end

[Kygo]

Did add the "," to every line, did also remove the "/" from "DruidResto/Balance" since it was giving me a error !
Did remove the tags from the Settings file and did add them back into the main file for now

Been fiddling a bit more now with how to call the different table contents (such as texture paths) into the main file, so far no luck.
Got "local Settings = ns.Settings" at the top the main file together with "local addon, ns = ..."
and in the Settings file I got the "local addon, ns = ..." and "local Settings = {}" at the top and on the bottom I have "ns.Settings = Settings".