Exp bar color

Aprikot · 06-03-11, 01:12 AM

Hello, I'm looking for a little help in understanding why this code does not successfully change the default exp status bar color:

lua Code:

hooksecurefunc("ExhaustionTick_OnEvent", function(self, event, ...)
    MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
end);

Also tried:

lua Code:

hooksecurefunc("ExhaustionTick_OnEvent", function(self, event, ...)
    MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
    if (exhaustionStateID == 1) or (exhaustionStateID == 2) then
        MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
    end
end);

Below is the full function from Blizzard's MainMenuBar.lua. For giggles I used the whole thing in my hooksecurefunc() to no avail...I'm not seeing the SetStatusBarColor() values being applied. I appreciate any thoughts.

lua Code:

function ExhaustionTick_OnEvent(self, event, ...)
    if ((event == "PLAYER_ENTERING_WORLD") or (event == "PLAYER_XP_UPDATE") or (event == "UPDATE_EXHAUSTION") or (event == "PLAYER_LEVEL_UP")) then
        local playerCurrXP = UnitXP("player");
        local playerMaxXP = UnitXPMax("player");
        --local exhaustionCurrXP, exhaustionMaxXP;
        --exhaustionCurrXP, exhaustionMaxXP = GetXPExhaustion();
        local exhaustionThreshold = GetXPExhaustion();
        local exhaustionStateID, exhaustionStateName, exhaustionStateMultiplier;
        exhaustionStateID, exhaustionStateName, exhaustionStateMultiplier = GetRestState();
        if (exhaustionStateID >= 3) then
            ExhaustionTick:SetPoint("CENTER", "MainMenuExpBar", "RIGHT", 0, 0);
        end
 
        if (not exhaustionThreshold) then
            ExhaustionTick:Hide();
            ExhaustionLevelFillBar:Hide();
        else
            local exhaustionTickSet = max(((playerCurrXP + exhaustionThreshold) / playerMaxXP) * MainMenuExpBar:GetWidth(), 0);
--          local exhaustionTotalXP = playerCurrXP + (exhaustionMaxXP - exhaustionCurrXP);
--          local exhaustionTickSet = (exhaustionTotalXP / playerMaxXP) * MainMenuExpBar:GetWidth();
            ExhaustionTick:ClearAllPoints();
            if (exhaustionTickSet > MainMenuExpBar:GetWidth() or MainMenuBarMaxLevelBar:IsShown()) then
                ExhaustionTick:Hide();
                ExhaustionLevelFillBar:Hide();
                -- Saving this code in case we want to always leave the exhaustion tick onscreen
--              ExhaustionTick:SetPoint("CENTER", "MainMenuExpBar", "RIGHT", 0, 0);
--              ExhaustionLevelFillBar:SetPoint("TOPRIGHT", "MainMenuExpBar", "TOPRIGHT", 0, 0);
            else
                ExhaustionTick:Show();
                ExhaustionTick:SetPoint("CENTER", "MainMenuExpBar", "LEFT", exhaustionTickSet, 0);
                ExhaustionLevelFillBar:Show();
                ExhaustionLevelFillBar:SetPoint("TOPRIGHT", "MainMenuExpBar", "TOPLEFT", exhaustionTickSet, 0);
            end
        end
 
        -- Hide exhaustion tick if player is max level or XP is turned off
        if ( UnitLevel("player") == MAX_PLAYER_LEVEL or IsXPUserDisabled() ) then
            ExhaustionTick:Hide();
        end
    end
    if ((event == "PLAYER_ENTERING_WORLD") or (event == "UPDATE_EXHAUSTION")) then
        local exhaustionStateID = GetRestState();
        if (exhaustionStateID == 1) then
            MainMenuExpBar:SetStatusBarColor(0.0, 0.39, 0.88, 1.0);
            ExhaustionLevelFillBar:SetVertexColor(0.0, 0.39, 0.88, 0.15);
            ExhaustionTickHighlight:SetVertexColor(0.0, 0.39, 0.88);
        elseif (exhaustionStateID == 2) then
            MainMenuExpBar:SetStatusBarColor(0.58, 0.0, 0.55, 1.0);
            ExhaustionLevelFillBar:SetVertexColor(0.58, 0.0, 0.55, 0.15);
            ExhaustionTickHighlight:SetVertexColor(0.58, 0.0, 0.55);
        end
 
    end
    if ( not MainMenuExpBar:IsShown() ) then
        ExhaustionTick:Hide();
    end
end

Nibelheim · 06-03-11, 01:24 AM

Does it work if you simply enter this into your chat window?

Code:

/run MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)

Aprikot · 06-03-11, 07:13 PM

Originally Posted by Nibelheim

Does it work if you simply enter this into your chat window?

Code:

/run MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)

Yep sure does...could I fail harder?! I know better too...

Thanks for the gentle delivery.

Nibelheim · 06-03-11, 07:31 PM

Originally Posted by Aprikot

Yep sure does...could I fail harder?! I know better too...

Thanks for the gentle delivery.

Hmm, so problem fixed?

Aprikot · 06-03-11, 08:10 PM

Originally Posted by Nibelheim

Hmm, so problem fixed?

It's not working yet in my addon, but I think that might be due to the load order.

I'm going to try registering PLAYER_ENTERING_WORLD to see if that helps. I guess that's good practice anyway?

Nibelheim · 06-03-11, 08:24 PM

Originally Posted by Aprikot

It's not working yet in my addon, but I think that might be due to the load order.

I'm going to try registering PLAYER_ENTERING_WORLD to see if that helps. I guess that's good practice anyway?

It's not a bad idea. Just register PLAYER_LOGIN and do your hooks at that point.

Code:

f = CreateFrame("Frame")
f:RegisterEvent("PLAYER_LOGIN")
f:SetScript("OnEvent", function()
    MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
    hooksecurefunc("ExhaustionTick_OnEvent", function()
        MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
    end)
end)

Aprikot · 06-03-11, 10:57 PM

I can't seem to get the hooked function to work; the bar color defaults after update. I'm able get the desired result by registering the additional events to my frame:

Code:

local f = CreateFrame("Frame")
f:RegisterEvent("PLAYER_ENTERING_WORLD")
f:RegisterEvent("PLAYER_XP_UPDATE");
f:RegisterEvent("UPDATE_EXHAUSTION");
f:RegisterEvent("PLAYER_LEVEL_UP");
f:RegisterEvent("PLAYER_UPDATE_RESTING");
f:SetScript("OnEvent", function()
    MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1) 
end)

Just not sure if this is a desirable method...

Aprikot · 07-27-11, 11:55 AM

I'm trying to do the same thing with the rep bar (recolor it), and having an issue where the bar will not recolor on load (but will recolor on exp gain):

lua Code:

-- doesn't work:
local ff = CreateFrame("Frame")
ff:RegisterEvent("PLAYER_ENTERING_WORLD")
ff:SetScript("OnEvent", function()
    ReputationWatchStatusBar:SetStatusBarColor(1, 1, 1) 
end)
 
-- works:
local ff = CreateFrame("Frame")
ff:RegisterEvent("PLAYER_XP_UPDATE")
ff:SetScript("OnEvent", function()
    ReputationWatchStatusBar:SetStatusBarColor(1, 1, 1) 
end)

Any idea why this doesn't work with PLAYER_ENTERING_WORLD? It works for the exp bar (code in post above this).

Mischback · 07-27-11, 12:23 PM

Could you "noop" the original function?

Code:

local function noop()
    return
end

    MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
    MainMenuExpBar.SetStatusBarColor = noop

Haleth · 07-27-11, 12:45 PM

@ OP; In your second attempt, you refer to exhaustionStateID without defining it. Local values are not inherited from hooked functions.

Try it when you define it as GetRestState(), as the original Blizzard function does.

SDPhantom · 07-27-11, 01:00 PM

Originally Posted by Aprikot

... For giggles I used the whole thing in my hooksecurefunc() to no avail...I'm not seeing the SetStatusBarColor() values being applied. I appreciate any thoughts.

Here's a clip of MainMenuBar.xml...

xml Code:

<Button name="ExhaustionTick" parent="MainMenuExpBar" hidden="false" frameStrata="DIALOG">
    <Size>
        <AbsDimension x="32" y="32"/>
    </Size>
    <Anchors>
        <Anchor point="CENTER" relativeTo="MainMenuExpBar">
            <Offset>
                <AbsDimension x="0" y="0"/>
            </Offset>
        </Anchor>
    </Anchors>
    <Scripts>
        <OnLoad function="ExhaustionTick_OnLoad"/>
        <OnEvent function="ExhaustionTick_OnEvent"/>
        <OnEnter function="ExhaustionToolTipText"/>
        <OnLeave function="GameTooltip_Hide"/>
    </Scripts>
    <NormalTexture name="ExhaustionTickNormal" file="Interface\MainMenuBar\UI-ExhaustionTickNormal"/>
    <HighlightTexture name="ExhaustionTickHighlight" file="Interface\MainMenuBar\UI-ExhaustionTickHighlight" alphaMode="ADD"/>
</Button>

Notice the way the script functions are registered. This grabs the function immediately and sets it to the associated script. hooksecurefunc() will not work on this. You'll have to hook the frame's script handler directly with something like this.

lua Code:

ExhaustionTick:HookScript("OnEvent",function(self,event,...)
    MainMenuExpBar:SetStatusBarColor(1,1,1,1);
end);

Originally Posted by Aprikot

I'm trying to do the same thing with the rep bar (recolor it), and having an issue where the bar will not recolor on load (but will recolor on exp gain):

...

Any idea why this doesn't work with PLAYER_ENTERING_WORLD? It works for the exp bar (code in post above this).

Your code is conflicting with Blizzards and the event API will randomly choose which it'll fire the event first for. This one seems to actually be called instead of set as a script handler, so hooksecurefunc() will work on this one.

lua Code:

hooksecurefunc("ReputationWatchBar_Update",function()
    ReputationWatchStatusBar:SetStatusBarColor(1,1,1,1);
end);

Aprikot · 07-27-11, 04:48 PM

I appreciate all the replies...

Originally Posted by Haleth

@ OP; In your second attempt, you refer to exhaustionStateID without defining it. Local values are not

inherited from hooked functions.

Try it when you define it as GetRestState(), as the original Blizzard function does.

Thanks, this is good to know. When I "For giggles I used the whole thing in my hooksecurefunc()" the definition was there (but I didn't know it needed to be defined there

):

lua Code:

hooksecurefunc("ExhaustionTick_OnEvent", function(self, event, ...)
        local exhaustionStateID = GetRestState();
        if (exhaustionStateID == 1) then
            MainMenuExpBar:SetStatusBarColor(0, 1, 0);
            ExhaustionLevelFillBar:SetVertexColor(0, 1, 0, .2);
            ExhaustionTickHighlight:SetVertexColor(0, 1, 0);
        elseif (exhaustionStateID == 2) then
            MainMenuExpBar:SetStatusBarColor(0.58, 0.0, 0.55, 1.0);
            ExhaustionLevelFillBar:SetVertexColor(0.58, 0.0, 0.55, 0.15);
            ExhaustionTickHighlight:SetVertexColor(0.58, 0.0, 0.55);
        end
    end)

Originally Posted by SDPhantom

Here's a clip of MainMenuBar.xml...

xml Code:

<Button name="ExhaustionTick" parent="MainMenuExpBar" hidden="false" frameStrata="DIALOG">
    <Size>
        <AbsDimension x="32" y="32"/>
    </Size>
    <Anchors>
        <Anchor point="CENTER" relativeTo="MainMenuExpBar">
            <Offset>
                <AbsDimension x="0" y="0"/>
            </Offset>
        </Anchor>
    </Anchors>
    <Scripts>
        <OnLoad function="ExhaustionTick_OnLoad"/>
        <OnEvent function="ExhaustionTick_OnEvent"/>
        <OnEnter function="ExhaustionToolTipText"/>
        <OnLeave function="GameTooltip_Hide"/>
    </Scripts>
    <NormalTexture name="ExhaustionTickNormal" file="Interface\MainMenuBar\UI-ExhaustionTickNormal"/>
    <HighlightTexture name="ExhaustionTickHighlight" file="Interface\MainMenuBar\UI-ExhaustionTickHighlight" 
 
alphaMode="ADD"/>
</Button>

Notice the way the script functions are registered. This grabs the function immediately and sets it to the associated

script. hooksecurefunc() will not work on this. You'll have to hook the frame's script handler directly with

something like this.

lua Code:

ExhaustionTick:HookScript("OnEvent",function(self,event,...)
    MainMenuExpBar:SetStatusBarColor(1,1,1,1);
end);

Your code is conflicting with Blizzards and the event API will randomly choose which it'll fire the event first for. This

one seems to actually be called instead of set as a script handler, so hooksecurefunc() will work on this one.

lua Code:

hooksecurefunc("ReputationWatchBar_Update",function()
    ReputationWatchStatusBar:SetStatusBarColor(1,1,1,1);
end);

This is good info, and both code examples work perfectly.

Originally Posted by Mischback

Could you "noop" the original function?

Code:

local function noop()
    return
end

    MainMenuExpBar:SetStatusBarColor(1, 1, 1, 1)
    MainMenuExpBar.SetStatusBarColor = noop

This also works perfectly.

So is return nothing just putting the kibosh on any subsequent SetStatusBarColor attempts from Blizzard?

Both methods acheive the desired result...

Click image for larger version

Name: WoWScrnShot_072711_163000.jpg
Views: 407
Size: 1.41 MB
ID: 6393

Haleth · 07-27-11, 05:13 PM

If you want to play safe, use the hooking method. If you want the most efficient, use the one where you noop the Blizzard function (= overriding it with an empty function). This may cause taint though.