Odd kgPanels error.

[suicidalkatt]

So I've been getting a random error while in raid combat from kgPanels and I assume something is trying to make secure frames while in combat, but I have nothing that seems to be doing this. What I believe is happening is the default wow raid frames are trying to update in combat (LFR people joining and dropping group for example) and kgPanels hooked scripts are causing issues.

Any thoughts?

Error:

62x CreateFrame: Can"t create protected "Button" now <in C code> <in C code> Blizzard_CompactRaidFrameContainer.lua:343: in function "CompactRaidFrameContainer_GetUnitFrame" Blizzard_CompactRaidFrameContainer.lua:315: in function "CompactRaidFrameContainer_AddUnitFrame" Blizzard_CompactRaidFrameContainer.lua:267: in function "CompactRaidFrameContainer_AddPets" Blizzard_CompactRaidFrameContainer.lua:183: in function "CompactRaidFrameContainer_LayoutFrames" Blizzard_CompactRaidFrameContainer.lua:131: in function "CompactRaidFrameContainer_TryUpdate" Blizzard_CompactRaidFrameContainer.lua:63: in function "CompactRaidFrameContainer_OnEvent" <string>:"*:OnEvent":1: in function <string>:"*:OnEvent":1 Locals: (*temporary) = "Button" (*temporary) = "CompactRaidFrame12" (*temporary) = CompactRaidFrameContainer { unitFrameUnusedFunc = <func> @Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua:47 flowSortFunc = <func> @Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameManager.lua:733 groupMode = "discrete" raidUnits = <table> {} frameUpdateList = <table> {} flowOrientation = "vertical" borderFrame = CompactRaidFrameContainerBorderFrame {} flowFilterFunc = <func> @Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameManager.lua:831 groupFilterFunc = <func> @Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameManager.lua:861 partyUnits = <table> {} flowMaxPrimaryUsed = 360.0000005471 flowMaxSecondaryUsed = 193.99997551737 units = <table> {} flowPauseUpdates = true enabled = false frameReservations = <table> {} flowFrames = <table> {} 0 = <userdata> displayPets = true displayFlaggedMembers = true } (*temporary) = "CompactUnitFrameTemplate" = <func> =[C]:-1 = <func> @..\kgPanels.lua:286

Pointed location:

local function reParentCheck(newframe)  
    for frame,mparent in pairs(missingParents) do
        local pf = parents[mparent]
        if not (kgPanels.db.global.layouts[kgPanels.active] and  kgPanels.db.global.layouts[kgPanels.active][frame]) then
            return
        end
        local isPercents = strmatch(kgPanels.db.global.layouts[kgPanels.active][frame].width, "%d+%.?%d*%%") or strmatch(kgPanels.db.global.layouts[kgPanels.active][frame].height, "%d+%.?%d*%%")
        if pf or mparent == newframe then -- the frame we want just got created
            -- make sure we dont parent to outselves
            if activeFrames[frame] == pf then error("Attempting to parent frame to self") end
            if pf then
                if (isPercents and pf:GetWidth() > 0 and pf:GetHeight() > 0) or not isPercents then
                    kgPanels:ResetParent(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
                    activeFrames[frame]:Show();updateChildVisibility(activeFrames[frame])
                    missingParents[frame] = nil
                    checkFrames = checkFrames -1
                    activeFrames[frame].missing_parent_at_load = false
                    activeFrames[frame].scripts_loaded = false
                    executeScripts(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
                end
            end
        elseif activeFrames[mparent] and activeFrames[mparent] ~= frame then -- check the list of self frames
            if (isPercents and activeFrames[mparent]:GetWidth() > 0 and activeFrames[mparent]:GetHeight() > 0) or not isPercents then
                kgPanels:ResetParent(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
                activeFrames[frame]:Show();updateChildVisibility(activeFrames[frame])
                missingParents[frame] = nil
                checkFrames = checkFrames -1
                activeFrames[frame].missing_parent_at_load = false
                activeFrames[frame].scripts_loaded = false
                executeScripts(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
            end
        end
    end
    for frame,manchor in pairs(missingAnchors) do
        if activeFrames[manchor] and activeFrames[manchor] ~= frame then -- check the list of self frames
            kgPanels:ResetParent(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
            activeFrames[frame]:Show() 
            updateChildVisibility(activeFrames[frame])
            missingAnchors[frame] = nil
            checkFrames = checkFrames - 1
            activeFrames[frame].missing_anchor_at_load = false
            activeFrames[frame].scripts_loaded = false
            executeScripts(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
        elseif parents[manchor] or manchor == newframe then -- the frame we want just got created
            -- make sure we dont anchor to outselves
            if activeFrames[frame] == parents[manchor] then error("Attempting to anchor frame to self") end
            if parents[manchor] then
                kgPanels:ResetParent(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
                activeFrames[frame]:Show(); 
                updateChildVisibility(activeFrames[frame])
                missingAnchors[frame] = nil
                checkFrames = checkFrames -1
                activeFrames[frame].missing_anchor_at_load = false
                activeFrames[frame].scripts_loaded = false
                executeScripts(activeFrames[frame],kgPanels.db.global.layouts[kgPanels.active][frame],frame)
            end
        end
    end
end
 
-- Called from securly hooked CreateFrame().  Check if the frame being created is one of the frames marked as dirty in 
-- our list of bad parent frames.  If it is, reconfigure the panel to work with the frame and remove it from the dirty list
-- This is line 286 here:
local parentCheckHook = function(...)
    local _,frame,_,_ = ...
    if frame and checkFrames > 0 then
        reParentCheck(frame)
    end
end
 
--This is the hooked function later on in kgpanels code:
-- Hook the CreateFrame function so that kgPanels set to non-existant parent/anchor frames can be updated if/when those frames are created
    hooksecurefunc("CreateFrame", parentCheckHook)

[Nibelheim]

I remember the Blizz Raid Frames being verrrrry taint sensitive.

Now, if only they could introduce an option to permanently disable them... eh, never going to happen.

[suicidalkatt]

Is there any way to avoid this error??

[Phanx]

It's probably something you're doing in a kgPanels script that the addon doesn't account for. Post your scripts, or at least rule them out as a cause by switching to a blank profile in kgPanels and see if you still get errors when your usual scripts aren't loaded.

[suicidalkatt]

Originally Posted by Phanx It's probably something you're doing in a kgPanels script that the addon doesn't account for. Post your scripts, or at least rule them out as a cause by switching to a blank profile in kgPanels and see if you still get errors when your usual scripts aren't loaded.

I have a rather extensive kgPanels layout (nothing that creates buttons however). I'll try just having a default profile and see if that does anything.

[suicidalkatt]

Originally Posted by suicidalkatt I have a rather extensive kgPanels layout (nothing that creates buttons however). I'll try just having a default profile and see if that does anything.

So, after a few days of testing something in my layout is bringing the error up.

I can post my saved variables if someone wants to fish around?

[Phanx]

I already told you to post your scripts.

[suicidalkatt]

Originally Posted by Phanx I already told you to post your scripts.

http://dl.dropbox.com/u/4479083/kgPanels.lua

If you want my textures and such, I can add my SharedMedia_MyMedia here as well.

[suicidalkatt]

Any updates?

[Phanx]

No, I'm mainly only home on weekends; during the week I don't usually have time to dig through code, and do not have any access to WoW to load anything in-game.

[suicidalkatt]

Bump! If anyone has any insight, it would be greatly appreciated.

[Phanx]

That's a huge amount of scripting. Frankly you'd be better off just writing your own addon instead of going through kgPanels to make option buttons, frame toggle buttons, etc. You clearly understand enough WoW programming to write those scripts; creating franes is not really any more complicated than that.

Anyway, I only got through the first few hundred lines of scripting (and that was after spending 10 minutes removing all the non-script junk from the SV file), but I didn't see anything that should be tainting anything.

You could try enabling taint logging and checking the log to see if anything related to kgPanels comes up. See:
http://www.wowpedia.org/CVar_taintLog

Finally, you might consider submitting a ticket on the kgPanels project page over on WowAce. The kgPanels developer(s) will probably have a much easier time scanning your scripts and identifying any possible issues, since they know exactly how the addon works and how it handles scripts.

Oh, and I forgot to ask if the problem still happens when kgPanels (with your scripts) is the only addon loaded.

[suicidalkatt]

Originally Posted by Phanx Oh, and I forgot to ask if the problem still happens when kgPanels (with your scripts) is the only addon loaded.

Yea it does. I'll submit a ticket when I get the chance.

The main reason I'm still using kgPanels vs making a complete addon of my own, is that it allows the users of my UI a bit more customization, should they seek it. Easier on my part I spose.