Macro button inside bag, and still can be opened in combat

frohanss · 08-18-17, 07:07 PM

Hello

So i have my edited version of Stuffing bags.
I have added 3 buttons inside it for depositing regents, 2x sort options and a button to use any artifact power items in the bags.

Since macro button needs "SecureActionButtonTemplate", the bags can't be opened during combat.

Any good sugestion on how to fix this?

It's fine if the buttons can't be used during combat, just as longe the bags will open.

Lua Code:

function Stuffing:InitBags()
    if self.frame then return end
 
    self.buttons = {}
    self.bags = {}
    self.bagframe_buttons = {}
 
    local f = self:CreateBagFrame("Bags")
    f:SetScript("OnShow", Stuffing_OnShow)
    f:SetScript("OnHide", Stuffing_OnHide)
 
    local editbox = CreateFrame("EditBox", nil, f)
    editbox:Hide()
    editbox:SetAutoFocus(true)
    editbox:SetHeight(32)
    editbox:CreateBackdrop("Default")
    editbox.backdrop:SetPoint("TOPLEFT", -2, 1)
    editbox.backdrop:SetPoint("BOTTOMRIGHT", 2, -1)
 
    local resetAndClear = function(self)
        self:GetParent().detail:Show()
        self:ClearFocus()
        Stuffing:SearchReset()
    end
 
    local updateSearch = function(self, t)
        if t == true then
            Stuffing:SearchUpdate(self:GetText())
        end
    end
 
    editbox:SetScript("OnEscapePressed", resetAndClear)
    editbox:SetScript("OnEnterPressed", resetAndClear)
    editbox:SetScript("OnEditFocusLost", editbox.Hide)
    editbox:SetScript("OnEditFocusGained", editbox.HighlightText)
    editbox:SetScript("OnTextChanged", updateSearch)
    editbox:SetText(SEARCH)
 
    local detail = f:CreateFontString(nil, "ARTWORK", "GameFontHighlightLarge")
    detail:SetPoint("TOPLEFT", f, 11, -10)
    detail:SetPoint("RIGHT", f, -140, -10)
    detail:SetHeight(13)
    detail:SetShadowColor(0, 0, 0, 0)
    detail:SetJustifyH("LEFT")
    detail:SetText("|cff9999ff"..SEARCH.."|r")
    editbox:SetAllPoints(detail)
 
    local button = CreateFrame("Button", nil, f)
    button:EnableMouse(true)
    button:RegisterForClicks("LeftButtonUp", "RightButtonUp")
    button:SetAllPoints(detail)
    button.ttText = L_BAG_RIGHT_CLICK_SEARCH
    button:SetScript("OnClick", function(self, btn)
        if btn == "RightButton" then
            self:GetParent().detail:Hide()
            self:GetParent().editbox:Show()
            self:GetParent().editbox:HighlightText()
        else
            if self:GetParent().editbox:IsShown() then
                self:GetParent().editbox:Hide()
                self:GetParent().editbox:ClearFocus()
                self:GetParent().detail:Show()
                Stuffing:SearchReset()
            end
        end
    end)
 
    local tooltip_hide = function()
        GameTooltip:Hide()
    end
 
    local tooltip_show = function(self)
        GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
        GameTooltip:ClearLines()
        GameTooltip:SetText(self.ttText)
    end
 
    button:SetScript("OnEnter", tooltip_show)
    button:SetScript("OnLeave", tooltip_hide)
    
    --Deposit Button
    f.depositButton = CreateFrame("Button", nil, f);
    f.depositButton:SetSize(16, 16)
    f.depositButton:SetTemplate()
    f.depositButton:SetPoint("TOPRIGHT", f, -25, -4)
    f.depositButton:SetHeight(18)
    f.depositButton:SetWidth(18)
    f.depositButton:SetNormalTexture("Interface\\ICONS\\misc_arrowdown")
    f.depositButton:GetNormalTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.depositButton:GetNormalTexture():SetPoint("TOPLEFT", 2, -2)
    f.depositButton:GetNormalTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.depositButton:SetPushedTexture("Interface\\ICONS\\misc_arrowdown")
    f.depositButton:GetPushedTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.depositButton:GetPushedTexture():SetPoint("TOPLEFT", 2, -2)
    f.depositButton:GetPushedTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.depositButton:StyleButton()
    f.depositButton.ttText = "Deposit Reagents"
    f.depositButton:SetScript("OnEnter", tooltip_show)
    f.depositButton:SetScript("OnLeave", tooltip_hide)
    f.depositButton:SetScript('OnClick',function(self, btn)
 
            PlaySound("igMainMenuOption");
            DepositReagentBank()
    end)
    
    --Sort Button
    f.sortButton = CreateFrame("Button", nil, f, "SecureActionButtonTemplate");
    f.sortButton:SetSize(16, 16)
    f.sortButton:SetTemplate()
    f.sortButton:SetPoint("TOPRIGHT", f.depositButton, -25, 0)
    f.sortButton:SetHeight(18)
    f.sortButton:SetWidth(18)
    f.sortButton:SetNormalTexture("Interface\\ICONS\\INV_Pet_Broom")
    f.sortButton:GetNormalTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.sortButton:GetNormalTexture():SetPoint("TOPLEFT", 2, -2)
    f.sortButton:GetNormalTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.sortButton:SetPushedTexture("Interface\\ICONS\\INV_Pet_Broom")
    f.sortButton:GetPushedTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.sortButton:GetPushedTexture():SetPoint("TOPLEFT", 2, -2)
    f.sortButton:GetPushedTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.sortButton:StyleButton()
    f.sortButton.ttText = "LM:Cleanup / RM:Blizzard"
    f.sortButton:SetScript("OnEnter", tooltip_show)
    f.sortButton:SetScript("OnLeave", tooltip_hide)
    f.sortButton:SetScript("OnMouseUp", function(self, btn)
        if IsShiftKeyDown() then
        ToggleAchievementFrame()
        elseif btn == "RightButton" then
        SetSortBagsRightToLeft(true)
        SortBags()
        else
        f.sortButton:SetAttribute("type1", "macro")
        f.sortButton:SetAttribute('macrotext', '/bags sort d')
        end
    end)
    
    --Artifact Button
    f.ArtifactButton = CreateFrame("Button", nil, f, "SecureActionButtonTemplate");
    f.ArtifactButton:SetSize(16, 16)
    f.ArtifactButton:SetTemplate()
    f.ArtifactButton:SetPoint("TOPRIGHT", f.sortButton, -25, 0)
    f.ArtifactButton:SetHeight(18)
    f.ArtifactButton:SetWidth(18)
    f.ArtifactButton:SetNormalTexture("Interface\\Icons\\Achievement_doublejeopardy")
    f.ArtifactButton:GetNormalTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.ArtifactButton:GetNormalTexture():SetPoint("TOPLEFT", 2, -2)
    f.ArtifactButton:GetNormalTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.ArtifactButton:SetPushedTexture("Interface\\ICONS\\INV_Pet_Broom")
    f.ArtifactButton:GetPushedTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.ArtifactButton:GetPushedTexture():SetPoint("TOPLEFT", 2, -2)
    f.ArtifactButton:GetPushedTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.ArtifactButton:StyleButton()
    f.ArtifactButton.ttText = "Use Artifact Power item in bag"
    f.ArtifactButton:SetScript("OnEnter", tooltip_show)
    f.ArtifactButton:SetScript("OnLeave", tooltip_hide)
    f.ArtifactButton:SetScript("OnMouseUp", function(self, btn)
 
        f.ArtifactButton:SetAttribute("type", "macro")
        f.ArtifactButton:SetAttribute('macrotext', '/run local b=ApB or CreateFrame("Button","ApB",nil,"SecureActionButtonTemplate") for i=0,4 do for j=1,32 do if IsArtifactPowerItem(GetContainerItemID(i,j)) then b:SetAttribute("item",i.." "..j) b:SetAttribute("type","item") return end end end \n/click ApB')
    end)
    
    f.editbox = editbox
    f.detail = detail
    f.button = button
    self.frame = f
    f:Hide()
end

MunkDev · 08-18-17, 07:33 PM

The real question is why you're using SecureActionButtonTemplate in the first place since the commands you're using in those macros are not secure.
Just write the code directly in an OnClick script instead.

frohanss · 08-18-17, 07:47 PM

Originally Posted by MunkDev

The real question is why you're using SecureActionButtonTemplate in the first place since the commands you're using in those macros are not secure.
Just write the code directly in an OnClick script instead.

Maybe im just tired here but, not sure how to make it for the code with 2 macros for using the artifact items.

MunkDev · 08-18-17, 07:51 PM

It's simple really, just call UseContainerItem(bag, slot) directly in your script. Some functions are protected, yes, but some are only protected in the sense that they need to come from a hardware event. Calling the function inside an OnClick script means that you clicked on the button with your mouse to use it, so it should be okay.

frohanss · 08-18-17, 08:00 PM

Originally Posted by MunkDev

It's simple really, just call UseContainerItem(bag, slot) directly in your script. Some functions are protected, yes, but some are only protected in the sense that they need to come from a hardware event. Calling the function inside an OnClick script means that you clicked on the button with your mouse to use it, so it should be okay.

hmm ok

Been away from lua for a year so rusty.

Mainly used OnClick to use toggle frames like ToggleAchievementFrame()

MunkDev · 08-18-17, 08:03 PM

By the way, bags can have up to 36 slots, not 32. Even so, you're better off using a dynamic approach when looping through the bags.

Lua Code:

for bag=0, 4 do
    for slot=1, GetContainerNumSlots(bag) do
        -- do something
    end
end

frohanss · 08-18-17, 08:33 PM

Originally Posted by MunkDev

By the way, bags can have up to 36 slots, not 32. Even so, you're better off using a dynamic approach when looping through the bags.

Lua Code:

for bag=0, 4 do
    for slot=1, GetContainerNumSlots(bag) do
        -- do something
    end
end

No luck with

Lua Code:

f.ArtifactButton:SetScript('OnClick',function(self, btn)
        for bag=0, 4 do
            for slot=1, GetContainerNumSlots(bag) do
                if IsArtifactPowerItem(GetContainerItemID(bag, slot)) then UseContainerItem(bag, slot)
            end 
        end
    end)

MunkDev · 08-18-17, 09:01 PM

Lua Code:

f.ArtifactButton:SetScript('OnClick',function(self, btn)
    for bag=0, 4 do
        for slot=1, GetContainerNumSlots(bag) do
            if IsArtifactPowerItem(GetContainerItemID(bag, slot)) then 
                return UseContainerItem(bag, slot)
            end
        end 
    end
end)

If that doesn't work, just inherit your button from ContainerFrameItemButtonTemplate and set the IDs in a PreClick script and use the inherited OnClick. That requires the parent of your button to have the bag ID and the button itself to have the slot ID. Bag buttons are not protected, but if you're getting a taint error it just means that the call to UseContainerItem needs to come from an untainted function.

Lua Code:

f.ArtifactButton:SetScript('PreClick',function(self, btn)
    for bag=0, 4 do
        for slot=1, GetContainerNumSlots(bag) do
            if IsArtifactPowerItem(GetContainerItemID(bag, slot)) then 
                self:GetParent():SetID(bag)
                self:SetID(slot)
                return
            end
        end 
    end
end)

frohanss · 08-19-17, 04:10 AM

Originally Posted by MunkDev

Lua Code:

f.ArtifactButton:SetScript('OnClick',function(self, btn)
    for bag=0, 4 do
        for slot=1, GetContainerNumSlots(bag) do
            if IsArtifactPowerItem(GetContainerItemID(bag, slot)) then 
                return UseContainerItem(bag, slot)
            end
        end 
    end
end)

If that doesn't work, just inherit your button from ContainerFrameItemButtonTemplate and set the IDs in a PreClick script and use the inherited OnClick. That requires the parent of your button to have the bag ID and the button itself to have the slot ID. Bag buttons are not protected, but if you're getting a taint error it just means that the call to UseContainerItem needs to come from an untainted function.

Lua Code:

f.ArtifactButton:SetScript('PreClick',function(self, btn)
    for bag=0, 4 do
        for slot=1, GetContainerNumSlots(bag) do
            if IsArtifactPowerItem(GetContainerItemID(bag, slot)) then 
                self:GetParent():SetID(bag)
                self:SetID(slot)
                return
            end
        end 
    end
end)

Thanks alot for the help

Seems like i need to use preclick, the first one triggered protected code.
Never used preclick before. Behaves a bit strange, left click picks up the item and right click uses the item and there is no tooltip showing. Can it be changed to both show tooltip and also have anyclick use the items instead of picking it up?

Lua Code:

--Artifact Button
    f.ArtifactButton = CreateFrame("Button", nil, f, "BankItemButtonGenericTemplate");
    f.ArtifactButton:SetSize(16, 16)
    f.ArtifactButton:SetTemplate()
    f.ArtifactButton:SetPoint("TOPRIGHT", f.sortButton, -25, 0)
    f.ArtifactButton:SetHeight(18)
    f.ArtifactButton:SetWidth(18)
    f.ArtifactButton:SetNormalTexture("Interface\\Icons\\Achievement_doublejeopardy")
    f.ArtifactButton:GetNormalTexture():SetTexCoord(0.1, 0.9, 0.1, 0.9)
    f.ArtifactButton:GetNormalTexture():SetPoint("TOPLEFT", 2, -2)
    f.ArtifactButton:GetNormalTexture():SetPoint("BOTTOMRIGHT", -2, 2)
    f.ArtifactButton:StyleButton()
    f.ArtifactButton.ttText = "Use Artifact Power item in bag"
    f.ArtifactButton:SetScript("OnEnter", tooltip_show)
    f.ArtifactButton:SetScript("OnLeave", tooltip_hide)
    f.ArtifactButton:SetScript('PreClick',function(self, btn)
        for bag=0, 4 do
            for slot=1, GetContainerNumSlots(bag) do
                if IsArtifactPowerItem(GetContainerItemID(bag, slot)) then 
                    self:GetParent():SetID(bag)
                    self:SetID(slot)
                    return
                end
            end 
        end
    end)

MunkDev · 08-20-17, 04:33 AM

If you haven't already, download the source code and you can look at these things by examining the templates.

The OnClick function (ContainerFrameItemButton_OnClick) uses LeftButton for pickups and any other button for usage. To my knowledge, you can't fake which button is pressed without an override binding, so you might be stuck with right clicking.

As for displaying tooltips, look at ContainerFrameItemButton_OnEnter and ContainerFrameItemButton_OnLeave.

frohanss · 08-20-17, 06:57 AM

Originally Posted by MunkDev

If you haven't already, download the source code and you can look at these things by examining the templates.

The OnClick function (ContainerFrameItemButton_OnClick) uses LeftButton for pickups and any other button for usage. To my knowledge, you can't fake which button is pressed without an override binding, so you might be stuck with right clicking.

As for displaying tooltips, look at ContainerFrameItemButton_OnEnter and ContainerFrameItemButton_OnLeave.

Thanks again

Yes, i think so to. I just add RegisterForClicks("RightButtonUp") to stop left click.
As for the tooltip, i simply can't get it to show more then a second.
I guess this have something todo with the "PreClick"

MunkDev · 08-20-17, 08:32 AM

You should probably do the ID calculations OnEnter or OnUpdate instead if you want to show the tooltip. The tooltip is not going to show up if you're assigning the IDs when you're clicking the button.

Also, it's a good idea to set the IDs to an empty or invalid slot whenever you don't have any AP items, so you don't accidentally click on some other item that occupies a slot that was previously assigned in your script.

frohanss · 08-20-17, 02:47 PM

Not trying to show the tooltip for the item, but the text that i have defined. And it shows for a second everytime i move mouse over it.
But, it's working at thats the most important thing

MunkDev · 08-20-17, 03:42 PM

The item button template has a default OnUpdate script to keep updating the item tooltip every X seconds. You need to remove that script.