Mount drop message & sound

[ramzax]

Hello, I'm trying to make an addon to announce when a rare mount drops, since I almost never pay attention when looting the corpses and I'm using a fast loot addon so I don't see the loot window.

-- Mount drop message & sound

local mounts = {
	[71665] = true,		-- Flametalon of Alysrazor
	[69224] = true,		-- Smoldering Egg of Millagazor
	[68824] = true,		-- Swift Zulian Panther
	[43959] = true,		-- Grand Black War Mammoth
	[63041] = true,		-- Drake of the South Wind
	[78919] = true,		-- Experiment 12-B
	[77067] = true,		-- Blazing Drake
	[77069] = true,		-- Life-Binder's Handmaiden
	[50818] = true,		-- Invincible
	[45693] = true		-- Mimiron's Head
}

local function OnEvent(self, event, ...)
	for i = 0, GetNumLootItems(), 1 do
		local _, mountID = C_MountJournal.GetMountInfo(i)
	    	if mounts[mountID] then
	    		SendChatMessage("Mount dropped!", RAID_WARNING)
	    		PlaySoundFile("Sound\\Creature\\Ragnaros\\RagnarosSpecialAttack01.wav")
	    	end
    end
end

local mountDrop = CreateFrame("Frame")
mountDrop:RegisterEvent("LOOT_OPENED")
mountDrop:SetScript("OnEvent", OnEvent)
mountDrop:UnregisterEvent("LOOT_OPENED")

[Lombra]

You didn't mention what the problem was! But I'm guessing that the mount ID returned from C_MountJournal.GetMountInfo is not the same as the item ID.

[semlar]

Originally Posted by Lombra I'm guessing that the mount ID returned from C_MountJournal.GetMountInfo is not the same as the item ID.

He's not even getting the item id, he's just making a loop from 0 to GetNumLootItems and calling C_MountJournal.GetMountInfo on the iteration.

The loop should be starting at 1, not 0.

You can get the hyperlink for the item in the loot window via GetLootSlotLink(i), pull the item ID out of that with strsplit(':', link) or something and compare them to a table of item IDs for the mounts.

The event is also being unregistered, so the OnEvent script is never going to run.

[Phanx]

There's no way to get item IDs from the mount journal. C_MountJournal.GetMountInfo takes an index (eg. 1 is the 1st mount listed, 52 is that 52nd mount listed, and so on), not an itemID, item name, mount name, or loot slot index (which is what you're passing it). Searching by name would not be effective either, since many mount items have different names than the mounts they teach.

It would be way more efficient to just check if any mount dropped. Are there even any mounts that drop from mobs that aren't rare?

local c = { r = 1, g = 1, b = 1 } -- change values to use some color other than white
 
local f = CreateFrame("Frame")
f:RegisterEvent("LOOT_OPENED")
f:SetScript("OnEvent", function()
    for i = 1, GetNumLootItems() do
        local link = GetLootSlotLink(i)
        local _, _, _, _, _, _, subtype, _, _, icon = GetItemInfo(link)
        if subtype == "Mount" then -- change if you're not playing in English
            PlaySoundFile("Sound\\Creature\\Ragnaros\\RagnarosSpecialAttack01.wav")
            RaidNotice_AddMessage(RaidWarningFrame, "|T"..icon..":0|t "..link.." mount dropped!", c)
            return -- no need to keep looking
        end
    end
end)