Hud status bar questions.

[Grimsin]

Originally Posted by SDPhantom Heh... swapped the wrong values in my previous fix. Should be corrected now. The aim of the experimental code is to make storing orientation obsolete since it could be derived from the point set. The texture flip was intended to be in the design from the start, but my original formulas were glitched.

It can not be derived from the point set unless another texture is made or some sort of if on another function variable is done like i did. And i still cant come up with the right combo. It boils down to doing it your way means i HAVE to make another texture for the fill textures which means i have to add 4 more textures total to it.

DHUD and all the others use only one texture and they reverse the tex coords.

[Grimsin]

Your setpoint get method works fine as far as the orientation of how the bar fills but if you want to flip the bar fill texture we will have to add the if's like i did or something of that nature. So that a texture that looks like "(" will now look like ")"

[SDPhantom]

Hmm... After thinking through the code for a while, I think I found the flaw inherit to the original design. The fact it is incapable of flipping on an axis unrelated to its fill direction. Example, you want to flip horizontally while the bar is set to fill vertically.

It was written from the view that you'd be doing a horizontal fill with a horizontal flip, which honestly, isn't seen in any HUD addon other than my current in-house one.

Here's a new version using the old fill direction code with a separate flip processing section.

local function SetBarValue(bar,val1,val2,flipH,flipV)-- Accepts 5 values, bar texture, start value, end value, and flip flags (horizontal and vertical)
--  Keep the values within a 0-1 range
    val1=math.min(math.max(val1,0),1);
    val2=math.min(math.max(val2,0),1);
 
--  Sometimes textures glitch when trying to set a width or height of 0, so handle it here
    if val1==val2 then
        bar:Hide();
        return;
    else
        bar:Show();
    end
 
--  Set our low and high values
    local low,high=math.min(val1,val2),math.max(val1,val2);
 
--  Find our parent width and height
    local parent=bar:GetParent();
    local w,h=parent:GetWidth(),parent:GetHeight();
 
--  Get our point set, we'll use this to get our bar orientation
    local point=bar:GetPoint(1);
    if not point then return; end-- Handle if point isn't set, perhaps cleared?
 
--  These are our temp origin variables (note one of these pairs can have both vars nil, just use default texcoords for those)
    local origL=point:find("LEFT$");
    local origR=point:find("RIGHT$");
    local origT=point:find("^TOP");
    local origB=point:find("^BOTTOM");
 
--  Reset point
    bar:SetPoint(point
        ,(origL or origR) and (origL and low*w or -low*w) or 0--    X offset
        ,(origT or origB) and (origB and low*h or -low*h) or 0--    Y offset
    );
 
--  Texcoord calc
    local l,r,t,b=0,1,0,1;--    Texcoords are in the range of 0-1 with their origin at top left
    if origL then
        l,r=low,high;
    elseif origR then
        l,r=1-high,1-low;
    end
    if origT then
        t,b=low,high;
    elseif origB then
        t,b=1-high,1-low;
    end
 
--  Process flip (affects which side the bar piece is drawn from too)
    if flipH then l,r=1-l,1-r; end
    if flipV then t,b=1-t,1-b; end
 
--  Apply texcord/size
    bar:SetTexCoord(l,r,t,b);
    bar:SetWidth(w*math.abs(r-l));
    bar:SetHeight(h*math.abs(b-t));
end

[Grimsin]

That does it Ive noticed one thing... the bars are somewhat inaccurate, the bar does not appear to begin to empty until almost 100 or more life lost. same with mana... anyway to make it more accurate with its calculations? The mana bar is much worse it thinks its full with over 2000 mana out.

[SDPhantom]

What values are being passed to it? The function only accepts percent values in the range of 0-1.

[Grimsin]

this is the to event handlers for the health and mana, pretty much the same as you had it although the mana one is adjusted to change the color of the bar according to what type of power and does not use the other coloring method.

PlayerHBar:RegisterEvent("PLAYER_ENTERING_WORLD");
PlayerHBar:RegisterEvent("UNIT_HEALTH");
PlayerHBar:RegisterEvent("UNIT_HEALTH_PREDICTION");
 
PlayerHBar:SetScript("OnEvent",function(self,event)
    --  Stop handler if unit not player
    --if not UnitIsUnit(unit,"player") then return; end
    --  Temp vars
    local hcur,hmax,heal=UnitHealth("player"),UnitHealthMax("player"),UnitGetIncomingHeals("player") or 0;--    UnitGetIncomingHeals() can return nil for unsupported units
    local hppcnt=hcur/math.max(1,hmax);
    local healpcnt=heal/math.max(1,hmax);
 
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.HealthBar,0,hppcnt);
    addon:SetBarValue(self.HealBar,hppcnt,hppcnt+healpcnt);
  
    --  Color HealthBar (we're keeping HealBar white)
    --  This color formula ranges in color from green, to yellow, to red
    self.HealthBar:SetVertexColor(math.min(2-2*hppcnt,1),math.min(2*hppcnt,1),0);
end)
 
PlayerMBar:RegisterEvent("PLAYER_ENTERING_WORLD");
PlayerMBar:RegisterEvent("UNIT_POWER", "player");
 
PlayerMBar:SetScript("OnEvent",function(self,event)
    local pcur, pmax, ptype = UnitPower("player"), UnitPowerMax("player"), UnitPowerType("player");
 
    --local hcur,hmax,heal=UnitHealth("player"),UnitHealthMax("player"),UnitGetIncomingHeals("player") or 0;--    UnitGetIncomingHeals() can return nil for unsupported units
    local mppcnt = pcur/math.max(1,pmax);
 
 
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.ManaBar,0,mppcnt, "flipH");
 
  
    --  Color HealthBar (we're keeping HealBar white)
     if ptype == 0 then
        self.ManaBar:SetVertexColor(.556, .556, .921, 1)
    elseif ptype == 1 or 2 or 3 or 6 then
        self.ManaBar:SetVertexColor(.656, .456, .456, 1)
    end
end)

[SDPhantom]

The code "looks" fine, what are the dimensions for the bar texture and what is your max health/mana?

[Grimsin]

Originally Posted by SDPhantom The code "looks" fine, what are the dimensions for the bar texture and what is your max health/mana?

you mean like what are the dimensions of the blp/tga file itself? good question. I noticed the comment about how you should set the height width to be the same as the texture size. Maybe that is the problem. I will check the sizes and try it and be back in a bit.

edit- okay so its 128x256 on all the textures, i changed up the sizes to reflect that but still its off. my max health is 36604 and mana is 31626

[Grimsin]

what if we change the math from turning it into a percent to making it the actual number. That would be most accurate and i think it is why it fills before it should... when it hits a less then 1% amount it shows it filled all the way. so from 0 - 0.99% the bar is filled... or instead of changing it from percent add a decimal to the number system so that it reads the 0.01 - 0.99% which would also make it more accurate... not as accurate as the actual number. Im good with the theory just not so good with the actual math in code

edit - my numbers are off it would actually be when the bar displays 99.00- 99.99% i would imagine although i have not tested it the same will go for the low end. ex. your bar will show empty before you actually die when it trys to display the 0.99-0.01%

edit - another thought... the math system most likely rounds percents that do not have decimals in the equation. My guess is its right at 99.50% that it shows filled and that last .50 gets lost.

yet another edit - thinking about it and trying to come up with a solution i realized the heal prediction bar is most likely off by the same .xx% amounts.

yet again... - im not positive i understand this entirely but would it be as simple as changing local hppcnt=hcur/math.max(1,hmax); to local hppcnt=hcur/math.max(0.01,hmax);

And no its not at 99.50% its more like 95%

[Grimsin]

same issue with the pet bars only a lot worse since they are much smaller textures but the same canvas size. The problem is not with the numbers and %'s but with the texture getting its top origin from the canvas edge..


Okay... one last variable needs to be added to the function. One that allows you to set the texture edge offset. So lets say your ( is 250 pixels top to bottom but your canvas itself is 256, as all textures have to be powers of 2, the new variable would allow for one to set the graphic within the textures offset... hmmm crap well depending on the orientation of the bar you would actually need 4 settings. For my bar layout i only need the top to bottom settings but yea.... need another variable to accommodate for textures that do not fill the canvas size. The way things are right now what ever the difference is between the graphic and the texture canvas edges is being lost.

Is there any limit to the number of variables passed to a function? hope not lol...

[SDPhantom]

I was talking about the UI texture object that you load the image into, and with health and mana at 40k+ starting at 80, you'd have to have a pretty large chunk taken out of your pool before the bar can even move one pixel. Also be aware of any transparent pixels padding the bar in the actual image, they'd be read in as part of the bar too.

[Grimsin]

Originally Posted by SDPhantom I was talking about the UI texture object that you load the image into, and with health and mana at 40k+ starting at 80, you'd have to have a pretty large chunk taken out of your pool before the bar can even move one pixel. Also be aware of any transparent pixels padding the bar in the actual image, they'd be read in as part of the bar too.

Yea the problem is the padding is reading as part of the bar. That is the whole problem it would appear. Question is how to figure in that padding distance because unfortunately i can not remove it all. It should be possible to add another variable to the function that allows you to enter the padding offsets to the calculation. This is what things are looking like right now in whole. I know its doable. It should be as simple as adding the padding offsets to the texcoord settings somewhere.

local addonName, addon = ...
 
addon:RegisterDefaultSetting("hudShow", true)
addon:RegisterDefaultSetting("hudWidth", 100)
addon:RegisterDefaultSetting("hudHeight", 100)
addon:RegisterDefaultSetting("hudScale", 1)
 
local GHudMain = CreateFrame("Frame", "GHudMain", UIParent)
 
GHudMain:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
GHudMain:SetHeight(3)
GHudMain:SetWidth(3)
 
GHudMain:RegisterEvent("PLAYER_TARGET_CHANGED")
GHudMain:RegisterEvent("UNIT_PET", "player")
GHudMain:SetScript("OnEvent", function(event)
    addon:SetHudBackgrounds()
end)
 
function addon:SetupGHud()
    if addon.settings.hudShow then 
        GHudMain:Show()
    else
        GHudMain:Hide()
    end
end
 
function addon:GHudScale()
    GHudMain:SetScale(addon.settings.hudScale)
end
 
--[[-----------------------------------------------------------------------------
The IMPORTANT PART! Bar fill function, dont f with this.
-------------------------------------------------------------------------------]]
function addon:SetBarValue(bar,val1,val2, topoff, bottomoff, rightoff, leftoff, flipH,flipV)-- Accepts 3 values, bar texture, start value, and end value
    --  Keep the values within a 0-1 range
    val1=math.min(math.max(val1,0),1);
    val2=math.min(math.max(val2,0),1);
    --  Sometimes textures glitch when trying to set a width or height of 0, so handle it here
    if val1==val2 then
        bar:Hide();
        return;
    else
        bar:Show();
    end
    --  Set our low and high values
    local low,high = math.min(val1,val2),math.max(val1,val2);
    
    
    if bottomoff ~= 0 then
        --low = math.min(val1-bottomoff,val2-bottomoff)
    end
    if topoff ~= 0 then
        --high = math.max(val1-topoff,val2-topoff);
    end
    if rightoff ~= 0 then
    
    end
    if leftoff ~= 0 then
    
    end
    
    --  Find our parent width and height
    local parent=bar:GetParent();
    local w,h=parent:GetWidth(),parent:GetHeight();
    --  Get our point set, we'll use this to get our bar orientation
    local point=bar:GetPoint(1);
    if not point then return; end-- Handle if point isn't set, perhaps cleared?
    --  These are our temp origin variables (note one of these pairs can have both vars nil, just use default texcoords for those)
    local origL=point:find("LEFT$");
    local origR=point:find("RIGHT$");
    local origT=point:find("^TOP");
    local origB=point:find("^BOTTOM");
    --  Reset point (logic nightmare)
    bar:SetPoint(point
        ,(origL or origR) and (origL and low*w or -low*w) or 0--    X offset
        ,(origT or origB) and (origB and low*h or -low*h) or 0--    Y offset
    );
    --  Texcoord/Size set (this is actually the easy part)
    local l,r,t,b = 0,1,0,1;--    Texcoords are in the range of 0-1 with their origin at top left
    if origL then
        l,r = low, high;
    elseif origR then
        l,r = 1-high,1-low;
    end
    if origT then
        t,b = low,high;
    elseif origB then
        t,b = 1-high,1-low;
    end
    --  Process flip (affects which side the bar piece is drawn from too)
    if flipH then l,r=1-l,1-r; end
    if flipV then t,b=1-t,1-b; end
    
    bar:SetTexCoord(l,r,t,b);
    bar:SetWidth(w*math.abs(r-l));
    --bar:SetWidth(w*(r-l));
    bar:SetHeight(h*math.abs(b-t));
    --bar:SetHeight(h*(b-t));
end
 
--[[-----------------------------------------------------------------------------
Main Bar Creations
-------------------------------------------------------------------------------]]
local PlayerHBar = CreateFrame("Frame",nil, GHudMain);
local PlayerMBar = CreateFrame("Frame",nil, GHudMain);
local TargetHBar = CreateFrame("Frame",nil, GHudMain);
local TargetMBar = CreateFrame("Frame",nil, GHudMain);
local PPetHBar = CreateFrame("Frame",nil, GHudMain);
local PPetMBar = CreateFrame("Frame",nil, GHudMain);
 
function addon:LayoutHudBars()
    PlayerHBar:ClearAllPoints()
    PlayerHBar:SetPoint("RIGHT", GHudMain, "LEFT", - addon.settings.hudWidth, addon.settings.hudHeight);-- Place frame wherever
    PlayerMBar:ClearAllPoints()
    PlayerMBar:SetPoint("LEFT", GHudMain, "RIGHT", addon.settings.hudWidth, addon.settings.hudHeight);
    
    TargetHBar:ClearAllPoints()
    TargetHBar:SetPoint("RIGHT", GHudMain, "LEFT", - addon.settings.hudWidth, addon.settings.hudHeight);-- Place frame wherever
    TargetMBar:ClearAllPoints()
    TargetMBar:SetPoint("LEFT", GHudMain, "RIGHT", addon.settings.hudWidth, addon.settings.hudHeight);
 
    PPetHBar:ClearAllPoints()
    PPetHBar:SetPoint("RIGHT", GHudMain, "LEFT", - addon.settings.hudWidth, addon.settings.hudHeight);-- Place frame wherever
    PPetMBar:ClearAllPoints()
    PPetMBar:SetPoint("LEFT", GHudMain, "RIGHT", addon.settings.hudWidth, addon.settings.hudHeight);
end
 
PlayerHBar:SetWidth(128);--Width
PlayerHBar:SetHeight(256);--Height
 
PlayerMBar:SetWidth(128);--Width
PlayerMBar:SetHeight(256);--Height
 
TargetHBar:SetWidth(128);--Width
TargetHBar:SetHeight(256);--Height
 
TargetMBar:SetWidth(128);--Width
TargetMBar:SetHeight(256);--Height
 
PPetHBar:SetWidth(128);--Width
PPetHBar:SetHeight(256);--Height
 
PPetMBar:SetWidth(128);--Width
PPetMBar:SetHeight(256);--Height
 
 
--  Note: It's generally a good idea to use the same dimensions as your image file for your frame size
 
function addon:SetHudBackgrounds()
    if UnitExists("target") then
        if UnitExists("pet") then
            PlayerHBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_21p");--   Your bar image
            PlayerMBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_21p");--Your bar image
        else
            PlayerHBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_21");--   Your bar image
            PlayerMBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_21");--Your bar image
        end
    else
        if UnitExists("pet") then
            PlayerHBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_1p");--   Your bar image
            PlayerMBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_1p");--Your bar image
        else
            PlayerHBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_1");--   Your bar image
            PlayerMBar.Background:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\bg_1");--Your bar image
        end
    end
end
 
--Left Side
--  Background texture
PlayerHBar.Background = PlayerHBar:CreateTexture(nil,"BACKGROUND");
PlayerHBar.Background:SetAllPoints(PlayerHBar);--We want the texture spread to match the dimensions of the frame.
PlayerHBar.Background:SetAlpha(0.25)--Special suprize (black background at a quarter alpha)
 
--Right Side
--  Background texture
PlayerMBar.Background = PlayerMBar:CreateTexture(nil,"BACKGROUND");
PlayerMBar.Background:SetAllPoints(PlayerMBar);--We want the texture spread to match the dimensions of the frame.
PlayerMBar.Background:SetAlpha(0.25)
PlayerMBar.Background:SetTexCoord(1,0,0,1)
 
 
 
--[[-----------------------------------------------------------------------------
Player Bars
-------------------------------------------------------------------------------]]
PlayerHBar.HealthBar = PlayerHBar:CreateTexture(nil,"ARTWORK");--Notice the change in layers, this makes the bar draw on top of the background
PlayerHBar.HealthBar:SetPoint("BOTTOM");--We need only one point set, in this example, the bar fills toward the right, so we need it left-aligned
PlayerHBar.HealthBar:SetWidth(128);--Match frame width for now
PlayerHBar.HealthBar:SetHeight(256);--Match frame height for now
PlayerHBar.HealthBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\1");--Be sure to use the same image or one derived from the background
 
-- Player Mana Texture
PlayerMBar.ManaBar = PlayerMBar:CreateTexture(nil,"ARTWORK");--Notice the change in layers, this makes the bar draw on top of the background
PlayerMBar.ManaBar:SetPoint("BOTTOM");--We need only one point set, in this example, the bar fills toward the right, so we need it left-aligned
PlayerMBar.ManaBar:SetWidth(128);--Match frame width for now
PlayerMBar.ManaBar:SetHeight(256);--Match frame height for now
PlayerMBar.ManaBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\1");--Be sure to use the same image or one derived from the background
 
--  Heal prediction texture (this'll be my example of a partial bar)
PlayerHBar.HealBar = PlayerHBar:CreateTexture(nil,"ARTWORK");--         Use the same layer as Healthbar
PlayerHBar.HealBar:SetPoint("BOTTOM");--                   Use the same point for the HealthBar
PlayerHBar.HealBar:SetWidth(128);--                    Match frame width for now
PlayerHBar.HealBar:SetHeight(256);--                    Match frame height for now
PlayerHBar.HealBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\1");--  Be sure to use the same image or one derived from the background
 
PlayerHBar:RegisterEvent("PLAYER_ENTERING_WORLD");
PlayerHBar:RegisterEvent("UNIT_HEALTH", "player");
PlayerHBar:RegisterEvent("UNIT_HEALTH_PREDICTION");
 
PlayerHBar:SetScript("OnEvent",function(self,event)
    --  Stop handler if unit not player
    --if not UnitIsUnit(unit,"player") then return; end
    local hcur,hmax,heal=UnitHealth("player"),UnitHealthMax("player"),UnitGetIncomingHeals("player") or 0;--    UnitGetIncomingHeals() can return nil for unsupported units
    local hppcnt=hcur/math.max(1,hmax);
    local healpcnt=heal/math.max(1,hmax);
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.HealthBar,0,hppcnt, 0, 0, 0, 0);
    addon:SetBarValue(self.HealBar,hppcnt,hppcnt+healpcnt, 0, 0, 0, 0);
    --  Color HealthBar (we're keeping HealBar white)
    --  This color formula ranges in color from green, to yellow, to red
    self.HealthBar:SetVertexColor(math.min(2-2*hppcnt,1),math.min(2*hppcnt,1),0);
 
end)
 
PlayerMBar:RegisterEvent("PLAYER_ENTERING_WORLD");
PlayerMBar:RegisterEvent("UNIT_POWER", "player");
 
PlayerMBar:SetScript("OnEvent",function(self,event)
    local pcur, pmax, ptype = UnitPower("player"), UnitPowerMax("player"), UnitPowerType("player");
    local mppcnt = pcur/math.max(1,pmax);
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.ManaBar,0,mppcnt, 0, 0, 0, 0, "flipH");
    --  Color HealthBar (we're keeping HealBar white)
     if ptype == 0 then
        self.ManaBar:SetVertexColor(.556, .556, .921, 1)
    elseif ptype == 1 or 2 or 3 or 6 then
        self.ManaBar:SetVertexColor(.656, .456, .456, 1)
    end
end)
 
--[[-----------------------------------------------------------------------------
Target Bars
-------------------------------------------------------------------------------]]
TargetHBar.HealthBar = TargetHBar:CreateTexture(nil,"ARTWORK");--Notice the change in layers, this makes the bar draw on top of the background
TargetHBar.HealthBar:SetPoint("BOTTOM");--We need only one point set, in this example, the bar fills toward the right, so we need it left-aligned
TargetHBar.HealthBar:SetWidth(128);--Match frame width for now
TargetHBar.HealthBar:SetHeight(256);--Match frame height for now
TargetHBar.HealthBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\2");--Be sure to use the same image or one derived from the background
 
-- Player Mana Texture
TargetMBar.ManaBar = TargetMBar:CreateTexture(nil,"ARTWORK");
TargetMBar.ManaBar:SetPoint("BOTTOM");--We need only one point set, in this example, the bar fills toward the right, so we need it left-aligned
TargetMBar.ManaBar:SetWidth(128);--Match frame width for now
TargetMBar.ManaBar:SetHeight(256);--Match frame height for now
TargetMBar.ManaBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\2");--Be sure to use the same image or one derived from the background
 
TargetHBar:RegisterEvent("PLAYER_ENTERING_WORLD");
TargetHBar:RegisterEvent("PLAYER_TARGET_CHANGED");
TargetHBar:RegisterEvent("UNIT_HEALTH", "target");
TargetHBar:RegisterEvent("UNIT_HEALTH_PREDICTION", "target");
 
TargetHBar:SetScript("OnEvent",function(self,event)
    --  Stop handler if unit not player
    --if not UnitIsUnit(unit,"player") then return; end
    local hcur,hmax,heal=UnitHealth("target"),UnitHealthMax("target"),UnitGetIncomingHeals("target") or 0;--    UnitGetIncomingHeals() can return nil for unsupported units
    local hppcnt=hcur/math.max(1,hmax);
    local healpcnt=heal/math.max(1,hmax);
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.HealthBar,0,hppcnt, 0, 0, 0, 0);
    --addon:SetBarValue(self.HealBar,hppcnt,hppcnt+healpcnt);
 
    self.HealthBar:SetVertexColor(math.min(2-2*hppcnt,1),math.min(2*hppcnt,1),0);
 
end)
 
TargetMBar:RegisterEvent("PLAYER_ENTERING_WORLD");
TargetMBar:RegisterEvent("PLAYER_TARGET_CHANGED");
TargetMBar:RegisterEvent("UNIT_POWER", "target");
 
TargetMBar:SetScript("OnEvent",function(self,event)
    local pcur, pmax, ptype = UnitPower("target"), UnitPowerMax("target"), UnitPowerType("target");
    local mppcnt = pcur/math.max(1,pmax);
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.ManaBar,0,mppcnt, 0, 0, 0, 0, "flipH");
    --  Color HealthBar (we're keeping HealBar white)
     if ptype == 0 then
        self.ManaBar:SetVertexColor(.556, .556, .921, 1)
    elseif ptype == 1 or 2 or 3 or 6 then
        self.ManaBar:SetVertexColor(.656, .456, .456, 1)
    end
end)
 
--[[-----------------------------------------------------------------------------
Pet Bars
-------------------------------------------------------------------------------]]
PPetHBar.HealthBar = PPetHBar:CreateTexture(nil,"ARTWORK");--Notice the change in layers, this makes the bar draw on top of the background
PPetHBar.HealthBar:SetPoint("BOTTOM");--We need only one point set, in this example, the bar fills toward the right, so we need it left-aligned
PPetHBar.HealthBar:SetWidth(128);--Match frame width for now
PPetHBar.HealthBar:SetHeight(256);--Match frame height for now
PPetHBar.HealthBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\p1");--Be sure to use the same image or one derived from the background
 
-- Player Mana Texture
PPetMBar.ManaBar = PPetMBar:CreateTexture(nil,"ARTWORK");
PPetMBar.ManaBar:SetPoint("BOTTOM");--We need only one point set, in this example, the bar fills toward the right, so we need it left-aligned
PPetMBar.ManaBar:SetWidth(128);--Match frame width for now
PPetMBar.ManaBar:SetHeight(256);--Match frame height for now
PPetMBar.ManaBar:SetTexture("Interface\\AddOns\\GrimUI\\HudSkins\\p1");--Be sure to use the same image or one derived from the background
 
PPetHBar:RegisterEvent("PLAYER_ENTERING_WORLD");
PPetHBar:RegisterEvent("PLAYER_TARGET_CHANGED");
PPetHBar:RegisterEvent("UNIT_HEALTH", "pet")
PPetHBar:RegisterEvent("UNIT_LEVEL", "pet")
PPetHBar:RegisterEvent("UNIT_AURA", "pet")
PPetHBar:RegisterEvent("UNIT_MAXHEALTH", "pet")
PPetHBar:RegisterEvent("PLAYER_PET_CHANGED")
PPetHBar:RegisterEvent("UNIT_PET", "player")
PPetHBar:RegisterEvent("UNIT_HEALTH_PREDICTION", "pet");
 
PPetHBar:SetScript("OnEvent",function(self,event)
    --  Stop handler if unit not player
    --if not UnitIsUnit(unit,"player") then return; end
    local hcur,hmax,heal=UnitHealth("pet"),UnitHealthMax("pet"),UnitGetIncomingHeals("pet") or 0;--    UnitGetIncomingHeals() can return nil for unsupported units
    local hppcnt=hcur/math.max(1,hmax);
    local healpcnt=heal/math.max(1,hmax);
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.HealthBar,0,hppcnt, 175, 25, 0, 0);
    --addon:SetBarValue(self.HealBar,hppcnt,hppcnt+healpcnt);
 
    self.HealthBar:SetVertexColor(math.min(2-2*hppcnt,1),math.min(2*hppcnt,1),0);
 
end)
 
PPetMBar:RegisterEvent("PLAYER_ENTERING_WORLD");
PPetMBar:RegisterEvent("UNIT_HEALTH", "pet")
PPetMBar:RegisterEvent("UNIT_LEVEL", "pet")
PPetMBar:RegisterEvent("UNIT_MANA", "pet")
PPetMBar:RegisterEvent("UNIT_AURA", "pet")
PPetMBar:RegisterEvent("UNIT_DISPLAYPOWER", "pet")
PPetMBar:RegisterEvent("UNIT_ENERGY", "pet")
PPetMBar:RegisterEvent("UNIT_MAXENERGY", "pet")
PPetMBar:RegisterEvent("UNIT_MAXMANA", "pet")
 
PPetMBar:RegisterEvent("PET_UI_UPDATE");
PPetMBar:RegisterEvent("PLAYER_TARGET_CHANGED");
PPetMBar:RegisterEvent("UNIT_POWER", "pet");
 
PPetMBar:SetScript("OnEvent",function(self,event)
    local pcur, pmax, ptype = UnitPower("pet"), UnitPowerMax("pet"), UnitPowerType("pet");
    local mppcnt = pcur/math.max(1,pmax);
    --  Set our bars (notice the HealBar is a partial bar since it has a start value greater than zero)
    addon:SetBarValue(self.ManaBar,0,mppcnt, 175, 25, 0, 0,"flipH");
    --  Color HealthBar (we're keeping HealBar white)
     if ptype == 0 then
        self.ManaBar:SetVertexColor(.556, .556, .921, 1)
    elseif ptype == 1 or 2 or 3 or 6 then
        self.ManaBar:SetVertexColor(.656, .456, .456, 1)
    end
end)
--[[-----------------------------------------------------------------------------
Addon Loaded Initialize
-------------------------------------------------------------------------------]]
addon.RegisterEvent("HUD-Initialize", 'ADDON_LOADED', function(self, event)
    addon.UnregisterEvent(self, event)
    addon:SetupGHud()
    addon:LayoutHudBars()
    addon:SetupGHud()
    addon:SetHudBackgrounds()
end)

[SDPhantom]

Here's the modified function. The default values for the arguments noted below will apply if an argument is missing or is nil. Values marked required are as such.

Syntax:
SetBarValue(bar,val1,val2,flipH,flipV,cropx1,cropx2,cropy1,cropy2)

bar = Bar texture (required)
val1, val2 = Upper and lower values for the bar to be drawn (default 0)
flipH, flipV = Boolean true/false, flips texture horizontally/vertically if true (default false)
cropx1, cropx2, cropy1, cropy2 = Crop values, swapping high and low values within the xy pairs will not affect flipping (default 0, 1, 0, 1)

local function SetBarValue(bar,val1,val2,flipH,flipV,cropx1,cropx2,cropy1,cropy2)-- Accepts 9 values, bar texture, start value, end value, flip flags, and crop offsets (any value exceptbar can be nil)
--  Keep the values within a 0-1 range
    val1=math.min(math.max(val1 or 0,0),1);
    val2=math.min(math.max(val2 or 0,0),1);
 
--  Sometimes textures glitch when trying to set a width or height of 0, so handle it here
    if val1==val2 then
        bar:Hide();
        return;
    else
        bar:Show();
    end
 
--  Texture crop/padding
    cropx1=math.min(math.max(cropx1 or 0,0),1);
    cropx2=math.min(math.max(cropx2 or 1,0),1);
    cropy1=math.min(math.max(cropy1 or 0,0),1);
    cropy2=math.min(math.max(cropy2 or 1,0),1);
 
--  Set our low and high values
    local low,high=math.min(val1,val2),math.max(val1,val2);
 
--  Find our parent width and height
    local parent=bar:GetParent();
    local pw,ph=parent:GetWidth(),parent:GetHeight();
 
--  Get our point set, we'll use this to get our bar orientation
    local point=bar:GetPoint(1);
    if not point then return; end-- Handle if point isn't set, perhaps cleared?
 
--  These are our temp origin variables (note one of these pairs can have both vars nil, just use default texcoords for those)
    local origL=point:find("LEFT$");
    local origR=point:find("RIGHT$");
    local origT=point:find("^TOP");
    local origB=point:find("^BOTTOM");
 
--  Reset point
    bar:SetPoint(point
        ,(origL or origR) and (origL and low*pw or -low*pw) or 0--  X offset
        ,(origT or origB) and (origB and low*ph or -low*ph) or 0--  Y offset
    );
 
--  Texcoord calc
    local l,r,t,b=0,1,0,1;--    Texcoords are in the range of 0-1 with their origin at top left
    if origL then
        l,r=low,high;
    elseif origR then
        l,r=1-high,1-low;
    end
    if origT then
        t,b=low,high;
    elseif origB then
        t,b=1-high,1-low;
    end
 
--  Process flip (affects which side the bar piece is drawn from too)
    if flipH then l,r=1-l,1-r; end
    if flipV then t,b=1-t,1-b; end
 
--  Constrain to crop size
    local cropL,cropR,cropT,cropB=math.min(cropx1,cropx2),math.max(cropx1,cropx2),math.min(cropy1,cropy2),math.max(cropy1,cropy2);
    local cropW,cropH=cropR-cropL,cropB-cropT;
    l,r,t,b=l*cropW+cropL,r*cropW+cropL,t*cropH+cropT,b*cropH+cropT;
 
--  Apply texcord/size
    bar:SetTexCoord(l,r,t,b);
    bar:SetWidth(pw*((origL or origR) and math.abs(high-low) or 1));
    bar:SetHeight(ph*((origT or origB) and math.abs(high-low) or 1));
end

[Grimsin]

if you put the crop vars before the flip ones you dont HAVE to enter a flip entry. If you put them ahead of the crop vars you have to enter something for both flips or it trys to pass flip entrys to the crop entrys...

edit -- somthing else is wrong to the bars are not working at all with those changes.

edit-- okay so it has to do with the croping. when i set the bar with the function what exactly show it look like?
this is what it looks like right now. does work if i remove all the crop settings.
this is what it looks like and does not work.
addon:SetBarValue(self.ManaBar,0,mppcnt, true, false, 175, 50, 0 ,0);

hmm how do you bypass a var? ...? or _?

[Grimsin]

The cropping does not appear to work at all. It understands 1 and 0 and thats it. what kind of numbers do i need to enter? i found if i enter a - and a + it at lest shows the texture again but its not cropping it... ex:
addon:SetBarValue(self.ManaBar,0,mppcnt, true, false, -175, 50, -175, 50);

[SDPhantom]

Originally Posted by Grimsin if you put the crop vars before the flip ones you dont HAVE to enter a flip entry. If you put them ahead of the crop vars you have to enter something for both flips or it trys to pass flip entrys to the crop entrys... ... how do you bypass a var? ...? or _?

With a function like this, there are always going to be a group of parameters you don't need to use. It's up to the programmer to decide what order makes the most sense. The ordering makes no impact on the performance of the code. It really depends on how the function handles parameters, but with functions that have optional parameters in fixed positions and a parameter is missing, it always gets the value of nil. If you need to skip an optional parameter, in most cases you can pass nil to it.

Originally Posted by Grimsin when i set the bar with the function what exactly show it look like? this is what it looks like right now. does work if i remove all the crop settings. addon:SetBarValue(self.ManaBar,0,mppcnt, true, false, 175, 50, 0 ,0);

Originally Posted by Grimsin The cropping does not appear to work at all. It understands 1 and 0 and thats it. what kind of numbers do i need to enter? i found if i enter a - and a + it at lest shows the texture again but its not cropping it... ex: addon:SetBarValue(self.ManaBar,0,mppcnt, true, false, -175, 50, -175, 50);

The crop parameters use the same values in the same order as texture:SetTexCoord(). See line 44 of the function for a note on texcoord ranges.

I find it easier to understand when texcoords are written in fraction notation. This would have each x and y coordinate written as x/w and y/h. For example, your image file has the dimensions of 128x256. Say I wanted to grab a piece from it using two corners at coordinates (32,64) and (96,192). This could be written the following ways.

Fraction notation:

(32/128,96/128,64/256,192/256)

Decimal notation:

(0.25,0.75,0.25,0.75)

This would end up with the function call looking something like this.

addon:SetBarValue(self.ManaBar,0,mppcnt,true,false,32/128,96/128,64/256,192/256);

[Grimsin]

<you see a light bulb appear above Grimsin's head> its all much clearer now. Heh i wish someone had explained texcoords like that on the wiki because it would have made a lot more sense there to.

Now to figure out what direction things are going. I already noticed strange reactions to my settings...

edit--the light has flickered out... umm im not even sure how to explain whats happening... its putting the texture all over the place... doing strange things. It moves it up and down and cuts it and chops it weird ways and what in the world? It kind of looks like if we crop the texture that it then needs to have new setpoints as well im not sure on this. Alright what would you put in order to cut the top 150 pixels off a 256 pixel texture with the code you posted? i only need to set the cropy1 or cropy2 right? and 1 and 2 stands for the top of the texture and the bottom?

[SDPhantom]

It's the same order as texture:SetTexCoord(). The numbers are in order of Left, Right, Top, and Bottom. These numbers are expressed as a decimal in the range of 0-1. If you look at your image as a coordinate system, the origin is in the upper left corner, top left is (0,0). The coordinates approach (1,1) as you move toward the lower right corner.

Now, to move the top in 150 pixels, you need to set Top to 150/256, Bottom needs to remain at 1. If you're not cropping left/right, leave those values at 0 and 1 respectively. There are also two things you should modify as well, when you do this, the rendered texture is no longer 256px, it'll be more like 106px. You should change the frame and initial texture object heights to reflect this, and don't forget to use the same coordinates to set the background's texcoord or it'll look a but funky.



An example of applying this texcoord to the render function.

addon:SetBarValue(self.ManaBar,0,mppcnt,true,false,0,1,150/256,1);

Be sure to do this to the background texture too.

texture:SetTexCoord(0,1,150/256,1);

Edit:
Oh, right... and when you set the texcoord on the background, be sure to flip the first two values if the bar is to be flipped.

texture:SetTexCoord(1,0,150/256,1);

Originally Posted by Grimsin i only need to set the cropy1 or cropy2 right? and 1 and 2 stands for the top of the texture and the bottom?

In all honesty, the function was written to not allow you to flip the texture from the crop coordinates. So for the xy pairs, it would select the lowest from the x pair for left, the highest for right. From the y pair, the lowest would be selected for top and highest for bottom. Although, if you pass nil to any coordinate value, it would substitute for what would be the default for that position. For example, x1 is sent nil while x2 is sent 0.5, the pair result would be 0 and 0.5. If x1 was 0.5 and x2 was nil, the pair would result as 0.5 and 1. The same would happen for y1 and y2.

[Grimsin]

so to shave the top and bottom do i need to make the second variable passed reflect the changes of the first? so if i do the 150/256 then the last entry would be like -10/106? er wait it would be more like 1/10 wouldnt it

[SDPhantom]

Originally Posted by Grimsin so to shave the top and bottom do i need to make the second variable passed reflect the changes of the first? so if i do the 150/256 then the last entry would be like -10/106? er wait it would be more like 1/10 wouldnt it

No, it would be more like 150/256 to take 150 off the top and the second y value would be something like 246/256... which is (256-10)/256.