Need help with SpellBook taint

[LanceDH]

I'm currently working on an addon that interracts with the SpellBook but I seem to taint it which causes errors when trying to cast a spell from the book (because CastSpell() is protected).

The idea is that I have a button showing a spell, and when clicked it opens the SpellBook to the page where the spell is located.
As far as I've seen there's no function for this so I basically go through all the tabs, pages and slots to find the correct spell.
The issue is that this, and even just toggling the SpellBook, will taint it.
So I'm trying to figure out if there's a way I can fix it.
Full code can be found on my GitHub

Once the button is pressed the only relevant code is the following:
(line 122- 141)
It get the name of the spell, then calls the function to scout through the spellbook for that name.
If it's found it plays a highlight animation, else it just opens on the default page.
And then it opens the SpellBook if it's not open yet.

elseif (self.unlockType == UNLOCKTYPE_SPELL) then
    local spellName = self.SpellName:GetText();
    local success, slot = OpenSpellBookAtSpell(spellName);
    if success then
        ILW_SpellBookHighlight:ClearAllPoints();
        ILW_SpellBookHighlight:SetPoint("TOPLEFT", slot, "TOPRIGHT");
        ILW_SpellBookHighlight:Show();
        ILW_SpellBookHighlight.increasing = true;
        ILW_SpellBookHighlight:SetAlpha(0); 
    else
        print("|cFFFFD100ILWhat:|r |cFFFF5555" .. spellName .." is not in the spellbook. It might be hidden.|r");
        SpellBookSkillLineTab_OnClick(_G["SpellBookSkillLineTab2"]);
        while (SpellBookPrevPageButton:IsEnabled()) do
            SpellBookPrevPageButton_OnClick();
        end
    end
        
    if (not SpellBookFrame:IsShown()) then
        ToggleSpellBook(BOOKTYPE_SPELL);
    end

The function to scout works like this:
(line 47 - 105)
It simply starts at the first tab, checks all the slots until it reaches an empty one or the last one.
Goes through the different pages on that tab until it's done and goes to the second tab.
if it finds the spell it stays on that page and returns success and the slot (to archor the highlight to)

local function OpenSpellBookAtSpell(searchName)
    local tabNr = 1;
    local maxTabs = 2;
    local buttonNr = 1;
    local buttonPerPage = 12;
    local spellName = "";
    local firsTimeInTab = false;
    
    SpellBookSkillLineTab_OnClick(_G["SpellBookSkillLineTab"..tabNr]);
    while (tabNr <= maxTabs) do
    
        -- go to the first page 
        if (not firsTimeInTab) then
            while (SpellBookPrevPageButton:IsEnabled()) do
                SpellBookPrevPageButton_OnClick();
            end
            firsTimeInTab = true;
        end
    
        -- if target slot has a spell in it
        if _G["SpellButton"..buttonNr.."SpellName"] ~= nil and _G["SpellButton"..buttonNr.."SpellName"]:IsShown() then
            -- if the current tab still has unchecked spells
            if (buttonNr <= buttonPerPage) then
                
                spellName = _G["SpellButton"..buttonNr.."SpellName"]:GetText();
                
                if (spellName == searchName) then
                    -- Found the spell, end the world
                    return true, _G["SpellButton"..buttonNr];
                end
                
                buttonNr = buttonNr + 2;
 
                -- reached limit on uneven, go even
                -- Needed because slotNr goes L->R U->D while spells go U->D L->R
                if (buttonNr > 12 and buttonNr %2 == 1) then
                    buttonNr = 2;
                end
            end
        else -- else check for next page
            
            -- has next page, flip page
            if (SpellBookNextPageButton:IsEnabled() ) then
                
                SpellBookNextPageButton_OnClick();
                buttonNr = 1;
            else -- else next tab
                
                buttonNr = 1;
                tabNr = tabNr + 1;
                SpellBookSkillLineTab_OnClick(_G["SpellBookSkillLineTab"..tabNr]);
                firsTimeInTab = false;
            end         
        end 
    end
    
    return false;
    
end

The template for the buttons are in the XML file.
Template lines 15 to 136
Actual buttons at 242 - 300

So I'm trying to figure out if there is a way to prevent the taint, or if there's just no way to do it correctly.

[lightspark]

Not at home yet, can't run live tests, but here's my wild guess after I checked your code on GH... You have quite many Show/Hide calls, but you dun always check if character is in combat or not, you can't toggle frame visibility whilst in combat... You have to use InCombatLockdown() function to check whether it's safe to make those calls or not.

And I strongly recommend using taint log, it helps quite much...

[semlar]

I think your only chance of getting this to work correctly without breaking the spellbook is to create a secure button which executes a macro to /click the spellbook forward/back buttons to the proper page, because calling any of the spellbook functions directly is going to taint everything it touches.

That being said, why not just make it so people can drag the spell off the button you're displaying, rather than open the spellbook? It seems like an extra step, unless I'm not understanding what your addon is meant to do.

[LanceDH]

Originally Posted by lightspark Not at home yet, can't run live tests, but here's my wild guess after I checked your code on GH... You have quite many Show/Hide calls, but you dun always check if character is in combat or not, you can't toggle frame visibility whilst in combat... You have to use InCombatLockdown() function to check whether it's safe to make those calls or not. And I strongly recommend using taint log, it helps quite much...

It's not the best way to do things, but I have the 2main frames not work during combat and hide once you enter combat.
The other ones are (in theory) impossible to trigger without either of those 2 frames being shown.
I used UnitAffectingCombat("player") for it though. Achieves the same thing but might look into using the function you gave instead.
As for taint log, totally forgot that was a thing.

Originally Posted by semlar I think your only chance of getting this to work correctly without breaking the spellbook is to create a secure button which executes a macro to /click the spellbook forward/back buttons to the proper page, because calling any of the spellbook functions directly is going to taint everything it touches. That being said, why not just make it so people can drag the spell off the button you're displaying, rather than open the spellbook? It seems like an extra step, unless I'm not understanding what your addon is meant to do.

Yea as I was waiting for a reply I pretty much implemented the dragging as well.
I was already going to add that but the reason I wanted to have the SpellBook is because I also do things like open the dungeon journal, talent frame, glyph frame, .. which... I'm probably also tainting beyon belief though I don't think they call protected functions like the SpellBook does.
Another annoyance is that IsPassiveSpell("name") doesn't actually work correctly as it returns false for Tiger Strikes whish is a passive, probably because it triggers another spell with the same name that isn't a passive.
Not the biggest issue but just annoying and might require more work.

I'll check the taint log and see what comes up. worst case I'll have to live without it.


Edit:
Seems WoW just instantly taints any global variable in addons.
But as far as I understand my functions need to be global to call them in my XML code?
Or is there some other way to do this.

[SDPhantom]

Originally Posted by LanceDH But as far as I understand my functions need to be global to call them in my XML code?

Correct. Though it's one of many reasons why it's suggested to not use XML. You can do almost everything directly from Lua.

[LanceDH]

Originally Posted by SDPhantom Correct. Though it's one of many reasons why it's suggested to not use XML. You can do almost everything directly from Lua.

Well fk.
Here I've been programming addons in nothing but LUA thinking I'm not doing it the way I should.
And now I, for once, code one with XML..

[lightspark]

Originally Posted by LanceDH It's not the best way to do things, but I have the 2main frames not work during combat and hide once you enter combat. The other ones are (in theory) impossible to trigger without either of those 2 frames being shown. I used UnitAffectingCombat("player") for it though. Achieves the same thing but might look into using the function you gave instead. As for taint log, totally forgot that was a thing.

However, I managed to get one when I clicked ILW_SpellBookTab (button in spellbook) TWICE, not once, but twice, on first click I saw a warning from your addon in my chat, however, on second one I've got a taint (line #491, inside ToggleUnlockedPage function).

'ILW_UnlockContainer:Hide()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]:: in function 'Hide'
ILearnedWhat\ILearnedWhat-6.2b1.lua:491: in function <ILearnedWhat\ILearnedWhat.lua:486>
ILearnedWhat\ILearnedWhat-6.2b1.lua:504: in function <ILearnedWhat\ILearnedWhat.lua:503>

Originally Posted by LanceDH Seems WoW just instantly taints any global variable in addons. But as far as I understand my functions need to be global to call them in my XML code? Or is there some other way to do this.

Well, write it in pure Lua, safest approach possible.

One more thing. Their API is almost always safe, there are some exceptions though, but NEVER (almost never tbh, there are few exceptions too) use functions blizz implemented in Lua themselves, it almost always causes taints. Your taint you were talking about in OP was caused by usage of blizz' SpellBookSkillLineTab_* functions.

P.S. BTW, sorry, completely missed the point in my first comment, was a bit tired. Went full retard, realized it just now after a short nap,

[LanceDH]

Originally Posted by lightspark However, I managed to get one when I clicked ILW_SpellBookTab (button in spellbook) TWICE, not once, but twice, on first click I saw a warning from your addon in my chat, however, on second one I've got a taint (line #491, inside ToggleUnlockedPage function).

Had no clue :Hide() also caused errors in combat so can't say I 'protected' any of those.
I guess PLAYER_REGEN_DISABLED, where I hide everything when combat starts, happens before errors start happening.
Will have to fix that now that I know.

Originally Posted by lightspark Well, write it in pure Lua, safest approach possible. One more thing. Their API is almost always safe, there are some exceptions though, but NEVER (almost never tbh, there are few exceptions too) use functions blizz implemented in Lua themselves, it almost always causes taints. Your taint you were talking about in OP was caused by usage of blizz' SpellBookSkillLineTab_* functions. P.S. BTW, sorry, completely missed the point in my first comment, was a bit tired. Went full retard, realized it just now after a short nap,

Wouldn't it be worth it to create frames in XML and use SetScript with local functions in LUA?
Or does the XML itself cause issues?
Having done it both ways now I must say I find XML to make the base for frames a lot easier to use and keep track of things, and doesn't clutter my LUA files as much.

[semlar]

Just wanted to clear something up, since people seem a little confused as to what taint actually is.

Anything an addon does is considered "tainted". Its purpose is to prevent an addon from tricking a blizzard function into executing code that it wouldn't normally be able to do directly, or otherwise influence the result of a protected function.

So, when we call a function like SpellBookPrevPageButton_OnClick, which calls SpellBookFrame_Update, which calls SpellBook_UpdatePlayerTab, which calls SpellBookFrame_UpdateSpells, which calls SpellButton_UpdateButton, which sets "self.offSpecID", which is then read by SpellButton_OnClick when you click the spell button, it directly influences whether or not "CastSpell" is called by the interface.

Since we've "tainted" the execution path by calling a function which ultimately affected a protected function, the interface prevents the protected function from being called.

When you create a global variable, it's tainted because it wasn't created by blizzard's "trusted" code, it was created by your addon, which is untrustworthy. If something in the interface were to read that variable it would taint its execution path.

This doesn't mean that global variables are bad, just that you need to take care not to name them something that would ever be referenced by anything else.

[lightspark]

Originally Posted by LanceDH Had no clue :Hide() also caused errors in combat so can't say I 'protected' any of those. I guess PLAYER_REGEN_DISABLED, where I hide everything when combat starts, happens before errors start happening. Will have to fix that now that I know.

Unfortunately, many things cause taints, some things can't be used by 3rd party, others are restricted to not-in-combat times. Taken from InCombatLockdown function description. Read description on that page, it says what you can't do to a frame.

While in combat: Programatic modification of macros or bindings is not allowed. Some things can't be done on "Protected" frames, their parents, or any frame they are anchored to. These include, but are not restricted to: Hiding the frame using Hide widget method. Showing the frame using Show widget method. Changing the frame's attributes (custom attributes are used by Blizzard secure templates to set up their behavior). Moving the frame by resetting frame's points or anchors (movements initiated by user are still allowed while in combat).

Originally Posted by LanceDH Wouldn't it be worth it to create frames in XML and use SetScript with local functions in LUA? Or does the XML itself cause issues? Having done it both ways now I must say I find XML to make the base for frames a lot easier to use and keep track of things, and doesn't clutter my LUA files as much.

Sure, XML-templates are quite handy, XML is a markup language for a reason. However, debugging things that happens there isn't cool, and you have to expose quite much, it's never 100% safe T_T I also liked this approach in the past, but it's really leaky...

If you need to use same template many times, instead creating XML-template, create constructor for this widget in Lua. It's easier to debug, it's more flexible and more secure.

P.S. And semlar, as always, explained everything nicely. But I, being a lazy ass, said to almost never use blizz stuff, if they implemented it in Lua. That's almost always true for their OnClick handlers and quite many other functions. I just think it's safest, yet dumbest approach, works for me Ofc there are few handy exceptions, which are safe to use.

[LanceDH]

Originally Posted by semlar Just wanted to clear something up, since people seem a little confused as to what taint actually is. Anything an addon does is considered "tainted". Its purpose is to prevent an addon from tricking a blizzard function into executing code that it wouldn't normally be able to do directly, or otherwise influence the result of a protected function.

I always think of taint as Zerg creep.
You send your Zerg into Blizzard's base to do something and it just leaves creep all over the place.
Then Blizzard sends an SCV ro so something, sees the creep, sounds the alarms and the thing gets quarantined.

So what you're saying is, no matter how hard you try to clean your Zerg, it's always going to leave creep behind?
In other words, it's impossible to do what I'm trying to do without blizzard code falling appart, and should just stick with dragging the spells from my own buttons?

Originally Posted by lightspark However, debugging things that happens there isn't cool

Won't argue with that. Forgot something in your XML? Well I'm just going to tell you something went wrong in your LUA instead.

Edit:
As for everything LUA, this is unfinished and uncleaned code but I think we can all agree it burns people's eyes out.

local function CreatePlayFrame()
 
    GwentAddon.draggingOver.timer = 0
    local GwentUpdater = CreateFrame("frame", "GwentUpdater", UIParent)
    
    GwentUpdater:SetScript("OnUpdate", function(self,elapsed) 
        
        
        if GwentAddon.cards.draggedCard == nil then return end
        
        
        GwentAddon.draggingOver.timer = GwentAddon.draggingOver.timer + elapsed
        if GwentAddon.draggingOver.timer >= 0.05 then
            GwentAddon.draggingOver.list = nil
        GwentAddon.draggingOver.card = nil
        GwentAddon.draggingOver.mouseX, GwentAddon.draggingOver.mouseY = 0, 0
            
            GwentAddon.draggingOver.list, GwentAddon.draggingOver.area = GwentAddon:GetCardlistMouseOver()
            GwentAddon.draggingOver.mouseX, GwentAddon.draggingOver.mouseY = GetCursorPosition()
            
            if GwentAddon.draggingOver.area == nil then 
                GwentAddon.draggingOver.timer = 0
                return
            end
 
            if GwentAddon:IsRightTypeForArea(GwentAddon.cards.draggedCard, GwentAddon.draggingOver.area.type) and IsSpyArea(GwentAddon.cards.draggedCard.data.ability, GwentAddon.draggingOver.area)    then
                for k, card in pairs(GwentAddon.draggingOver.list) do
                    if GwentAddon.cards:UpdateCardSpaceing(card, GwentAddon.draggingOver.mouseX, GwentAddon.draggingOver.mouseY) then
                        GwentAddon.draggingOver.card = card
                    end
                end
                GwentAddon:PlaceCardsOnFrame(GwentAddon.draggingOver.list, GwentAddon.draggingOver.area)
            end
            GwentAddon.draggingOver.timer = 0
        end
        end)
    
    
    
        local PlayFrame = CreateFrame("frame", addonName.."PlayFrame", UIParent)
    PlayFrame:SetHeight(780)
    PlayFrame:SetWidth(1200)
    -- PlayFrame:SetAlpha(0.7)
    PlayFrame:SetMovable(true)
    PlayFrame:SetPoint("Center", 0, 0)
    PlayFrame:RegisterForDrag("LeftButton")
    PlayFrame:SetScript("OnDragStart", PlayFrame.StartMoving )
    PlayFrame:SetScript("OnDragStop", PlayFrame.StopMovingOrSizing)
    PlayFrame:EnableMouse(true)
    GwentAddon.frameBaseLevel = PlayFrame:GetFrameLevel()
    local fbl = GwentAddon.frameBaseLevel
    
    PlayFrame:SetBackdrop({bgFile = nil,
      edgeFile = "Interface\\ACHIEVEMENTFRAME\\UI-Achievement-WoodBorder",
      tileSize = 32, edgeSize = 64,
      insets = { left = 0, right = 0, top = 0, bottom = 0 }
      })
    
 
    local bSat = 0.6
    
    PlayFrame.left = PlayFrame:CreateTexture(addonName.."PlayFrame_L")
    PlayFrame.left:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Left")
    PlayFrame.left:SetTexCoord(0, 1, 0, .87)
    PlayFrame.left:SetDrawLayer("ARTWORK", 0)
    PlayFrame.left:SetWidth(16)
    PlayFrame.left:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.left:SetPoint("topleft", PlayFrame, "topleft", 15, -25)
    PlayFrame.left:SetPoint("bottomleft", PlayFrame, "bottomleft", 15, 25)
    
    PlayFrame.right = PlayFrame:CreateTexture(addonName.."PlayFrame_R")
    PlayFrame.right:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Left")
    PlayFrame.right:SetTexCoord(1, 0, 0, .87)
    PlayFrame.right:SetDrawLayer("ARTWORK", 0)
    PlayFrame.right:SetWidth(16)
    PlayFrame.right:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.right:SetPoint("topright", PlayFrame, "topright", -15, -25)
    PlayFrame.right:SetPoint("bottomright", PlayFrame, "bottomright", -15, 25)
    
    PlayFrame.bottom = PlayFrame:CreateTexture(addonName.."PlayFrame_B")
    PlayFrame.bottom:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Top")
    PlayFrame.bottom:SetTexCoord(0, .87, 1, 0)
    PlayFrame.bottom:SetDrawLayer("ARTWORK", 0)
    PlayFrame.bottom:SetHeight(16)
    PlayFrame.bottom:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.bottom:SetPoint("bottomleft", PlayFrame, "bottomleft", 30, 15)
    PlayFrame.bottom:SetPoint("bottomright", PlayFrame, "bottomright", -30, 15)
    
    PlayFrame.top = PlayFrame:CreateTexture(addonName.."PlayFrame_T")
    PlayFrame.top:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Top")
    PlayFrame.top:SetTexCoord(0, .87, 0, 1)
    PlayFrame.top:SetDrawLayer("ARTWORK", 0)
    PlayFrame.top:SetHeight(16)
    PlayFrame.top:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.top:SetPoint("topleft", PlayFrame, "topleft", 30, -15)
    PlayFrame.top:SetPoint("topright", PlayFrame, "topright", -30, -15)
    
    PlayFrame.topleft = PlayFrame:CreateTexture(addonName.."PlayFrame_TL")
    PlayFrame.topleft:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Joint")
    PlayFrame.topleft:SetTexCoord(1, 0, 1, 0)
    PlayFrame.topleft:SetDrawLayer("ARTWORK", 2)
    PlayFrame.topleft:SetWidth(32)
    PlayFrame.topleft:SetHeight(32)
    PlayFrame.topleft:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.topleft:SetPoint("topleft", PlayFrame, 10, -10)
    
    PlayFrame.topleftDetail = PlayFrame:CreateTexture(addonName.."PlayFrame_TLDetail")
    PlayFrame.topleftDetail:SetTexture("Interface\\AchievementFrame\\UI-Achievement-WoodBorder-Corner")
    PlayFrame.topleftDetail:SetTexCoord(0, 1, 0, 1)
    PlayFrame.topleftDetail:SetDrawLayer("ARTWORK", 1)
    PlayFrame.topleftDetail:SetWidth(64)
    PlayFrame.topleftDetail:SetHeight(64)
    PlayFrame.topleftDetail:SetPoint("topleft", PlayFrame, 3, -2)
    
    PlayFrame.topright = PlayFrame:CreateTexture(addonName.."PlayFrame_TR")
    PlayFrame.topright:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Joint")
    PlayFrame.topright:SetTexCoord(0, 1, 1, 0)
    PlayFrame.topright:SetDrawLayer("ARTWORK", 2)
    PlayFrame.topright:SetWidth(32)
    PlayFrame.topright:SetHeight(32)
    PlayFrame.topright:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.topright:SetPoint("topright", PlayFrame, -10, -10)
    
    PlayFrame.toprightDetail = PlayFrame:CreateTexture(addonName.."PlayFrame_TRDetail")
    PlayFrame.toprightDetail:SetTexture("Interface\\AchievementFrame\\UI-Achievement-WoodBorder-Corner")
    PlayFrame.toprightDetail:SetTexCoord(1, 0, 0, 1)
    PlayFrame.toprightDetail:SetDrawLayer("ARTWORK", 1)
    PlayFrame.toprightDetail:SetWidth(64)
    PlayFrame.toprightDetail:SetHeight(64)
    PlayFrame.toprightDetail:SetPoint("topright", PlayFrame, -3, -2)
    
    PlayFrame.bottomleft = PlayFrame:CreateTexture(addonName.."PlayFrame_BL")
    PlayFrame.bottomleft:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Joint")
    PlayFrame.bottomleft:SetTexCoord(1, 0, 0, 1)
    PlayFrame.bottomleft:SetDrawLayer("ARTWORK", 2)
    PlayFrame.bottomleft:SetWidth(32)
    PlayFrame.bottomleft:SetHeight(32)
    PlayFrame.bottomleft:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.bottomleft:SetPoint("bottomleft", PlayFrame, 10, 10)
    
    PlayFrame.bottomleftDetail = PlayFrame:CreateTexture(addonName.."PlayFrame_BLDetail")
    PlayFrame.bottomleftDetail:SetTexture("Interface\\AchievementFrame\\UI-Achievement-WoodBorder-Corner")
    PlayFrame.bottomleftDetail:SetTexCoord(0, 1, 1, 0)
    PlayFrame.bottomleftDetail:SetDrawLayer("ARTWORK", 1)
    PlayFrame.bottomleftDetail:SetWidth(64)
    PlayFrame.bottomleftDetail:SetHeight(64)
    PlayFrame.bottomleftDetail:SetPoint("bottomleft", PlayFrame, 3, 2)
    
    PlayFrame.bottomright = PlayFrame:CreateTexture(addonName.."PlayFrame_BR")
    PlayFrame.bottomright:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Joint")
    PlayFrame.bottomright:SetTexCoord(0, 1, 0, 1)
    PlayFrame.bottomright:SetDrawLayer("ARTWORK", 2)
    PlayFrame.bottomright:SetWidth(32)
    PlayFrame.bottomright:SetHeight(32)
    PlayFrame.bottomright:SetVertexColor(bSat, bSat, bSat)
    PlayFrame.bottomright:SetPoint("bottomright", PlayFrame, -10, 10)
    
    PlayFrame.bottomrightDetail = PlayFrame:CreateTexture(addonName.."PlayFrame_BRDetail")
    PlayFrame.bottomrightDetail:SetTexture("Interface\\AchievementFrame\\UI-Achievement-WoodBorder-Corner")
    PlayFrame.bottomrightDetail:SetTexCoord(1, 0, 1, 0)
    PlayFrame.bottomrightDetail:SetDrawLayer("ARTWORK", 1)
    PlayFrame.bottomrightDetail:SetWidth(64)
    PlayFrame.bottomrightDetail:SetHeight(64)
    PlayFrame.bottomrightDetail:SetPoint("bottomright", PlayFrame, -3, 2)
 
    PlayFrame.header = CreateFrame("frame", addonName.."PlayFrameHeader", PlayFrame)
    PlayFrame.header:SetHeight(106)
    PlayFrame.header:SetWidth(726)
    PlayFrame.header:SetPoint("bottom", PlayFrame ,"top", 0, -41)
    PlayFrame.header:Hide()
    
    
    PlayFrame.headerLeft = PlayFrame.header:CreateTexture(addonName.."PlayFrameHeaderLeft")
    PlayFrame.headerLeft:SetTexture("Interface\\AchievementFrame\\UI-Achievement-Header")
    PlayFrame.headerLeft:SetTexCoord(0, 1, 0, 0.4140625)
    PlayFrame.headerLeft:SetDrawLayer("ARTWORK", 0)
    PlayFrame.headerLeft:SetWidth(512)
    PlayFrame.headerLeft:SetHeight(106)
    PlayFrame.headerLeft:SetPoint("bottomleft", PlayFrame.header)
    
    PlayFrame.headerRight = PlayFrame.header:CreateTexture(addonName.."PlayFrameHeaderRight")
    PlayFrame.headerRight:SetTexture("Interface\\AchievementFrame\\UI-Achievement-Header")
    PlayFrame.headerRight:SetTexCoord(0, 0.419921875, 0.4140625, 0.8046875)
    PlayFrame.headerRight:SetDrawLayer("ARTWORK", 0)
    PlayFrame.headerRight:SetWidth(214)
    PlayFrame.headerRight:SetHeight(100)
    PlayFrame.headerRight:SetPoint("bottomright", PlayFrame.header, 0, -6)
    
    PlayFrame.closeButton = CreateFrame("Button", addonName.."PlayFrameCloseButton", PlayFrame, "UIPanelCloseButton")
    PlayFrame.closeButton:SetFrameLevel(fbl + 1)
    -- PlayFrame.closeButton:SetHitRectInsets(4, 4, 4, 4)
    PlayFrame.closeButton:SetPoint("topright", PlayFrame, 3, 4)
    PlayFrame.closeButton:Show()
    PlayFrame.closeButton:SetScript("OnClick",  function() 
        PlayFrame:Hide()
    end)
    
    CreateCardTooltip(PlayFrame)
    --CreateWeatherArea(PlayFrame)
    local sidebar = CreateSidebar(PlayFrame)
    local playfield = CreatePlayField(PlayFrame)
    
    PlayFrame.graveyard = CreateFrame("frame", addonName.."Graveyard", PlayFrame)
    PlayFrame.graveyard:SetHeight(GwentAddon.NUM_CARD_HEIGHT*2)
    PlayFrame.graveyard:SetFrameLevel(fbl + 6)
    PlayFrame.graveyard:SetPoint("left", playfield ,"left", 0, 0)
    PlayFrame.graveyard:SetPoint("right", playfield ,"right", 0, 0)
    PlayFrame.graveyard:Hide()
    
    PlayFrame.graveyard.bg = PlayFrame.graveyard:CreateTexture(addonName.."GraveyardBG")
    PlayFrame.graveyard.bg:SetTexture("Interface\\Cooldown\\LoC-ShadowBG") --:SetTexture(TEXTURE_CARD_BG)
    PlayFrame.graveyard.bg:SetDrawLayer("background", 0)
    PlayFrame.graveyard.bg:SetPoint("topleft", PlayFrame.graveyard)
    PlayFrame.graveyard.bg:SetPoint("bottomright", PlayFrame.graveyard)
    
    PlayFrame.graveyard.cardContainer = CreateFrame("frame", addonName.."GraveyardContainer", PlayFrame.graveyard)
    PlayFrame.graveyard.cardContainer:SetFrameLevel(fbl + 7)
    PlayFrame.graveyard.cardContainer:SetPoint("center", PlayFrame.graveyard)
    PlayFrame.graveyard.cardContainer:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    GwentAddon.areas.graveyard = PlayFrame.graveyard
    
    
    PlayFrame.weather = CreateFrame("frame", addonName.."Weather", playfield)
    --GwentAddon.areas.playerHand = PlayFrame.playerHand
    PlayFrame.weather:SetPoint("right", sidebar, "right", -30, 0)
    PlayFrame.weather:SetHeight(GwentAddon.NUM_CARD_HEIGHT+4)
    PlayFrame.weather:SetWidth(GwentAddon.NUM_CARD_WIDTH * 3+4)
    
    GwentAddon.areas.weather = PlayFrame.weather
    
    PlayFrame.weather.bg = PlayFrame.weather:CreateTexture(addonName.."WeatherBG")
    PlayFrame.weather.bg:SetTexture(TEXTURE_CARD_BG)
    PlayFrame.weather.bg:SetDrawLayer("background", 1)
    PlayFrame.weather.bg:SetPoint("topleft", PlayFrame.weather)
    PlayFrame.weather.bg:SetPoint("bottomright", PlayFrame.weather)
    
    GwentAddon:CreateInnerShadow(PlayFrame.weather, 0.5)
      
    PlayFrame.weather.cardContainer = CreateFrame("frame", addonName.."WeatherContainer", PlayFrame.weather)
    PlayFrame.weather.cardContainer:SetPoint("center", PlayFrame.weather)
    PlayFrame.weather.cardContainer:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    
    
    PlayFrame.player = CreatePlayerDisplay(sidebar, 0, -GwentAddon.NUM_CARD_HEIGHT *2, "player")
    PlayFrame.player.nametag:SetText(GetUnitName("player", false))
    GwentAddon.playerLives.texture1 = PlayFrame.player.life1
    GwentAddon.playerLives.texture2 = PlayFrame.player.life2
    
    -- player hand
    PlayFrame.playerHand = CreateFrame("frame", addonName.."playerHand", playfield)
    GwentAddon.areas.playerHand = PlayFrame.playerHand
    PlayFrame.playerHand:SetPoint("bottom", playfield, "bottom", -30, 10)
    PlayFrame.playerHand:SetHeight(GwentAddon.NUM_CARD_HEIGHT+4)
    PlayFrame.playerHand:SetWidth(GwentAddon.NUM_CARD_WIDTH * 10+4)
    
    GwentAddon:CreateInnerShadow(PlayFrame.playerHand, 0.5)
    -- PlayFrame.playerHand:SetBackdrop({bgFile = TEXTURE_CARD_DARKEN,
      -- edgeFile = nil,
      -- tileSize = 0, edgeSize = 16,
      -- insets = { left = 0, right = 0, top = 0, bottom = 0 }
      -- })
      
    PlayFrame.playerHand.cardContainer = CreateFrame("frame", addonName.."playerHandContainer", PlayFrame.playerHand)
    PlayFrame.playerHand.cardContainer:SetPoint("center", PlayFrame.playerHand)
    PlayFrame.playerHand.cardContainer:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
      
    PlayFrame.player.deck = CreateFrame("frame", addonName.."baseDeck", playfield)
    PlayFrame.player.deck:SetPoint("bottomright", playfield, "bottomright", -50, 50)
    PlayFrame.player.deck:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    PlayFrame.player.deck:SetWidth(GwentAddon.NUM_CARD_WIDTH)
    GwentAddon:CreateOuterCardShadow(PlayFrame.player.deck)
    
    PlayFrame.player.decktex = PlayFrame.player.deck:CreateTexture(addonName.."baseDeckBack")
    PlayFrame.player.decktex:SetDrawLayer("ARTWORK", 0)
    PlayFrame.player.decktex:SetTexture(TEXTURE_CUSTOM_PATH.."BackTotallyLegit")
    PlayFrame.player.decktex:SetTexCoord(0, 1, 0, 464/512)
    PlayFrame.player.decktex:SetPoint("topleft", PlayFrame.player.deck)
    PlayFrame.player.decktex:SetPoint("bottomright", PlayFrame.player.deck)
    
    PlayFrame.player.leader = CreateFrame("frame", addonName.."playerHero", sidebar)
    PlayFrame.player.leader:SetPoint("bottomleft", sidebar, "bottomleft", 50, 50)
    PlayFrame.player.leader:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    PlayFrame.player.leader:SetWidth(GwentAddon.NUM_CARD_WIDTH)
    PlayFrame.player.leader:SetScript("OnEnter", function(c) GwentAddon:SetCardTooltip(GwentAddon.lists.playDeck.leader) end)
    PlayFrame.player.leader:SetScript("OnLeave", function(c) GwentAddon.playFrame.cardTooltip:Hide() end)
    PlayFrame.player.leader:SetScript("OnMouseUp", function(c) 
                    -- only allow during player turn and when the it's not used yet (mainly for chat spam)
                    if GwentAddon.currentState == GwentAddon.states.playerTurn and not GwentAddon.lists.playDeck.leader.used then
                        PlayFrame.player.leaderTex:SetVertexColor(0.5, 0.5, 0.5)
                        SendAddonMessage(addonName, ""..GwentAddon.messages.leader..GwentAddon.lists.playDeck.leader.data.Id.."#1", "whisper" , GwentAddon.challengerName)
                        GwentAddon.lists.playDeck.leader.used = true
                    end
                end)
    
    
    GwentAddon:CreateOuterCardShadow(PlayFrame.player.leader)
    
    PlayFrame.player.leaderTex = PlayFrame.player.leader:CreateTexture(addonName.."playerHeroTex")
    PlayFrame.player.leaderTex:SetDrawLayer("ARTWORK", 0)
    PlayFrame.player.leaderTex:SetTexture(TEXTURE_CUSTOM_PATH.."BackTotallyLegit")
    PlayFrame.player.leaderTex:SetTexCoord(0, 1, 0, 464/512)
    PlayFrame.player.leaderTex:SetVertexColor(1, 1, 1)
    PlayFrame.player.leaderTex:SetPoint("topleft", PlayFrame.player.leader)
    PlayFrame.player.leaderTex:SetPoint("bottomright", PlayFrame.player.leader)
    
    
    --GwentAddon:CreateInnerShadow(PlayFrame.player.deck, 0.5)
    
    PlayFrame.player.graveyard = CreateFrame("frame", addonName.."playerGY", playfield)
    PlayFrame.player.graveyard:SetPoint("right", PlayFrame.player.deck, "left", -30, 0)
    PlayFrame.player.graveyard:SetFrameLevel(fbl+2)
    PlayFrame.player.graveyard:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    PlayFrame.player.graveyard:SetWidth(GwentAddon.NUM_CARD_WIDTH)
    PlayFrame.player.graveyard:SetScript("OnMouseUp", function(c) 
                    if PlayFrame.graveyard:IsShown() then
                        PlayFrame.graveyard:Hide()
                    else
                        PlayFrame.graveyard:Show()
                    end
                end)
    --GwentAddon:CreateInnerShadow(PlayFrame.player.graveyard, 0.5)
    GwentAddon:CreateOuterCardShadow(PlayFrame.player.graveyard)
    
    -- PlayFrame.player.graveyardCard = CreateFrame("frame", addonName.."playerGYCard", PlayFrame.player.graveyard)
    -- PlayFrame.player.graveyardCard:SetPoint("topleft", PlayFrame.player.graveyard)
    -- PlayFrame.player.graveyardCard:SetPoint("bottomright", PlayFrame.player.graveyard)
    -- PlayFrame.player.graveyardCard:SetFrameLevel(fbl+2)
    -- GwentAddon:CreateOuterCardShadow(PlayFrame.player.graveyardCard)
    -- PlayFrame.player.graveyardCard:Hide()
    
    PlayFrame.player.graveyardTex = PlayFrame.player.graveyard:CreateTexture(addonName.."playerGYTex")
    PlayFrame.player.graveyardTex:SetDrawLayer("ARTWORK", 3)
    PlayFrame.player.graveyardTex:SetTexture(TEXTURE_CUSTOM_PATH.."Graveyard")
    PlayFrame.player.graveyardTex:SetTexCoord(0, 1, 0, 464/512)
    PlayFrame.player.graveyardTex:SetVertexColor(1, 1, 1)
    PlayFrame.player.graveyardTex:SetPoint("topleft", PlayFrame.player.graveyard)
    PlayFrame.player.graveyardTex:SetPoint("bottomright", PlayFrame.player.graveyard)
    
    --PlayFrame.player.graveyardTex:Hide()
      
    -- player siege
    -- PlayFrame.playerSiege = CreateCardArea("playerSiege", PlayFrame, TEXTURE_TYPE_SIEGE, TEXTURE_WEATHER_RAIN)
    -- PlayFrame.playerSiege.type = "siege"
    -- PlayFrame.playerSiege.isEnemy = false
    -- GwentAddon.areas.playerSiege = PlayFrame.playerSiege
    -- PlayFrame.playerSiege:SetPoint("bottom", PlayFrame.playerHand, "top", 0, 6) 
    -- player ranged
    -- PlayFrame.playerRanged = CreateCardArea("playerRanged", PlayFrame, TEXTURE_TYPE_RANGED, TEXTURE_WEATHER_FOG)
    -- PlayFrame.playerRanged.type = "ranged"
    -- PlayFrame.playerRanged.isEnemy = false
    -- GwentAddon.areas.playerRanged = PlayFrame.playerRanged
    -- PlayFrame.playerRanged:SetPoint("bottom", PlayFrame.playerSiege, "top", 0, 6)  
    -- player melee
    -- PlayFrame.playerMelee = CreateCardArea("playerMelee", PlayFrame, TEXTURE_TYPE_MELEE, TEXTURE_WEATHER_FROST)
    -- PlayFrame.playerMelee.type = "melee"
    -- PlayFrame.playerMelee.isEnemy = false
    -- GwentAddon.areas.playerMelee = PlayFrame.playerMelee
    -- PlayFrame.playerMelee:SetPoint("bottom", PlayFrame.playerRanged, "top", 0, 6)
    
    
    
    ------------------------------------------------------------------------------
    
    -- player pass button
    PlayFrame.passButton = CreateFrame("button", addonName.."PlayFrame_PassButton", PlayFrame, "UIPanelButtonTemplate")
    PlayFrame.passButton:SetPoint("bottomleft", PlayFrame.player.details, "topleft", 5, 10)
    PlayFrame.passButton:SetFrameLevel(fbl+2)
    PlayFrame.passButton:SetSize(100, 25)
    PlayFrame.passButton:SetText("Pass")
    PlayFrame.passButton:SetScript("OnClick", PassTurn) 
    
    -- player discard button
    PlayFrame.discardButton = CreateFrame("button", addonName.."PlayFrame_DiscardButton", PlayFrame, "UIPanelButtonTemplate")
    PlayFrame.discardButton:SetPoint("bottomleft", PlayFrame.playerHand, "bottomright", 15, 10)
    PlayFrame.discardButton:SetFrameLevel(fbl+2)
    PlayFrame.discardButton:SetSize(100, 25)
    PlayFrame.discardButton:SetText("Redraw")
    PlayFrame.discardButton:SetScript("OnClick", function() GwentAddon.cards:RedrawSelectedCards() end) 
    PlayFrame.discardButton:Hide()
    
    
    
    -- enemy hand
    PlayFrame.enemyHand = CreateFrame("frame", addonName.."PlayFrame_EnemyHand", playfield)
    GwentAddon.areas.enemyHand = PlayFrame.enemyHand
    PlayFrame.enemyHand:SetPoint("top", playfield, "top", -30, -10)
    PlayFrame.enemyHand:SetHeight(GwentAddon.NUM_CARD_HEIGHT+4)
    PlayFrame.enemyHand:SetWidth(GwentAddon.NUM_CARD_WIDTH * 10+4)
    GwentAddon:CreateInnerShadow(PlayFrame.enemyHand, 0.5)
    -- PlayFrame.enemyHand:SetBackdrop({bgFile = TEXTURE_CARD_DARKEN,
      -- edgeFile = nil,
      -- tileSize = 0, edgeSize = 16,
      -- insets = { left = 0, right = 0, top = 0, bottom = 0 }
      -- })
      
    PlayFrame.enemyHand.cardContainer = CreateFrame("frame", addonName.."EnemyHandContainer", PlayFrame.enemyHand)
    PlayFrame.enemyHand.cardContainer:SetPoint("center", PlayFrame.enemyHand)
    PlayFrame.enemyHand.cardContainer:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    
    PlayFrame.enemy = CreatePlayerDisplay(sidebar, 0, GwentAddon.NUM_CARD_HEIGHT *2, "player")
    GwentAddon.enemyLives.texture1 = PlayFrame.enemy.life1
    GwentAddon.enemyLives.texture2 = PlayFrame.enemy.life2
    
    PlayFrame.enemy.deck = CreateFrame("frame", addonName.."EnemyDeck", playfield)
    PlayFrame.enemy.deck:SetPoint("topright", playfield, "topright", -50, -50)
    PlayFrame.enemy.deck:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    PlayFrame.enemy.deck:SetWidth(GwentAddon.NUM_CARD_WIDTH)
    GwentAddon:CreateOuterCardShadow(PlayFrame.enemy.deck)
    
    PlayFrame.enemy.decktex = PlayFrame.enemy.deck:CreateTexture(addonName.."EnemyDeckBack")
    PlayFrame.enemy.decktex:SetDrawLayer("ARTWORK", 0)
    PlayFrame.enemy.decktex:SetTexture(TEXTURE_CUSTOM_PATH.."BackTotallyLegit")
    PlayFrame.enemy.decktex:SetTexCoord(0, 1, 0, 464/512)
    PlayFrame.enemy.decktex:SetPoint("topleft", PlayFrame.enemy.deck)
    PlayFrame.enemy.decktex:SetPoint("bottomright", PlayFrame.enemy.deck)
    
    PlayFrame.enemy.leader = CreateFrame("frame", addonName.."enemyHero", sidebar)
    PlayFrame.enemy.leader:SetPoint("topleft", sidebar, "topleft", 50, -50)
    PlayFrame.enemy.leader:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    PlayFrame.enemy.leader:SetWidth(GwentAddon.NUM_CARD_WIDTH)
    PlayFrame.enemy.leader:SetScript("OnEnter", function(c) GwentAddon:SetCardTooltip(_enemyLeader) end)
    PlayFrame.enemy.leader:SetScript("OnLeave", function(c) GwentAddon.playFrame.cardTooltip:Hide() end)
    
    GwentAddon:CreateOuterCardShadow(PlayFrame.enemy.leader)
    
    PlayFrame.enemy.leaderTex = PlayFrame.enemy.leader:CreateTexture(addonName.."enemyHeroTex")
    PlayFrame.enemy.leaderTex:SetDrawLayer("ARTWORK", 0)
    PlayFrame.enemy.leaderTex:SetTexture(TEXTURE_CUSTOM_PATH.."BackTotallyLegit")
    PlayFrame.enemy.leaderTex:SetTexCoord(0, 1, 0, 464/512)
    PlayFrame.enemy.leaderTex:SetPoint("topleft", PlayFrame.enemy.leader)
    PlayFrame.enemy.leaderTex:SetPoint("bottomright", PlayFrame.enemy.leader)
    
    PlayFrame.enemy.graveyard = CreateFrame("frame", addonName.."playerGY", playfield)
    PlayFrame.enemy.graveyard:SetPoint("right", PlayFrame.enemy.deck, "left", -30, 0)
    PlayFrame.enemy.graveyard:SetHeight(GwentAddon.NUM_CARD_HEIGHT)
    PlayFrame.enemy.graveyard:SetWidth(GwentAddon.NUM_CARD_WIDTH)
    GwentAddon:CreateOuterCardShadow(PlayFrame.enemy.graveyard)
    
    PlayFrame.enemy.graveyardTex = PlayFrame.enemy.graveyard:CreateTexture(addonName.."playerGYTex")
    PlayFrame.enemy.graveyardTex:SetDrawLayer("ARTWORK", 3)
    PlayFrame.enemy.graveyardTex:SetTexture(TEXTURE_CUSTOM_PATH.."Graveyard")
    PlayFrame.enemy.graveyardTex:SetTexCoord(0, 1, 0, 464/512)
    PlayFrame.enemy.graveyardTex:SetVertexColor(1, 1, 1)
    PlayFrame.enemy.graveyardTex:SetPoint("topleft", PlayFrame.enemy.graveyard)
    PlayFrame.enemy.graveyardTex:SetPoint("bottomright", PlayFrame.enemy.graveyard)
      
 
 
    return PlayFrame
end

[semlar]

Originally Posted by LanceDH So what you're saying is, no matter how hard you try to clean your Zerg, it's always going to leave creep behind? In other words, it's impossible to do what I'm trying to do without blizzard code falling appart, and should just stick with dragging the spells from my own buttons?

If you call SpellBookPrevPageButton_OnClick (or anything that updates what the spellbook is displaying), it will break the spell buttons because of how their click function is implemented.

If you make a macro that /clicks the page buttons, it will behave the same way as if the player had clicked them directly, because it requires a hardware event to function and is considered more secure than your addon calling the function directly.

[SDPhantom]

Originally Posted by LanceDH Well fk. Here I've been programming addons in nothing but LUA thinking I'm not doing it the way I should. And now I, for once, code one with XML..

XML was the way back in the early versions of WoW before the Widget functions were made available to the Lua side. Since then, Lua has been the preferred method for the ease of debugging and it no longer requires globals to pass between Widgets and the rest of the addon.

[Gethe]

On the subject of functions in XML, in 6.1 Blizzard added a "mixin" attribute for frames (note: not sure if it's only for frames). This adds the functions from the referenced global table into the attributed frame, allowing you to access those functions (and maybe other data, I have not tested this) via self in both XML and Lua.

Blizzard uses this mostly in the Garrison UI (since 6.2), though it was first used in the Heirloom Collection (in 6.1). They create the global table "GarrisonFollowerList" in Blizzard_GarrisonSharedTemplates.lua, and is used as a mixin for many frames. You can see Blizzard_GarrisonRecruiterUI.xml where they use the OnShow and OnHide methods from the mixin table within the applicable scripts.

Many addons create at least one global to house various bits of data, so this same global can easily be used as a mixin for XML created frames. That said, debugging would still be much easier in Lua so there probably won't be many authors switching to use the new attribute; however, it could be very useful for use in eg. templates where XML is required.

[Fizzlemizz]

The frame has the attribute: mixin="GarrisonFollowerList"
but the script calls: GarrisonFollowListEditBox_OnTextChanged
which is a standalone global function so I think I'm missing something here or it's a nonsensical bit of coding on Blizzards part.

[Gethe]

Originally Posted by Fizzlemizz The frame has the attribute: mixin="GarrisonFollowerList" but the script calls: GarrisonFollowListEditBox_OnTextChanged which is a standalone global function so I think I'm missing something here or it's a nonsensical bit of coding on Blizzards part.

No, that's a script on the edit box not the frame with the mixin.

[Fizzlemizz]

Originally Posted by Gethe No, that's a script on the edit box not the frame with the mixin.

Ah, OK, took a second look to see where/how it was implemented for OnShow/OnHide.

I'll have to give it a closer look to understand what it might actually bring to the table. DUF and DART are still largely XML based.

[MunkDev]

Originally Posted by LanceDH Won't argue with that. Forgot something in your XML? Well I'm just going to tell you something went wrong in your LUA instead. Edit: As for everything LUA, this is unfinished and uncleaned code but I think we can all agree it burns people's eyes out.

Not exactly practicing what I preach, but you could just localize the widget to reduce bloat:

local Left = PlayFrame:CreateTexture("$parent_L", "ARTWORK", 0)
Left:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Left")
Left:SetTexCoord(0, 1, 0, .87)
Left:SetWidth(16)
Left:SetVertexColor(bSat, bSat, bSat)
Left:SetPoint("topleft", PlayFrame, 15, -25)
Left:SetPoint("bottomleft", PlayFrame, 15, 25)
PlayFrame.left = Left
 
local Right = PlayFrame:CreateTexture("$parent_R", "ARTWORK", 0)
Right:SetTexture("Interface\\AchievementFrame\\UI-Achievement-MetalBorder-Left")
Right:SetTexCoord(1, 0, 0, .87)
Right:SetWidth(16)
Right:SetVertexColor(bSat, bSat, bSat)
Right:SetPoint("topright", PlayFrame, -15, -25)
Right:SetPoint("bottomright", PlayFrame, -15, 25)
PlayFrame.right = Right

On-topic:
I spent a lot of time trying to get this stuff sorted, because I use a fake cursor in ConsolePort that clicks on buttons and stuff in the interface. Since it had to be robust and refrain from tainting every single thing it touches, it uses the secure action button system along with a clickbutton attribute. The attribute is changed every time the user moves the cursor to another button, thus never calling any specific click scripts and never tainting the buttons it clicks.

The problem you're facing here is whether you can scan the spell book in a secure environment, which can only be done with secure handlers - and they offer a very limited part of the API. Also note that you can't reference non-secure frames in combat in a secure environment, meaning the paging buttons can't be clicked programmatically in combat using that approach. Personally, I think you should think of a different design to solve your problem.

[LanceDH]

I decided to just go with dragging from my own buttons instead.
I'm still tainting the other frames but so far they don't seems to cause problems with any protected functions.
If they end up doing so.. I fear the whole point of the addon is lost.

As for the bloat, I just hate wasting half the code in my LUA files on visual stuff.
If I get to making another addon I might try out just putting all visual stuff in its own LUA file and see how I like that.