Quantcast
Some abilities do not show in combat log - WoWInterface
Thread Tools Display Modes
03-18-14, 01:30 PM   #1
Spawnova
A Warpwood Thunder Caller
 
Spawnova's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2012
Posts: 96
Some abilities do not show in combat log

I'm trying to get abilities like concussive shot and silencing shot to show in the combat log but with no success, I'm just curious if such spells are not displayed in the combat log or if I'm missing something.

Here's what I have so far.

Lua Code:
  1. elseif event == "COMBAT_LOG_EVENT" then
  2.     local eventType,_,_,sourceName,_,_,_,_,_,_ = ...
  3.     if sourceName then
  4.         if string.find(sourceName, UnitName("player")) then
  5.             local sID,sID2 = select(11,...)
  6.             print(sID .. sID2)
  7.         end
  8.     end
  9. end

I have tried searching before posting, couldn't find anything. =[

Last edited by Spawnova : 03-18-14 at 01:41 PM.
  Reply With Quote
03-18-14, 01:44 PM   #2
Clamsoda
A Frostmaul Preserver
Join Date: Nov 2011
Posts: 269
I can guarantee that Concussive Shot and Silencing Shot both have combat log entries; you should try registering COMBAT_LOG_EVENT_UNFILTERED, and listen for that.

Edit: I was just looking at your code...don't use sourceName as your unit check, cache your GUID on PLAYER_LOGIN, and check the unit GUID. Even if that was the approach you wanted to take, cache UnitName so it isn't firing on every CLEU.

Last edited by Clamsoda : 03-18-14 at 01:48 PM.
  Reply With Quote
03-18-14, 01:47 PM   #3
Spawnova
A Warpwood Thunder Caller
 
Spawnova's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2012
Posts: 96
Ah okay, that works.

I read on the wiki/wowpedia page that the normal event was the same as unfiltered just only tracking what you did so I figured it would would be fine, but everything shows up with unfiltered.

Thanks a bunch, =)
  Reply With Quote
03-18-14, 01:54 PM   #4
Clamsoda
A Frostmaul Preserver
Join Date: Nov 2011
Posts: 269
I am not entirely clear on the conditions that must be met for COMBAT_LOG_EVENT to fire; perhaps it depends on what filters you have set on your combat log?

In my experience, COMBAT_LOG_EVENT_UNFILTERED is typically the way to go, you're guaranteed to catch anything that triggers CLEU.

Just want to stress how many times CLEU fires a second in some environments, and to take care of how many function calls you make when it fires. If you -MUST- make a function call, make sure to narrow down your CLEU function with if-then blocks. Caching data like UnitName(or UnitGUID) helps as well.

Note: UnitGUID isn't available until PLAYER_LOGIN.
  Reply With Quote
03-18-14, 02:07 PM   #5
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Originally Posted by Clamsoda View Post
I am not entirely clear on the conditions that must be met for COMBAT_LOG_EVENT to fire; perhaps it depends on what filters you have set on your combat log?
Yep, that's exactly it. Addons interested in combat event detection should always use CLEU, never CLE. The only reason to ever use CLE in an addon would be if you were providing an alternative combat log display, such as sending the messages to a custom frame instead of ChatFrame2.

@Spawnova: If you're trying to get those spells to show in your combat log, check your settings by right-clicking the chat tab, clicking "Settings", and clicking the "Combat" category. If you're trying to do detect your use of those spells in an addon, watching UNIT_SPELLCAST_SENT/SUCCEEDED will be way more efficient than watching CLEU.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Donít message me about addon bugs or programming questions.

Last edited by Phanx : 03-18-14 at 02:22 PM.
  Reply With Quote
03-18-14, 02:42 PM   #6
Spawnova
A Warpwood Thunder Caller
 
Spawnova's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2012
Posts: 96
Thanks guys, that's a lot of information I did not know about.
  Reply With Quote

WoWInterface » Developer Discussions » Lua/XML Help » Some abilities do not show in combat log

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off