First Button Hook Attempt

[Codger]

This adds a button next to the quest "Accept" button labeled "Accept Track". When pressed the quest is accepted and quest tracking is turned on. It seems to be working ok, but thought I would put it here for review and see if there was something different I should have done.

AcceptAndTrack.toc

## Interface: 100206
## Title: Accept And Track
## Notes: Adds an 'Accept and Track' button to quest frames.
## Author: Codger
## Version: 10.2.6
AcceptAndTrack.lua

AcceptAndTrack.lua

local function AcceptAndTrackQuest()
    AcceptQuest();
 
    C_Timer.After(1, function() -- Delay to ensure the quest log is updated
        local questID = GetQuestID();
        if questID and not C_QuestLog.GetQuestWatchType(questID) then
            C_QuestLog.AddQuestWatch(questID, Enum.QuestWatchType.Automatic);
            -- No need to manually update the objective tracker anymore,
            -- as the quest watch system handles it.
        end
    end)
end
 
local function CreateButton()
    if not QuestFrameAcceptButton then return end -- Ensures the Accept button is loaded
 
    local trackButton = CreateFrame("Button", "AcceptAndTrackButton", QuestFrame, "UIPanelButtonTemplate")
    trackButton:SetSize(120, 22) -- Button size
    trackButton:SetText("Accept And Track")
    trackButton:SetPoint("TOPRIGHT", QuestFrameAcceptButton, "TOPRIGHT", 150, 0) -- Adjusted positioning
    trackButton:SetScript("OnClick", AcceptAndTrackQuest)
    trackButton:SetShown(QuestFrame:IsShown())
 
    -- Debug print to chat to confirm the button was created
    print("AcceptAndTrack button created.")
end
 
-- Delay button creation to ensure the QuestFrame is fully loaded
C_Timer.After(2, CreateButton)
 
QuestFrame:HookScript("OnShow", function() if AcceptAndTrackButton then AcceptAndTrackButton:SetShown(true) end end)
QuestFrame:HookScript("OnHide", function() if AcceptAndTrackButton then AcceptAndTrackButton:SetShown(false) end end)

[SDPhantom]

• Unless you're hooking into a Blizzard LoD "addon", the UI code is already loaded before yours. There's no need to delay creating your button.
• Unless the inherited template requires it, frame names are optional. This ends up creating a global with the name of your frame. This can introduce name collisions when you have a generic name like "AcceptAndTrackButton".
• Manually calling show/hide depending on parent visibility is redundant as children will never show when the parent is hidden.
• Calling GetQuestID() after AcceptQuest() can have unpredictable results as it's only supposed to be valid while the quest detail is shown.
• Using a time delay to set your tracking creates a race condition for the server to respond that you have successfully accepted a quest. It's better to respond to the event signifying this instead.

With these in mind, here's with the changes I've made.

local TrackButton = CreateFrame("Button", nil, QuestFrameDetailPanel, "UIPanelButtonTemplate");
TrackButton:SetSize(120, 22);
TrackButton:SetText("Accept And Track");
TrackButton:SetPoint("BOTTOMLEFT", 113, 4);
TrackButton:SetScript("OnClick", function(self)
    self.QuestID = GetQuestID();
    AcceptQuest();
end);
 
TrackButton:RegisterEvent("QUEST_ACCEPTED");
TrackButton:SetScript("OnEvent", function(self, event, questid)
    if questid == self.QuestID then
        if not C_QuestLog.GetQuestWatchType(questid) then
            C_QuestLog.AddQuestWatch(questid, Enum.QuestWatchType.Automatic);
        end
        self.QuestID = nil;
    end
end);

[Codger]

I really appreciate the help!!

[Codger]

I noticed that the button is showing up on the frame when the quest is being turned in.
i've tried a couple ways of hiding the button with no luck.
I tried setting IsShown to the same state as the accept button but the accept button is always reporting that shown is true. Then I tried to add another event QUEST_COMPLETE but that doesn't seem to help either. Although it seems obvious, I'm a bit confused as to how the show/hide button code works.
I've looked at events with /etrace to see if there was another event I could use but no luck.
I used /framestack to examine the buttons but so far I haven't found anything.

[SDPhantom]

I swapped the button's parent to QuestFrameDetailPanel. That should do the trick.

[Codger]

That works.
I opened up /framestack to understand the difference.
Thanks for the help.