Need help tracking current absorb values for player auras

[ravagernl]

I have plans to make an addon to track absorb effects on myself. I have the tracking part done for when aura's are applied/refreshed/removed and want to find a way to update the current values for the effects whenever you absorb something. One way would be tooltip scanning I think, but I'm wondering if there's any other way.

Here is my current code:

local evtframe = CreateFrame("Frame", name..'Frame')
evtframe.shields = {
    -- Priest stuff
    [17] = { max = {}, cur = {} }, -- Power Word: Shield
    [47753] = { max = {}, cur = {} }, -- Divine Aegis
    -- DK stuff
    [77535] = { max = {}, cur = {} }, -- Blood Shield
    -- Paladin stuff
    [86273] = { max = {}, cur = {} }, -- Illuminated Healing
    [96263] = { max = {}, cur = {} }, -- Sacred Shield
}
 
function evtframe:SPELL_AURA_APPLIED(srcGUID, spellId, spellName, amount)
    Debug(spellName..' applied.')
    self.shields[spellId].max[srcGUID] = amount
    self:SPELL_AURA_REFRESHED(srcGUID, spellId, spellName, amount)
end
 
function evtframe:SPELL_AURA_REFRESHED(srcGUID, spellId, spellName, amount)
    if self.shields[spellId].max[srcGUID] < amount then
        self.shields[spellId].max[srcGUID] = amount
    end
    Debug(spellName..' has '..amount..' of '..(self.shields[spellId].max[srcGUID])..' left')
    self.shields[spellId].cur[srcGUID] = amount
end
 
function evtframe:SPELL_AURA_REMOVED(srcGUID, spellId, spellName, amount)
    Debug(spellName..' has been removed or timed out.')
    self.shields[spellId].max[srcGUID] = nil
    self.shields[spellId].cur[srcGUID] = nil
end
 
evtframe:RegisterEvent('COMBAT_LOG_EVENT_UNFILTERED')
evtframe:SetScript("OnEvent", function(self, _, timestamp, subevent, srcGUID, srcName, sourceFlags, dstGUID, dstName, dstFlags, spellId, spellName, spellSchool, auraType, amount)
    if not (
        dstGUID == UnitGUID'player' and 
        self[subevent] and
        self.shields[spellId]
    ) then return end
    --Debug(timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellId, spellName, spellSchool, auraType, amount)
    self[event](self, srcGUID, spellId, spellName, amount)
end)

Any optimization suggestions(if possible) are also welcome.

[Xubera]

after you get a shield's absorb amount, couldnt you just use the C_L_E_U and do math to determine the absorb amount, merely rechecking the tooltip from time to time for accuracy

like if playerA gets a pw:shield and the tooltip says absorbs 1500, then you get a C_L_E_U event and one of the absorbed counters says 1200, you know theres 300 left without needing to scan the tooltip, then perhaps periodically, maybe every few seconds, check the tooltip for accuracy.

and i dont know how to optimize lol

[ravagernl]

Originally Posted by Xubera after you get a shield's absorb amount, couldnt you just use the C_L_E_U and do math to determine the absorb amount, merely rechecking the tooltip from time to time for accuracy like if playerA gets a pw:shield and the tooltip says absorbs 1500, then you get a C_L_E_U event and one of the absorbed counters says 1200, you know theres 300 left without needing to scan the tooltip, then perhaps periodically, maybe every few seconds, check the tooltip for accuracy. and i dont know how to optimize lol

The problem with this is that CLEU does not give you information on what aura(s) absorbed damage. So I think I have to scan tooltips every time on:

• A partial absorb from a white melee attack
• A partial absorb from a ranged shot ,spell, or dot
• A missed white melee attack(type == "ABSORB")
• A missed ranged shot, spell, or dot(type == "ABSORB")

Bah

I'm currently using this code to do so, I have yet to write the tooltipscanner.
I also removed the functions for the subevents, because, well, they feel like they are unneeded.

evtframe:RegisterEvent('COMBAT_LOG_EVENT_UNFILTERED')
evtframe:SetScript("OnEvent", function(self, _, timestamp, type, srcGUID, srcName, sourceFlags, dstGUID, dstName, dstFlags, ...)
    if dstGUID ~= UnitGUID('player') then 
        return
    end
 
    local hasshields = ns:HasActiveShields()
    -- Aura applied or removed
    if type == 'SPELL_AURA_APPLIED' or
        hasshields and (
            type == 'SPELL_AURA_REFRESHED' or
            type == 'SPELL_AURA_REMOVED'
        )
    then
        local unit = GUIDToUnitID(srcGUID)
        local id, name, school, type, amount = ...
        -- make sure we have a trackable unit
        -- make sure we want to track the aura
        if not unit or not ns.shields[id] then return end
        if type == 'SPELL_AURA_REMOVED' then
            ns:UpdateMax(unit, srcGUID, id, name, type, amount, true)
        else
            ns:UpdateMax(unit, srcGUID, id, name, type, amount)
        end
        ns:UpdateAllBars()
    -- Do not proceed if there are no shields active
    -- This is to prevent tracking of absorbed damage via soul link (warlocks)
    -- and other shields that absorb a percentage of health
    -- There is no need to check in that case.
    elseif hasshields then
        -- "Melee" partial absorb
        if type == "SWING_DAMAGE" then
            local _, _, _, _, _, absorbed = ...
            if not absorbed then return end
            ns:UpdateFromTooltips()
        -- "Spell" partial absorb
        elseif type == "RANGE_DAMAGE" 
            or type == "SPELL_DAMAGE" 
            or type == "SPELL_PERIODIC_DAMAGE"
        then
            local _, _, _, _, _, _, _, _, absorbed = ...
            if not absorbed then return end
            ns:UpdateFromTooltips()
        -- "Melee" full absorb
        elseif type == "SWING_MISSED"  then
            local missType = ...
            if missType ~= "ABSORB"  then return end
            ns:UpdateFromTooltips()
        -- "Spell" full absorb
        elseif type == "RANGE_MISSED" 
            or type == "SPELL_MISSED" 
            or type == "SPELL_PERIODIC_MISSED"
        then
            local _, _, _, missType = ...
            if missType ~= "ABSORB" then return end
            ns:UpdateFromTooltips()
        end
    end
end)