the _G changes.

[Grimsin]

can someone explain this better. "The getglobal and setglobal functions are considerd deprecated, and have been removed from the C API's. In the interests of compatibility there remain lua implementations of both, but new code should be updated to use x = _G[globalName] and _G[globalName] = x instead."

what code should be updated? i think this is where the problems with my ui are but not exactly sure why does it mean things like this _G[prefix .. slots[id]] need to be changed? or _G[this:GetName().. ?

[nightcracker]

No, only setglobal(prefix .. slots[id], "SOMEVALUE") needs to be updated to _G[prefix .. slots[id]] = "SOMEVALUE".

If you didn't use setglobal or getglobal, then you shouldn't be worried.

[Grimsin]

hmmm, well im still confused then about one change or another. I get what appears to be the same value = nil error on a few different chunks of code. some of the chunks are as follows.

local function CreateBorders(frame, prefix)
    local border, start = { }, frame == CharacterFrame and 0 or 1
    for id = start, #slots do
        local frame = _G[prefix .. slots[id]]
        local region = GetNormalTexture(frame:GetRegions())
        local texture = frame:CreateTexture(nil, 'OVERLAY')
        texture:SetTexture([[Interface\Buttons\UI-ActionButton-Border]])
        texture:SetBlendMode('ADD')
        texture:SetAlpha(0.8)
        texture:SetPoint('TOPLEFT', region, -1, 3)
        texture:SetPoint('BOTTOMRIGHT', region, 1, 0)
        border[id] = texture
    end
    borders[frame] = border
end
 
local function OnHide(self)
    addon.UnregisterEvent(self, 'UNIT_INVENTORY_CHANGED')
end
 
local function OnShow(self)
    addon.RegisterEvent(self, 'UNIT_INVENTORY_CHANGED', UpdateItemQualityBorders)
    UpdateItemQualityBorders(self, nil, self.unit)
end
 
local function HookFrame(frame, prefix)
    CreateBorders(frame, prefix)
    frame:HookScript('OnHide', OnHide)
    frame:HookScript('OnShow', OnShow)
end
 
HookFrame(CharacterFrame, 'Character')
CharacterFrame.unit = 'player'
 
if InspectFrame then
    HookFrame(InspectFrame, 'Inspect')
else
    addon.RegisterEvent("Features-MonitorInspectUI", 'ADDON_LOADED', function(self, event, name)
        if name ~= 'Blizzard_InspectUI' then return end
        addon.UnregisterEvent(self, event)
 
        HookFrame(InspectFrame, 'Inspect')
        if InspectFrame:IsShown() then
            UpdateItemQualityBorders(InspectFrame, nil, InspectFrame.unit)
        end
    end)
end

or this chunk

hooksecurefunc('FriendsList_Update', function()
    local buttons, button = FriendsFrameFriendsScrollFrame.buttons
    local colors, CLASS = CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS, addon.CLASS
    for index = 1, FriendsFrameFriendsScrollFrame.usedButtons do
        button = buttons[index]
        if button.buttonType == FRIENDS_BUTTON_TYPE_WOW then
            local _, _, class, _, connected = GetFriendInfo(button.id)
            if connected then
                local color = colors[CLASS[class]]
                button.name:SetTextColor(color.r, color.g, color.b)
            end
        end
    end
end)

and last but not least this chunk also

_G.SlashCmdList["GTIPNOTES_SHORTHAND"] = function(input)
    if not UnitExists("target") then
        DEFAULT_CHAT_FRAME:AddMessage(TARGET_ERROR)
        return
    end
    if type(input) ~= "string" or input:trim():len() == 0 then
        if not StaticPopupDialogs["GTipNotes"] then
            StaticPopupDialogs["GTipNotes"] = {
                text = nil,
                button1 = SET,
                button2 = CANCEL,
                whileDead = 1,
                hideOnEscape = 1,
                timeout = 0,
                OnShow = function()
                    -- We have to do this onshow to reset the previous text
                    local t = UnitExists("target") and UnitName("target") or ""
                    _G[this:GetName().."EditBox"]:SetText(_G.GTipNotesDB[t] or "")
                end,
                OnHide = function()
                    _G[this:GetName().."EditBox"]:SetText("")
                end,
                EditBoxOnEnterPressed = function()
                    addNoteFromPopup(_G[this:GetParent():GetName().."EditBox"]:GetText())
                    this:GetParent():Hide()
                end,
                EditBoxOnEscapePressed = function()
                    this:GetParent():Hide()
                end,
                OnAccept = function()
                    addNoteFromPopup(_G[this:GetParent():GetName().."EditBox"]:GetText())
                end,
                hasEditBox = 1,
            }
        end
        StaticPopupDialogs["GTipNotes"].text = POPUP_TEXT:format(UnitName("target"))
        StaticPopup_Show("GTipNotes")
    else
        local t = UnitName("target")
        _G.GTipNotesDB[t] = input
        DEFAULT_CHAT_FRAME:AddMessage(NOTE_SET:format(t, input))
    end
end

all works on live servers so it has to be the cata changes that caused this im just not sure which one or why.

[IQgryn]

Originally Posted by Grimsin hmmm, well im still confused then about one change or another. I get what appears to be the same value = nil error on a few different chunks of code. some of the chunks are as follows. <snip>

Which lines are causing the nil errors?

* The global variables this, event and arg1, arg2... have been removed. Event handlers and other callbacks must use the appropriate locals.

These changes are present as well.

[Grimsin]

my use of "this" in the tooltips code i changed to self and got a way different error, i dont think the use of this in that instance is the same as what was changed? if so i should of been able to simply change this to self or at lest that was my understanding.

the exact line that it starts in the 3rd chunk of code is this one, it says "this" is a nil value
_G[this:GetName().."EditBox"]:SetText(_G.GTipNotesDB[t] or "")

in the first chunk of code it is this one, this one says "frame" is a nil value
local region = GetNormalTexture(frame:GetRegions())

in the 2nd chunk of code im not sure which line it was i have to go back and check.

[IQgryn]

Originally Posted by Grimsin my use of "this" in the tooltips code i changed to self and got a way different error, i dont think the use of this in that instance is the same as what was changed? if so i should of been able to simply change this to self or at lest that was my understanding. the exact line that it starts in the 3rd chunk of code is this one, it says "this" is a nil value _G[this:GetName().."EditBox"]:SetText(_G.GTipNotesDB[t] or "") in the first chunk of code it is this one, this one says "frame" is a nil value local region = GetNormalTexture(frame:GetRegions()) in the 2nd chunk of code im not sure which line it was i have to go back and check.

Unless you specifically declare a variable named this, any use of this is now invalid (and using it will cause nil errors). It's also not always just as simple as changing it to say self. That will usually work when you have a function definition of the form:

Frame:function()

Although even then, there can be problems. If your function is not declared like that (and the ones you posted aren't), you need to add a self parameter to the parameter list and update the code using the function to pass that along as well.

Note that if you add the parameter yourself, you don't have to call it self. You may use whatever name suits your fancy.

[Vrul]

Only the last error has anything to do with the changes to this, and only changing this to self won't fix it, you also need to update the function declarations to include that self is passed:

_G.SlashCmdList["GTIPNOTES_SHORTHAND"] = function(input)
    if not UnitExists('target') then
        print(TARGET_ERROR)
        return
    end
    input = input:trim()
    if type(input) ~= 'string' or input == "" then
        if not StaticPopupDialogs["GTipNotes"] then
            StaticPopupDialogs["GTipNotes"] = {
                text = nil,
                button1 = SET,
                button2 = CANCEL,
                whileDead = 1,
                hideOnEscape = 1,
                timeout = 0,
                OnShow = function(self)
                    -- We have to do this onshow to reset the previous text
                    local name = UnitExists("target") and UnitName("target") or ""
                    _G[self:GetName() .. "EditBox"]:SetText(_G.GTipNotesDB[name] or "")
                end,
                OnHide = function(self)
                    _G[self:GetName() .. "EditBox"]:SetText("")
                end,
                EditBoxOnEnterPressed = function(self)
                    addNoteFromPopup(_G[self:GetParent():GetName() .. "EditBox"]:GetText())
                    self:GetParent():Hide()
                end,
                EditBoxOnEscapePressed = function(self)
                    self:GetParent():Hide()
                end,
                OnAccept = function(self)
                    addNoteFromPopup(_G[self:GetParent():GetName() .. "EditBox"]:GetText())
                end,
                hasEditBox = 1,
            }
        end
        StaticPopupDialogs["GTipNotes"].text = POPUP_TEXT:format(UnitName('target'))
        StaticPopup_Show("GTipNotes")
    else
        local name = UnitName('target')
        _G.GTipNotesDB[name] = input
        print(NOTE_SET:format(name, input))
    end
end

The issue with FriendsFrame code is that Blizzard changed it and no longer uses/sets FriendsFrameFriendsScrollFrame.usedButtons:

hooksecurefunc('FriendsList_Update', function()
    local buttons, button = FriendsFrameFriendsScrollFrame.buttons
    local colors, CLASS = CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS, addon.CLASS
    for index = 1, #buttons do
        button = buttons[index]
        if button:IsShown() then
            if button.buttonType == FRIENDS_BUTTON_TYPE_WOW then
                local _, _, class, _, connected = GetFriendInfo(button.id)
                if connected then
                    local color = colors[CLASS[class]]
                    button.name:SetTextColor(color.r, color.g, color.b)
                end
            end
        else
            break
        end
    end
end)

Part of the problem with the first error is that the ammo slot was removed which is what slots[0] is, so remove the start variable and always begin with an id of 1:

local function CreateBorders(frame, prefix)
    local border = { }
    for id = 1, #slots do
        local frame = _G[prefix .. slots[id]]
        local region = GetNormalTexture(frame:GetRegions())
        local texture = frame:CreateTexture(nil, 'OVERLAY')
        texture:SetTexture([[Interface\Buttons\UI-ActionButton-Border]])
        texture:SetBlendMode('ADD')
        texture:SetAlpha(0.8)
        texture:SetPoint('TOPLEFT', region, -1, 3)
        texture:SetPoint('BOTTOMRIGHT', region, 1, 0)
        border[id] = texture
    end
    borders[frame] = border
end

There may still be errors after making those changes, I don't have access to check, but at least you will be one step closer to fixing it.