ToggleTalentFrame() / ToggleGlyphFrame() taint issue

MunkDev · 03-21-15, 09:23 AM

Hello, I'm trying to create a custom game menu and I'm having trouble with two buttons pertaining to the talent and glyph frames.

The taint issue comes from calling ToggleTalentFrame() and ToggleGlyphFrame() insecurely. Since these frames are not loaded by default, I can't use ToggleFrame() as I do with the Spellbook. My question is whether it's possible to actually open these frames with code without it blowing up in my face.

Edit: Here's the updated code:

Lua Code:

local function ToggleTalentUI()
    if not PlayerTalentFrame then
        LoadAddOn("Blizzard_TalentUI");
    end
    ShowUIPanel(PlayerTalentFrame);
end
 
local customButtons = {
    {name = "Character",    title = "Character Info",   ClickFunc = ToggleCharacter,    arg = "PaperDollFrame"},
    {name = "Spellbook",    title = "Spellbook",        ClickFunc = ToggleFrame,        arg = SpellBookFrame},
    {name = "Talent",       title = "Specialization",   ClickFunc = ToggleTalentUI,     arg = nil},
    {name = "Bag",          title = "Bags",             ClickFunc = ToggleAllBags,      arg = nil},
    {name = "Achievement",  title = "Achievements",     ClickFunc = ToggleAchievementFrame, arg = nil},
    {name = "QuestLog",     title = "Quest Log",        ClickFunc = ToggleQuestLog,     arg = nil},
    {name = "LFD",          title = "Group Finder",     ClickFunc = PVEFrame_ToggleFrame, arg = nil},
    {name = "PvP",          title = "PvP",              ClickFunc = TogglePVPUI,        arg = nil},
    {name = "Collections",  title = "Collections",      ClickFunc = ToggleCollectionsJournal, arg = nil},
    {name = "EJ",           title = "Dungeon Journal",  ClickFunc = ToggleEncounterJournal, arg = nil},
    {name = "Garrison",     title = "Garrison Report",  ClickFunc = ToggleGarrisonReport, arg = nil},
    {name = "Score",        title = "Score Screen",     ClickFunc = ToggleWorldStateScoreFrame, arg = nil},
    {name = "Social",       title = "Social",           ClickFunc = ToggleFriendsFrame, arg = nil},
    {name = "Guild",        title = "Guild",            ClickFunc = ToggleGuildFrame,   arg = nil},
}
 
for i, btn in pairs(customButtons) do
    local button = CreateFrame("BUTTON", "GameMenuButton"..btn.name, GameMenuFrame, "GameMenuButtonTemplate");
    local anchor = customButtons[i-1] and customButtons[i-1].name or nil;
    button:SetText(btn.title);
    if anchor then
        button:SetPoint("TOP", _G["GameMenuButton"..anchor], "BOTTOM", 0, -1);
    else
        button:SetPoint("TOPRIGHT", GameMenuFrame, "TOPRIGHT", -20, -20);
    end
    button:SetScript("OnClick", function(...)
        ToggleFrame(GameMenuFrame);
        btn.ClickFunc(btn.arg);
    end);
    table.insert(buttons, button);
end

Here's what it ends up looking like atm.

10leej · 03-21-15, 10:16 AM

I use this in Click Menu for the talents, I don't call glyphs though.

Code:

if (not PlayerTalentFrame) then
LoadAddOn('Blizzard_TalentUI')
end

if (not GlyphFrame) then
  LoadAddOn('Blizzard_GlyphUI')
end

securecall(ToggleTalentFrame)

Clamsoda · 03-21-15, 10:21 AM

I know a decent way to avoid taint is to run the click method on any buttons that exist. You could run the click method on the micro menus' TalentMicroButton. You could then run the click method on the "Glyphs" tab.

Lua Code:

TalentMicroButton:Click()

Lua Code:

if (PlayerTalentFrame:IsShown()) then
    PlayerTalentFrameTab3:Click()
end

I know that doesn't help with load on demand issues, but it is a start.

Resike · 03-21-15, 10:25 AM

Lua Code:

ShowUIPanel(PlayerTalentFrame) -- Always opens on the last used tab
HideUIPanel(PlayerTalentFrame)
 
PlayerTalentFrame_Toggle(GetActiveSpecGroup()) -- 1 for primary 2 for secondary
 
PlayerTalentFrame_ToggleGlyphFrame(GetActiveSpecGroup()) -- 1 for primary 2 for secondary

MunkDev · 03-21-15, 10:30 AM

Resike: Your approach works for opening the talent frame, but using

Lua Code:

PlayerTalentFrame_ToggleGlyphFrame(GetActiveSpecGroup())

seems to still cause the taint in the glyph frame.

The other solutions you guys provided cause full on taint, just like my original approach.

Edit: Maybe I should add I'm not clicking these with my mouse.

MunkDev · 03-21-15, 11:02 AM

Bah, I've decided against a dedicated Glyph button. It's not that necessary.
Thanks for the help everyone.

Resike · 03-21-15, 11:04 AM

Originally Posted by MunkDev

Bah, I've decided against a dedicated Glyph button. It's not that necessary.
Thanks for the help everyone.

Nononon, here you go:

Lua Code:

function ToggleTalentTab(tabNumber)
    if not PlayerTalentFrame or not PlayerTalentFrame:IsShown() then
        GlyphFrame_LoadUI()
        ShowUIPanel(PlayerTalentFrame)
        PanelTemplates_SetTab(PlayerTalentFrame, tabNumber)
        PlayerTalentFrame_HideTalentTab()
        PlayerTalentFrame_HideSpecsTab()
        PlayerTalentFrame_ShowGlyphFrame()
        PlayerTalentFrame_HidePetSpecTab()
    else
        HideUIPanel(PlayerTalentFrame)
    end
end
 
-- To toggle tabs [1-4]
ToggleTalentTab(3)

Edit: Made some changes should work for every tab now and it's toggleable.