Purge Addon Request

[Baggyman]

Would it be possible to make an addon that only shows debuffs and purgeable buffs on the enemy unit and focus frames?

So essentially just get rid of all the buffs that I cannot purge.

[Fizzlemizz]

Yes it's possible, check the documentation for UnitBuff and UnitDebuff and note the "dispelType" return of each.

[Baggyman]

Can anyone help me out with the code on this.

I tried editing some other peoples existing code but it still isn't working. Are any of these 2 trys close:


UIParent:SetScript("OnUpdate", function()
if TargetFrame:IsShown() then
numBuffs = 0
for i=1, MAX_TARGET_BUFFS do
if (select(3,UnitBuff("target",i)) ~= 'Magic') then
numBuffs = numBuffs + 1
end
end
for i=1, numBuffs do
local frame = _G["TargetFrameBuff"..i]
frame:Hide()
end
end


OR


hooksecurefunc("TargetFrame_UpdateAuras", function(s)
for i=1, MAX_TARGET_BUFFS do
if select(5,UnitAura(s.unit,i)) ~= 'Magic' then
_G[s:GetName()..i]:Hide()
end
end
end)

[Baggyman]

Alright I figured it out! This is what I used if anyone else is interested:

hooksecurefunc("TargetFrame_UpdateAuras", function(s)
for i = 1, MAX_TARGET_BUFFS do
_, _, ic, _, dT = UnitBuff(s.unit, i)
if(ic and (not s.maxBuffs or i<=s.maxBuffs)) then
local frame = _G["TargetFrameBuff"..i]
if(dT~='Magic') then
frame:Hide()
end
end
end
end)


Also could someone explain to me what "not s.maxBuffs or i<=s.maxbuffs" is checking for? I got some of this code from around the web and am not quite sure what that part is for.

[Clamsoda]

The logic you posted about is to prevent your loop from doing work on anything not visible. MAX_TARGET_BUFFS, which is the boundary for your loop, is a constant -- 32. self.maxBuffs is the current amount of buffs on the target, but understand that all 32 buff frames exist, and are used dynamically. So, that bit of logic prevents the loop from iterating past what buffs are currently displayed.

The code you posted leaks some very generic variables into the global name space, I posted a cleaned up version.

hooksecurefunc("TargetFrame_UpdateAuras", function(self)
    for i = 1, MAX_TARGET_BUFFS do
        local _, _, icon, _, dispelType = UnitBuff(self.unit, i)
 
        if (icon and (not self.maxBuffs or i <= self.maxBuffs) ) then
            if (dispelType ~= "Magic") then
                _G["TargetFrameBuff"..i]:Hide()
            end
        end
    end
end)

[Baggyman]

Thanks for the insight! But I'm not sure I quite fully understand what you are saying. What is the downside or implication if it can not iterate past what buffs are currently displayed?

Also I just tried out your revised logic, and it no longer seems to be hiding buffs.

[Clamsoda]

I revised the code, typo =[.

Well, your intention is to manipulate the buffs that the target has, so there is no sense in iterating into the buff frames that are not currently being used.

Remember, frames for buff 1-32 exist, but only the buffs the target has are being used. So, if your target has 5 buffs, there is no point in iterating over the frames for buff 6-32 because they aren't being displayed to begin with.

[Baggyman]

Ok that makes sense. But does your logic fix that? It seems you just changed out s with self, made line 3 local, and changed line 7.