parent frame...

barbol12 · 12-14-10, 04:22 AM

how would you set a frame(made entirely in lua) to parent to bartender4 pet bar???

ive tried

pet:SetParent("BT4PetButton1")

also tried these:
"PetActionBar"
"PetBar"

but nothing works.... someone know what to properly put in for the parent?

yj589794 · 12-14-10, 04:57 AM

You could either decipher the Bartender code to try and find the correct name, or...

In game type '/framestack' in the chat box (without quotes) and then move the mouse pointer over the pet bar. This will show the names of all the frames under the mouse pointer. Trying '/framestack' again will turn off the functionality.

barbol12 · 12-14-10, 05:01 AM

nice.. but it still comes up with the same thing....

BT4PetButton1.. etc etc

ive tried that to set my frame to that parent... but it does not work.

pet:SetParent("BT4PetButton1") doesnt work.... for some reason.

yj589794 · 12-14-10, 05:03 AM

Is your addon loading before Bartender? If so the parent frame you are trying to set may not exist yet.

Make sure Bartender loads before your addon by making Bartender a required dependency of your addon.

Phanx · 12-14-10, 06:13 AM

Could you be more specific about "doesn't work"? Does your code trigger a Lua error message? What do you expect to happen? What exactly does happen?

Without knowing anything else, I think you may be confused about what SetParent does. It sets the frame's parent, yes, but that has nothing to do with a frame's position, so you shouldn't expect to see any immediate visual change when you reparent a frame. I'm guessing you're trying to do something like this:

pet:SetPoint("BOTTOM", BT4PetButton1, "TOP", 0, 20)

barbol12 · 12-14-10, 06:04 PM

[quote]

Originally Posted by Phanx

Could you be more specific about "doesn't work"? Does your code trigger a Lua error message? What do you expect to happen? What exactly does happen?

Without knowing anything else, I think you may be confused about what SetParent does. It sets the frame's parent, yes, but that has nothing to do with a frame's position, so you shouldn't expect to see any immediate visual change when you reparent a frame. I'm guessing you're trying to do something like this:

pet:SetPoint("BOTTOM", BT4PetButton1, "TOP", 0, 20)

no not at all... heres what i am doing....

local pet = CreateFrame("Frame", nil, UIParent)
pet:SetWidth(317)
pet:SetHeight(24)
pet:SetPoint("BOTTOM", 2, 150)
pet:SetFrameStrata("BACKGROUND")
pet:SetBackdrop({
bgFile = "Interface\\Addons\\textures\\panels.tga",
edgeFile = "Interface\\Addons\\textures\\Stripped.tga",
tile = "false",
tileSize = 1,
edgeSize = 12,
Insets = {left = 1, right = 1, top = 1, bottom = 1}
})
pet:SetBackdropColor(0.1,0.1,0.1,1)
pet:SetBackdropBorderColor(0.1,0.1,0.1,1)
pet:SetParent("BT4PetButton1")

as u can see it has its own position already.. all i am trying to do is get it to only show up, when the pet bar( or the bartender4 pet button 1, in most cases) shows up... and when i have no pet, or no bt4 pet button1 available it is disappeared... im just trying to figure why this isnt working..

when i set

pet:SetParent("BT4PetButton1")

into the table for the frame.. i lose the custom colorings on all my other frames.. and lose a few of them.... but when i take that line away, everything is fine again.

**Seerah** · 12-14-10, 06:13 PM

Why aren't you just doing this?

Code:

local pet = CreateFrame("Frame", nil, BT4PetButton1)

3rd argument to CreateFrame is parent.

Also,

Code:

pet:SetParent("BT4PetButton1") -- string

is not the same as

Code:

pet:SetParent(BT4PetButton1) -- reference to frame

/edit: in the future, use a [code] block instead of a [quote] block to preserve formatting.

Sythalin · 12-14-10, 06:36 PM

Even better, use the [highlight=lua] tag so it colors everything automatically.

lua Code:

local pet = CreateFrame("Frame", nil, UIParent) 
pet:SetWidth(317) 
pet:SetHeight(24)
pet:SetPoint("BOTTOM", 2, 150)
pet:SetFrameStrata("BACKGROUND")
pet:SetBackdrop({
    bgFile = "Interface\\Addons\\textures\\panels.tga",
    edgeFile = "Interface\\Addons\\textures\\Stripped.tga",
    tile = "false",
    tileSize = 1,
    edgeSize = 12,
    Insets = {left = 1, right = 1, top = 1, bottom = 1}
    })
pet:SetBackdropColor(0.1,0.1,0.1,1)
pet:SetBackdropBorderColor(0.1,0.1,0.1,1)
pet:SetParent("BT4PetButton1")

Anyways, try setting your parent first, then the points. It's also a good practice to clear the points before reanchoring just to be safe (frame:ClearAllPoints())

Phanx · 12-14-10, 09:45 PM

Originally Posted by barbol12

when i set into the table for the frame.. i lose the custom colorings on all my other frames.. and lose a few of them.... but when i take that line away, everything is fine again.

That's because setting the parent resets a number of properties. You should be doing what Seerah already suggested, and including the parent in your CreateFrame call. At the very least, move your SetParent line to be directly after the CreateFrame line, before you set any of the frame's other properties.

Originally Posted by Seerah

Also,

Code:

pet:SetParent("BT4PetButton1") -- string

is not the same as

Code:

pet:SetParent(BT4PetButton1) -- reference to frame

Actually, it is exactly the same. It just delays the global lookup until Blizzard's code, instead of doing it in your addon code.

barbol12 · 12-15-10, 10:14 AM

well i got it to work for my pet bar... ended up switching addons to dominos.. and it worked fine.. but now i cant get it to parent to my class/stance bar...
here is the in-game name given for it...

DominosClassButton1

i ended up parenting my stance frame to that button... but it doesn't change.. still acts as though its parenting to the UIParent.

here is the coding for my frame.

Code:

local stance = CreateFrame("Frame", nil, DominosClassButton1)	
		stance:SetWidth(300)
		stance:SetHeight(43)
		stance:SetPoint("LEFT", 0, 0)
		stance:SetFrameStrata("BACKGROUND")
		stance:SetBackdrop({
			bgFile = "Interface\\Addons\\textures\\panels.tga",
			edgeFile = "Interface\\Addons\\textures\\Stripped.tga",
			tile = "false",
			tileSize = 1,
			edgeSize = 15,
			Insets = {left = 1, right = 1, top = 1, bottom = 1}
			})
		stance:SetBackdropColor(0.1,0.1,0.1,1)
		stance:SetBackdropBorderColor(0.1,0.1,0.1,1)

so what is going wrong??

SDPhantom · 12-16-10, 04:24 AM

To test something, try putting this above the CreateFrame() call.

Code:

print(DominosClassButton1)

It'll cause something to show up in the chat frame.
If it says "nil", the pointer doesn't exist at that specific time.
If it says "table: <some hex value>", that should be the frame you're trying to set your parent as.

Phanx · 12-16-10, 07:27 AM

Originally Posted by barbol12

so what is going wrong??

Without seeing your whole code (and your TOC) I couldn't say for sure, but the most likely possibility is that Dominos hasn't yet created that frame at the time your code runs.

barbol12 · 12-16-10, 02:10 PM

Originally Posted by Phanx

Without seeing your whole code (and your TOC) I couldn't say for sure, but the most likely possibility is that Dominos hasn't yet created that frame at the time your code runs.

TOC:

## Interface: 40000
## Version: 4.0
## Title: BarbolUI
## Author: Barbol12
## Notes: User Interface Modification
## Dependencies: Dominos

BarbolUI.xml

and my whole code.. is just all frames.. but here is the stance frame that is being used.

lua Code:

local stance = CreateFrame("Frame", nil, DominosClassButton1)   
        stance:SetWidth(300)
        stance:SetHeight(43)
        stance:SetPoint("LEFT", 0, 0)
        stance:SetFrameStrata("BACKGROUND")
        stance:SetBackdrop({
            bgFile = "Interface\\Addons\\textures\\panels.tga",
            edgeFile = "Interface\\Addons\\textures\\Stripped.tga",
            tile = "false",
            tileSize = 1,
            edgeSize = 15,
            Insets = {left = 1, right = 1, top = 1, bottom = 1}
            })
        stance:SetBackdropColor(0.1,0.1,0.1,1)
        stance:SetBackdropBorderColor(0.1,0.1,0.1,1)

i set my TOC file to have a dependency to Dominos for my addon... but it doesn't change it.. still acts as though the dependency isnt there... plus it worked fine for the PetActionButton... and i didnt have dominos as a dependancy then.

yj589794 · 12-16-10, 02:32 PM

Just because you have set a dependency does not mean that that dependency has created all it's frames when your addon is loaded.
Dominos may wait until certain events occur in game (e.g. PLAYER_ENTERING_WORLD) before it creates some of its frames.

In fact, looking through the Dominos code I can see that the DominosClassButton1 you are trying to use as a parent is not created until the event UPDATE_SHAPESHIFT_FORMS is fired.

You have to use some strategy to create your frames after Dominos haves created its frames.

Phanx · 12-16-10, 09:31 PM

Originally Posted by barbol12

plus it worked fine for the PetActionButton... and i didnt have dominos as a dependancy then.

That's because PetActionButton is part of the default UI, which loads before addons, and is created immediately when the relevant code loads.

By contrast, most addons try to avoid creating frames that may not be needed until they are actually needed. What you're seeing in Dominos is a good example of this -- rather than creating stance/form buttons as soon as it loads, the addon waits until those buttons are actually needed, and then creates them on demand. This way, if you're playing a mage, the addon isn't wasting resources by creating a bunch of frames you'll never see or use.