Hiding Actionbutton borders?

[maltese]

I'm almost finished with a little addon to add a custom vehicle bar wherever you'd like it anchored and I've got a small graphical issue I'd like gone. I'm sure this is an easy fix but I'd really like to hide the borders around the action buttons. I'm fairly certain its not the icons themselves as they should be border free (replacement icons).



Ideas?

[Grimsin]

Originally Posted by maltese I'm almost finished with a little addon to add a custom vehicle bar wherever you'd like it anchored and I've got a small graphical issue I'd like gone. I'm sure this is an easy fix but I'd really like to hide the borders around the action buttons. I'm fairly certain its not the icons themselves as they should be border free (replacement icons). Ideas?

Hmm looks like your missing an important button on that bar... the leave button!!

and try this VehicleMenuBarActionButton1.Border:Hide() see if that gets rid of it. Then of course do that for all the buttons...

[maltese]

Only sissys need the leave button

trying that gives this error:
attempt to index field 'Border' (a nil value)

[Grimsin]

try it without the . in there so it reads VehicleMenuBarActionButton1Border:Hide()

and leave buttons are a must. just ask all the people stuck in turkey day chairs because the addon or interface they are using failed to think about the leave button.

[maltese]

I guess all those people didn't try the whole right click on yourself and choose the leave option? Silly people
I have leave vehicle keybound anyway.

Sadly no period doesn't work either. I've also tried SetBackdropBorderColor(0, 0, 0, 0) which doesn't work

[Grimsin]

you also want to hide... VehicleMenuBarActionButton1NormalTexture:Hide()


The no period is working. You just dont notice the border texture. Do the normal texture and its gone.

You can remove the highlight and pushed textures but i dont remember how to remove none named textures... or maybe you couldnt? i think i found a way i just dont remember it now. Unfortunately the highlight and pushed textures do not have names.

edit- it just hit me... you might be able to overwrite the xml texture setting with lua texture setting so if you do VehicleMenuBarActionButton1HighlightTexture:SetTexture(nil) or VehicleMenuBarActionButton1.HighlightTexture:SetTexture(nil)

you could also sub nil with your own texture... or a blank one if nil does not work...

[maltese]

Yep, thats working... sortof. They are initially hidden, but on use the border is coming back I tried unregistering the borders from events with:

	local buttonborder, buttontexture
	for i = 1, VEHICLE_MAX_ACTIONBUTTONS do
		buttonborder = _G["VehicleMenuBarActionButton"..i.."Border"]
		buttontexture = _G["VehicleMenuBarActionButton"..i.."NormalTexture"]
		buttonborder:SetScript("OnEvent", nil)
		buttontexture:SetScript("OnEvent", nil)
		buttonborder:Hide()
		buttontexture:Hide()
	end

but now I'm getting this error:
attempt to call method 'SetScript' (a nil value)

I might just move those frames offscreen and be done with it ghetto style.

[Grimsin]

no no dont do that.
what you need to do is...
yourframe:hide()
yourframe.show = yourframe:hide()

this will keep it always hidden there is a better way to do it actually but requires a bunch of other stuff be setup...

like here is my do nothing function take over and hide function

local function DoNothing()
end

local function HideFrame(reference)
local frame = type(reference) == 'string' and _G[reference] or reference
if type(frame) ~= 'table' then return end
frame.Show = DoNothing
frame:Hide()
end

then to actually hide your frame you do

HideFrame("yourframe")

then you can just do that HideFrame("yourframe") for each button instead of having to write out the .show = :hide part for each button

and youll never see it again.

Unregistering events from the frame will cause you a ton of problems.

Oh yea and on a final note... what your doing will cause an extreme amount of taint. You will most likely never notice it but just letting you know its happening. -- to do this with out so much taint you would have to write a bunch of secure code to move the buttons and the frame around.

Add that leave button and ill be downloading your addon

[Phanx]

local function DoNothing()
end

local function HideFrame(frame)
	if type(frame) == "string" then
		frame = _G[frame]
	end
	if type(frame) == "table" and frame.Show then
		frame.Show = DoNothing
		frame:Hide()
	end
end

Cleaner, and allows passing either the frame itself, or a string representing the frame's name:

HideFrame(Minimap)
HideFrame("Minimap")

[maltese]

I'll see about adding that leave vehicle button in. Couple people in my guild like it as well but all said "where's the leave button"

EDIT: Just a heads up, both of the above code segments hide the border frames, but as soon as I use the ability the border comes right back.

[AnrDaemon]

Simply ":Hide"ing frame would server nothing, and redefining Show directly is not very good as well.
Try

frame:SetScript("OnShow", frame.Hide);
frame:Hide();

Even if it would not work for you, this is the preferred way of doing this thing.

P.S.
Try to override the OnUpdate handler as well.

[Grimsin]

Originally Posted by AnrDaemon Simply ":Hide"ing frame would server nothing, and redefining Show directly is not very good as well. Try frame:SetScript("OnShow", frame.Hide); frame:Hide(); Even if it would not work for you, this is the preferred way of doing this thing. P.S. Try to override the OnUpdate handler as well.

If you re"set" the setscript for the onshow it will break all of the stuff related to the onshow script written by bliz. This is a bad way to do things. same goes for the onupdate. Now granted it also depends on how much of bliz's code you rely on for things... being that you were asking about the button borders it tells me you simply adjusted a lot of bliz's stuff. Which tells me that if you screw with those scripts youll either have to write a lot more code to accommodate for it or do it the way previously stated.



oh and as another note to the whole re-setting bliz's set scripts... it will more then likely break other addons.

[AnrDaemon]

Originally Posted by Grimsin If you re"set" the setscript for the onshow it will break all of the stuff related to the onshow script written by bliz. This is a bad way to do things. same goes for the onupdate. Now granted it also depends on how much of bliz's code you rely on for things... being that you were asking about the button borders it tells me you simply adjusted a lot of bliz's stuff. Which tells me that if you screw with those scripts youll either have to write a lot more code to accommodate for it or do it the way previously stated. oh and as another note to the whole re-setting bliz's set scripts... it will more then likely break other addons.

Your post sounds just like i'm overriging global OnShow for all frames with single command... ... ............ go figure my reaction.

[maltese]

Originally Posted by AnrDaemon Simply ":Hide"ing frame would server nothing, and redefining Show directly is not very good as well. Try frame:SetScript("OnShow", frame.Hide); frame:Hide(); Even if it would not work for you, this is the preferred way of doing this thing. P.S. Try to override the OnUpdate handler as well.

I actually did try doing that, but it didn't work either. It threw lots of errors. Seeing how I struggled for a couple days with this very issue on trying to find a way to hide the blizzard bars while still retaining their functionality to no avail, I ended up just moving the selected frame offscreen. I know its not pretty nor is it the ideal method, but it works remarkably well.

I'll hopefully have the vehicle exit button working sometime on tuesday. I wont have a chance to work on it today.

[Grimsin]

Originally Posted by AnrDaemon Your post sounds just like i'm overriging global OnShow for all frames with single command... ... ............ go figure my reaction.

With the frames he's referring to you would be. Not for all frames but ones that do have important functions within the onshow and onupdate. Further more as i previously stated... the VehicleMenuBar causes major taint errors and i guarantee with the things you have done that you are going to be producing heavy taint. If you dont know what taint is i suggest you look it up.

Also note that if you really need to change/add those scripts you do hookscript or hooksecurefunc. OR you go to the bliz setscript you want to modify you copy the entire thing paste it into your code and then modify it. That way you maintain any other functionality within it. This also means any other functions used within that script that are not global will have to be cut and pasted as well.

and quite frankly if you are not going to rebuild from scratch the vehiclemenubar then frame adjustments and button positioning should be done in secure code. The vehiclemenubar is tied into the frame animation system pretty heavily, you will taint the living hell out of it if you do not use secure code. it WILL cause funny problems down the road. Like getting no buttons or bar at all when entering/exiting a vehicle. Even worse glitchs while in combat.

[Grimsin]

Originally Posted by maltese I actually did try doing that, but it didn't work either. It threw lots of errors. Seeing how I struggled for a couple days with this very issue on trying to find a way to hide the blizzard bars while still retaining their functionality to no avail, I ended up just moving the selected frame offscreen. I know its not pretty nor is it the ideal method, but it works remarkably well. I'll hopefully have the vehicle exit button working sometime on tuesday. I wont have a chance to work on it today.

The way i posted is the best method and should work no problem.

[Grimsin]

Oh and you should put this line at the top of your file... not that it really helps as much as one would hope.. it does help a lil with the tainting issues.

UIPARENT_MANAGED_FRAME_POSITIONS['VehicleMenuBar'] = nil

here is what my vehicle code looks like, all my code does is modify the graphics and scale as well as allow for positioning without AS much taint. You can see the 3 functions at the bottom, those seem to be the main controllers for bliz frames and buttons. If you hook your frame changes to it things should work just fine. Also note that the way it lays out the frames changes based on if it is a vehicle with angle/pitch button and meter or not. edit - The reason for this is because bliz reused texture names but not textures on the vehic bar so if you hide TextureblahblahblahA on the nonpitch it may be a different piece of the bar then TextureblahblahblahA on the pitch enabled vehic bar, but all having same frame and texture names.

local addonName, addon = ...
 
UIPARENT_MANAGED_FRAME_POSITIONS['MultiBarBottomLeft'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['MultiBarBottomRight'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['MultiBarLeft'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['MultiBarRight'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['MultiCastActionBarFrame'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['MULTICASTACTIONBAR_YPOS'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['PetActionBar'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['PETACTIONBAR_YPOS'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['PossessBarFrame'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['ShapeshiftBarFrame'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['VehicleMenuBar'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['ContainerFrame1'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['ContainerFrame2'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['ContainerFrame3'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['ContainerFrame4'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS['ContainerFrame5'] = nil
UIPARENT_MANAGED_FRAME_POSITIONS["CONTAINER_OFFSET_X"] = nil
UIPARENT_MANAGED_FRAME_POSITIONS["CONTAINER_OFFSET_Y"] = nil
 
-- VehicleMenuBar
--VehicleMenuBar:SetScale(0.84)
function addon:VehicFrameSetup()
    local vehicpitchShown = IsVehicleAimAngleAdjustable()
    if vehicpitchShown == 1 then
        VehicleMenuBar:SetScale(0.77)
        VehicleMenuBarPowerBar:ClearAllPoints()
        VehicleMenuBarPowerBar:SetPoint("CENTER", VehicleMenuBar, "CENTER", 235, 12)
 
        
        VehicleMenuBarHealthBar:ClearAllPoints()
        VehicleMenuBarHealthBar:SetPoint("CENTER", VehicleMenuBar, "CENTER", 170, 12)
 
        
        VehicleMenuBarArtFrameBACKGROUND1:Hide()
        VehicleMenuBarArtFrameBACKGROUND2:Hide()
        VehicleMenuBarArtFrameBACKGROUND3:Hide() 
    
    
    else
        VehicleMenuBar:SetScale(0.84)
        VehicleMenuBarPowerBar:ClearAllPoints()
        VehicleMenuBarPowerBar:SetPoint("CENTER", VehicleMenuBar, "CENTER", 165, 12)
 
 
        VehicleMenuBarHealthBar:ClearAllPoints()
        VehicleMenuBarHealthBar:SetPoint("CENTER", VehicleMenuBar, "CENTER", 100, 12)
 
        
        VehicleMenuBarArtFrameBACKGROUND1:Show()
        VehicleMenuBarArtFrameBACKGROUND2:Show()
        VehicleMenuBarArtFrameBACKGROUND3:Show() 
    
    end
end
 
 
 
hooksecurefunc("UIParent_ManageFramePositions", function(self)
    addon:SafeCall("VehicFrameSetup")
end)
 
hooksecurefunc("UpdateUIPanelPositions", function(self)
    addon:SafeCall("VehicFrameSetup")
end)
 
hooksecurefunc("ValidateFramePosition", function(self)
    addon:SafeCall("VehicFrameSetup")
end)

This is my frame hider code, you can see a lot of vehiclemenubar frames listed. Note that you should not unregister any events for any of the vehic bar frames.

local addonName, addon = ...
 
-- Frames to permanently hide:
--      false = no need to unregister events
--      true = unregister events (no point processing stuff we'll never see)
local frames = {
    --TargetFrame = false,
    --TargetFrameToT = true,
    ReputationWatchBar = true,
    GameTimeFrame = true,
    CastingBarFrameBorder = false,
    TimeManagerClockButton = false,
    ExhaustionTick = true,
    MainMenuExpBar = true,
    MainMenuBarArtFrame = false,
    MainMenuBarMaxLevelBar = false,
    
    VehicleMenuBarArtFrameOVERLAY1 = false,
    VehicleMenuBarArtFrameOVERLAY2 = false,
    VehicleMenuBarArtFrameOVERLAY3 = false,
    VehicleMenuBarArtFrameOVERLAY4 = false,
    
    --VehicleMenuBarArtFrameARTWORK1 = false,
    --VehicleMenuBarArtFrameARTWORK2 = false,
    --VehicleMenuBarArtFrameARTWORK3 = false,
    --VehicleMenuBarArtFrameARTWORK4 = false,
    --VehicleMenuBarArtFrameARTWORK5 = false,
    --VehicleMenuBarArtFrameARTWORK6 = false,
    --VehicleMenuBarArtFrameARTWORK7 = false,
    --VehicleMenuBarArtFrameARTWORK8 = false,
    --VehicleMenuBarArtFrameARTWORK9 = false,
    --VehicleMenuBarArtFrameARTWORK10 = false,
 
    --VehicleMenuBarArtFrameBORDER1 = false,
    --VehicleMenuBarArtFrameBORDER2 = false,
    --VehicleMenuBarArtFrameBORDER3 = false,
    --VehicleMenuBarArtFrameBORDER4 = false,
    --VehicleMenuBarArtFrameBORDER5 = false,
    --VehicleMenuBarArtFrameBORDER6 = false,
    --VehicleMenuBarArtFrameBORDER7 = false,
    
    --VehicleMenuBarArtFrameBACKGROUND1 = false,
    --VehicleMenuBarArtFrameBACKGROUND2 = false,
    --VehicleMenuBarArtFrameBACKGROUND3 = false,
 
    
    MiniMapMailFrame = true,
    MinimapZoomIn = false,
    MinimapZoomOut = false,
    MinimapBackdrop = false,
    MinimapZoneTextButton = false,
    MinimapToggleButton = false,
    MiniMapWorldMapButton = true,
 
    SmartBuff_MiniMapButton = false,
    CritlineMinimapFrame = false,
    TrinketMenu_IconFrame = false,
    ItemRackMiniMapFrame = false,
    MI3_MinimapButton = false,
    FishingBuddyMinimapFrame = false,
    AltoholicMinimapButton = false,
    --MacaroonMinimapButton = false,
    Gatherer_MinimapOptionsButton = false,
    DBMMinimapButton = false,
    LibDBIcon10_EasyDND = false,
    LibDBIcon10_sRaidFrames = false,
    WIM3MinimapButton = false,
    LibDBIcon10_oRA2 = false,
    LibDBIcon10_AutoBar = false,
    LibDBIcon10_Broker_Auditor = false,
--  LibDBIcon10_BugSack = false,
    DHUDMinimapButton = false,
}
 
-- Events that no longer need to be monitored:
MainMenuBarArtFrame:UnregisterEvent('ACTIONBAR_PAGE_CHANGED')
 
--[[-----------------------------------------------------------------------------
Initialize
-------------------------------------------------------------------------------]]
addon.RegisterEvent("HideFrames-Monitor", 'ADDON_LOADED', function(self, event)
    for name, unregister in pairs(frames) do
        local frame = _G[name]
        if frame then
            frames[name] = nil
            addon:HideFrame(frame)
            if unregister then
                frame:UnregisterAllEvents()
                frame:SetScript('OnEvent', nil)
            end
        end
    end
    if next(frames) then return end
    addon.UnregisterEvent(self, event)
end)

oh and i guess you need to see the core functions to or some of this may not make sense...

local addonName, addon = ...
 
_G[addonName] = addon
 
local function DoNothing()
end
addon.DoNothing = DoNothing
 
--[[-----------------------------------------------------------------------------
Event handling - Use one frame to process multiple individual OnEvent needs
-------------------------------------------------------------------------------]]
do
    local frame, select, next, events = CreateFrame('Frame'), select, pairs({ })
    local register, unregister = frame.RegisterEvent, frame.UnregisterEvent
    frame:Hide()
 
    frame:SetScript('OnEvent', function(self, event, ...)
        for reference, func in next, events[event], nil do
            func(reference, event, ...)
        end
    end)
 
    function addon.RegisterEvent(reference, event, func)
        if not events[event] then
            events[event] = { }
            register(frame, event)
        end
        events[event][reference] = func
    end
 
    function addon.RegisterEvents(reference, func, ...)
        local event
        for index = 1, select('#', ...) do
            event = select(index, ...)
            if not events[event] then
                events[event] = { }
                register(frame, event)
            end
            events[event][reference] = func
        end
    end
 
    function addon.UnregisterEvent(reference, event)
        if events[event] then
            events[event][reference] = nil
            if not next(events[event]) then
                events[event] = nil
                unregister(frame, event)
            end
        end
    end
 
    function addon.UnregisterAllEvents(reference)
        for event, registry in next, events, nil do
            registry[reference] = nil
            if not next(registry) then
                events[event] = nil
                unregister(frame, event)
            end
        end
    end
end
 
--[[-----------------------------------------------------------------------------
SafeCall - Queue a method of addon to run once combat ends if needed
-------------------------------------------------------------------------------]]
do
    local combatLockdown, queue = InCombatLockdown(), { }
 
    addon.RegisterEvent("Core-SafeCall-EnterCombat", 'PLAYER_REGEN_DISABLED', function(self)
        combatLockdown = true
    end)
 
    addon.RegisterEvent("Core-SafeCall-LeaveCombat", 'PLAYER_REGEN_ENABLED', function(self)
        combatLockdown = nil
        for method, arg in pairs(queue) do
            addon[method](addon, arg)
            queue[method] = nil
        end
    end)
 
    function addon:SafeCall(method, arg)
        if combatLockdown then
            queue[method] = arg or false
        else
            addon[method](addon, arg)
        end
    end
end
 
--[[-----------------------------------------------------------------------------
Localized class name to file class name look up table
-------------------------------------------------------------------------------]]
local CLASS = { }
for fileName, localName in pairs(LOCALIZED_CLASS_NAMES_MALE) do
    CLASS[localName] = fileName
end
for fileName, localName in pairs(LOCALIZED_CLASS_NAMES_FEMALE) do
    CLASS[localName] = fileName
end
addon.CLASS = CLASS
 
--[[-----------------------------------------------------------------------------
MoneyToString - Get formatted text from an ammount of copper
-------------------------------------------------------------------------------]]
function addon:MoneyToString(ammount, forceIcons)
    local cu = ammount % 100
    ammount = floor(ammount / 100)
    local ag, au = ammount % 100, floor(ammount / 100)
    local cuInd, agInd, auInd
    if GetCVarBool('showChatIcons') or forceIcons then
        cuInd = [[|TInterface\MoneyFrame\UI-CopperIcon:0|t]]
        agInd = [[|TInterface\MoneyFrame\UI-SilverIcon:0|t ]]
        auInd = [[|TInterface\MoneyFrame\UI-GoldIcon:0|t ]]
    else
        cuInd = "|cffeda55fc|r"
        agInd = "|cffc7c7cfs|r "
        auInd = "|cffffd700g|r "
    end
    local string = ""
    if au > 0 then
        string = au .. auInd .. ag .. agInd
    elseif ag > 0 then
        string = ag .. agInd
    end
    return string .. cu .. cuInd
end
 
--[[-----------------------------------------------------------------------------
HideTooltip - Hide GameTooltip (several frames use this)
-------------------------------------------------------------------------------]]
function addon:HideTooltip()
    GameTooltip:Hide()
    self.tooltip = nil
end
 
--[[-----------------------------------------------------------------------------
HideFrame - Hide a frame, prevents it from being reshown
-------------------------------------------------------------------------------]]
function addon:HideFrame(reference)
    local frame = type(reference) == 'string' and _G[reference] or reference
    if type(frame) ~= 'table' then return end
    frame.Show = DoNothing
    frame:Hide()
end
 
--[[-----------------------------------------------------------------------------
ShowFrame - Show a frame, undoing :HideFrame behavior
-------------------------------------------------------------------------------]]
function addon:ShowFrame(reference)
    local frame = type(reference) == 'string' and _G[reference] or reference
    if type(frame) ~= 'table' then return end
    frame.Show = nil
    frame:Show()
end
 
--[[-----------------------------------------------------------------------------
LockFrame - Lock a frame, prevents SetPoint and ClearAllPoints from working
-------------------------------------------------------------------------------]]
function addon:LockFrame(reference)
    local frame = type(reference) == 'string' and _G[reference] or reference
    if type(frame) ~= 'table' then return end
    frame.SetPoint = DoNothing
    frame.ClearAllPoints = DoNothing
end
 
--[[-----------------------------------------------------------------------------
UnlockFrame - Undo :LockFrame
-------------------------------------------------------------------------------]]
function addon:UnlockFrame(reference)
    local frame = type(reference) == 'string' and _G[reference] or reference
    if type(frame) ~= 'table' then return end
    frame.SetPoint = nil
    frame.ClearAllPoints = nil
end
 
--[[-----------------------------------------------------------------------------
RunSlashCmd
-------------------------------------------------------------------------------]]
function addon:RunSlashCmd(cmd)
    local slash, rest = cmd:match("^(%S+)%s*(.-)$")
    for name, func in pairs(SlashCmdList) do
        local i, slashCmd = 1
        repeat
            slashCmd = _G['SLASH_' .. name .. i]
            if slashCmd == slash then
                func(rest)
                return true
            end
            i = i + 1
        until not slashCmd
    end
end
 
--[[-----------------------------------------------------------------------------
Delay a function
-------------------------------------------------------------------------------]]
local waitTable = {};
local waitFrame = nil;
function addon:FuncDelay(delay, func, ...)
  if(type(delay)~="number" or type(func)~="function") then
    return false;
  end
  if(waitFrame == nil) then
    waitFrame = CreateFrame("Frame","WaitFrame", UIParent);
    waitFrame:SetScript("onUpdate",function (self,elapse)
      local count = #waitTable;
      local i = 1;
      while(i<=count) do
        local waitRecord = tremove(waitTable,i);
        local d = tremove(waitRecord,1);
        local f = tremove(waitRecord,1);
        local p = tremove(waitRecord,1);
        if(d>elapse) then
          tinsert(waitTable,i,{d-elapse,f,p});
          i = i + 1;
        else
          count = count - 1;
          f(unpack(p));
        end
      end
    end);
  end
  tinsert(waitTable,{delay,func,{...}});
  return true;
end
 
--[[-----------------------------------------------------------------------------
Blizzard Build comparisonn for ptr/beta/live compatible versions
-------------------------------------------------------------------------------]]
function addon:CompareBuild(comver, combuild, comref, lowcomref, highcomref)
    local version, build, bdate, toc = GetBuildInfo()
    if version > comver and build > combuild then
        addon[highcomref]()
    elseif version < comver and build < combuild then
        addon[lowcomref]()
    elseif version == comver and build == combuild then
        addon[comref]()
    end
end
 
--[[-----------------------------------------------------------------------------
LibSharedMedia support
-------------------------------------------------------------------------------]]
local LSM = LibStub('LibSharedMedia-3.0')
 
LSM:Register('background', addonName, [[Interface\Addons\]] .. addonName .. [[\Media\MainBG]])
 
LSM:Register('font', "Franklin Gothing Medium", [[Interface\Addons\]] .. addonName .. [[\Media\Font1.ttf]])
LSM:Register('font', "Comic Sans MS", [[Interface\Addons\]] .. addonName .. [[\Media\Font3.ttf]])
 
--[[-----------------------------------------------------------------------------
Extra Key Binding Data
-------------------------------------------------------------------------------]]
 
BINDING_HEADER_GRIMUI = "-- GrimUI --"
BINDING_HEADER_RAID_MOUSEOVER = "Raid Targeting (Mouseover)"
 
 
--[[-----------------------------------------------------------------------------
Localization support. AceLocale
-------------------------------------------------------------------------------]]
local AceLocale = LibStub("AceLocale-3.0")
local L = AceLocale:GetLocale( "GrimUI", true )

[maltese]

Originally Posted by Grimsin The way i posted is the best method and should work no problem.

Aye, what you posted did infact hide the borders on entering a vehicle but the issue arises when you actually use the ability. The border for that ability pops back instantly. I'm looking at the code you posted for secure headers. I should have the vehicle exit button implemented today.

As for taint issues, you'll have to excuse my newbness here. My knowledge of lua is extremely limited and I've learned mostly everything from looking at code over the years and researching wowwiki's API pages. I've done some searches on the topic of taint and turned up discussion about moving actionbars when in combat. I do know that with some of the first iterations of the code I tried I did run into a LOT of errors when getting into a vehicle in combat with wow giving the error "Interface action failed because of an Addon". I'm assuming thats what you are referring to.

I worked around that by moving all the positioning code around to move the frames during the PLAYER_ENTERING_WORLD event and haven't that issue since, even when entering a vehicle in combat. I'm just setting the Alpha to 0 when you are not actually in a vehicle and since the vehicle bar isn't there anyway, you wont have issues with buttons being invisible but click able.

Now if you are saying that taint is still occurring even though I'm not moving anything in combat, then I guess this entire addon would have to be rewritten using secure code, which I guess I could do but I'll have to read up on the subject. Furthermore I think the only time there would actually be an issue is if you DC'd in the middle of a boss fight that required vehicles and logging back in would break the functionality of the mod (since I move everything at login).

I guess its time to look at your code and read up to see if its actually something I can fix.

EDIT: On reflection of the very sort period of time I worked on adding the vehicle exit button the other night I noticed that the button was displayed correctly but was not clickable at all. I realize now a couple things:

1: I'm fairly certain that the vehicle action bar that I'm displaying isn't clickable either. I didn't test that because I used keybindings to test to see if the cooldown frame was working.
2: All this addon is doing (I think) is moving the graphics of the buttons to the defined anchor and not the actual button itself.
3: This explains why I'm not getting the errors anymore when getting into and out of combat (since I'm not moving the buttons themselves)
4: If I wanted the actual buttons moved I'd have to completely rewrite the addon to use secure functions like you suggested.
5: The taint issue you are talking about is going to affect my other addon as well (I think its limited to DCing and relogging in combat, but what do I know )
6: All of the clicking issues could be the taint you are describing and I just have no clue what I'm talking about (likely)
7: I'm a piss poor coder

I'll try to test this today and figure out what exactly is going on and see if its an easy fix. If not then I'm tempted to just leave it as is with the understanding that this addon is just for the graphical display of the vehicle bar for reference and know that it will not fit the needs of 99.9999% of people that use addons. Minus the unconfirmed issues with errors on reloading in combat it fits all the needs I have for it and I'm really just not good enough of a coder to provide full feature addons like the pros here.

[Grimsin]

Taint sucks lemme tell ya. what taint is, hmm well basically its a small error that happens any time you move or do anything tied into any part of the secure bliz code.? It is most noticeable when it comes to combat but it does happen at other times. Often times taint is not a big deal, like moving simple frames and such. When it becomes a bigger deal though is when it comes to action buttons. Or adjusting frames tied into the animation system like the pet bar, stance change bars, and the vehicle bar most notably.

The thing about most taint is you can ignore it. When its really a problem is when it actually pops that msg about action blocked. Then it stops game play and something definitely did not work. If you turn taint logging off which i think by default it is off then most taint will never be an issue.

As far as when you do the layout, so the frame is not movable once the game loads? Want to post your code? ill take a look, i know a little bit about secure code. With my code the bar is movable via my frame moving system and the buttons are still click-able. Biggest glitches i have is getting in and out of vehicles while in combat. I jump out of siege a lot to deal with people chasing me. .. My code does not use secure code just secure function hooks, the buttons do not have to have secure code to be moved... although secure code is better lol.

It might be easiest to modify the bliz frame like i was rather then rebuild one. At the same time if you rebuild the frame all together and use some secure code for the buttons you would get away from all the taint issues.

Here are some secure chunks out of GrimUI.

This is a secure method to toggle the backpack so it does not taint when using the inventory in combat.

backpackButton:SetAttribute('_onclick', [[
    if button == 'LeftButton' then
        control:CallMethod("ToggleBags")
    else
        local bagBar = self:GetFrameRef("bagBar")
        if bagBar:IsVisible() then
            bagBar:Hide()
        else
            bagBar:Show()
        end
    end
]])

this chunk here toggles the combatlog on/off as well as a bank of buttons.

local hotSpot = CreateFrame('Button', nil, UIParent, 'SecureHandlerClickTemplate')
hotSpot:SetPoint('BOTTOMRIGHT', -370, 220)
hotSpot:SetHeight(15)
hotSpot:SetWidth(15)
 
hotSpot:SetFrameRef("contextMenu", contextMenu)
hotSpot:RegisterForClicks('LeftButtonUp', 'RightButtonUp')
hotSpot:SetAttribute('_onclick', [[
    local frame = self:GetFrameRef("contextMenu")
    if button == 'LeftButton' then
        if frame:IsVisible() then
            frame:Hide(true)
        else
            frame:Show(true)
        end
    elseif button == 'RightButton' then
        control:CallMethod("ToggleCombatLog")
    end
]])
 
 hotSpot:SetScript('OnEnter', function(self)
    GameTooltip:SetOwner(self, 'ANCHOR_TOP', 0, 1)
    GameTooltip:AddLine("|cffeda55fLeft Click|r for ContextMenu", 0.2, 1, 0.2)
    GameTooltip:AddLine("|cffeda55fRight Click|r toggle CombatLog", 0.2, 1, 0.2)
    GameTooltip:Show()
end)
 
hotSpot:SetScript('OnLeave', addon.HideTooltip)
 
function hotSpot:ToggleCombatLog()
    addon.settings.showCombatLog = not addon.settings.showCombatLog
    addon:ConfigureCombatLog()
end

this is the button creation you either are dealing with button id 121-132 or they made something else for vehics but i think it is the same buttons for posses so... if you try to remake the buttons i would go with id 121-132
This is the chunk that was originaly from Giest although heavily modified now.
Notice it is not really secure code just the option to show hide it needed to be to avoid in combat problems.

--[[-----------------------------------------------------------------------------
This is used to set the default button ids . These buttons do not conflict with
known stance/form/stealth bars.  These settings are not ideal, but are the best
compromise I could come up with short of writing virtual action buttons.
 
Default Blizzard IDs:
1-12        Main Bar (Unused by Warriors)
13-24       Second Bar
25-36       Side Bar 1
37-48       Side Bar 2
49-60       Bottom Right Bar
61-72       Bottom Left Bar
73-84       Warrior Battle, Druid Cat, Rogue Stealth, Priest Shadowform
85-96       Warrior Defensive, Druid Tree
97-108  Warrior Berserker, Druid Bear
109-120 Druid Moonkin
121-132 Possess Bar (Unusable)
-------------------------------------------------------------------------------]]
local actionID, class = UnitClass('player')
 
if class == 'DRUID' then
    actionID = {
        48, --01
        49, --02
        50, --03
        51, --04
        52, --05
        53, --06
        54, --07
        55, --08
        56, --09
        57, --10
        58, --11
        59, --12
        60, --13
        61, --14
        62, --15
        63, --16
        64, --17
        65, --18
        66, --19
        67, --20
        68, --21
        69, --22
        70, --23
        71, --24
        72  --25
    }
elseif class == 'WARRIOR' then
    actionID = {
        1, --01
        2, --02
        3, --03
        4, --04
        5, --05
        6, --06
        7, --07
        8, --08
        9, --09
        10, --10
        11, --11
        12, --12
        72, --13, Pesky warriors.
        109, --14
        110, --15
        111, --16
        112, --17
        113, --18
        114, --19
        115, --20
        116, --21
        117, --22
        118, --23
        119, --24
        120  --25
    }
else
    actionID = {
        96, --01
        97, --02
        98, --03
        99, --04
        100, --05
        101, --06
        102, --07
        103, --08
        104, --09
        105, --10
        106, --11
        107, --12
        108, --13
        109, --14
        110, --15
        111, --16
        112, --17
        113, --18
        114, --19
        115, --20
        116, --21
        117, --22
        118, --23
        119, --24
        120  --25
    }
end
 
local contextMenu = CreateFrame('Frame', nil, UIParent, 'SecureFrameTemplate')
contextMenu:SetPoint('RIGHT', UIParent, 'RIGHT', -280, -120)
 
local buttons = { }
for index = 1, #actionID do
    local button = CreateFrame('CheckButton', addonName .. "ContextMenuButton" .. index, contextMenu, 'ActionBarButtonTemplate')
    buttons[index] = button
    if (index - 1) % 5 ~= 0 then
        button:SetPoint('LEFT', buttons[index - 1], 'RIGHT', 2, 0)
    elseif index ~= 1 then
        button:SetPoint('TOPLEFT', buttons[index - 5], 'BOTTOMLEFT', 0, -2)
    else
        button:SetPoint('TOPLEFT')
    end
    button:SetAttribute('type', 'action')
    button:SetAttribute('action', actionID[index])
end
 
contextMenu:SetHeight(buttons[1]:GetHeight() * 5 + 8)
contextMenu:SetWidth(buttons[1]:GetWidth() * 5 + 8)
contextMenu:SetScale(0.8)
 
local texture = contextMenu:CreateTexture(nil, 'ARTWORK')
texture:SetTexture([[Interface\DialogFrame\UI-DialogBox-Background]])
texture:SetVertexColor(1, 1, 1, 0.5)
texture:SetPoint('CENTER')
texture:SetWidth(36)
texture:SetHeight(36)
 
local title = contextMenu:CreateFontString(nil, 'OVERLAY')
title:SetFont([[Fonts\FRIZQT__.TTF]], 12, 'OVERLAY')
title:SetTextColor(1, 1, 0, 0.8)
title:SetPoint('TOP', texture, 'TOP', 0, -1)
title:SetText('GCM')

[Grimsin]

Oh also might wanna take a look at some of the other actionbar addons that have something that deals with the vehicle bar like macaroon has a vehicle bar replacement but all it replaces is the action buttons it does not deal with the health/power stuff. It does deal with the leave button as well as pitch buttons. His code is pretty complex though hehe ive looked a few times and get overwhelmed real quick.