Which is Better?

[sirann]

Originally Posted by cokedrivers if event == "ADDON_LOADED" and arg1 == "cBuffs" then

you only have the frame registered to addon_loaded so the only event that can cause the script to fire is addon_loaded, thus making the initial part of this two part if check, redundant and unncessary.

[Duugu]

Originally Posted by sirann you only have the frame registered to addon_loaded so the only event that can cause the script to fire is addon_loaded, thus making the initial part of this two part if check, redundant and unncessary.

If I remember correctly the event fires for every addon that is loaded. I thought that's why arg1 provides the addon name.

[sirann]

correct, all he needs is the arg1 == check, not the event check.

if arg1 == "cBuffs" then

instead of

if event == "ADDON_LOADED" and arg1 == "cBuffs" then

[Duugu]

Originally Posted by sirann correct, all he needs is the arg1 == check, not the event check. if arg1 == "cBuffs" then instead of if event == "ADDON_LOADED" and arg1 == "cBuffs" then

But, but ... he is unregistering the event outside of the if statement. Or not??

[sirann]

I'm starting to think we are speaking about two different things. I was merely adding (regardless of the code below it) that there is no need for the event check, there's only one registered, it can only fire for addon_loaded.

I believe what you are getting at, is the fact that, as currently written, this script would fire as soon as the first addon is loaded, which I'm confident is not cbuffs. Since the initial if check requirements would not be met, the script would skip to the slashcommand creation, and would then unregister the only event it's listening for. This would essentially ensure the script never fires when he wants it to.

If that's what you're saying, I agree, and in no way intended to imply or convey otherwise. I just noticed a relatively common, and small, unoptimization.

If that's not what you're saying, please expand, because I don't see where I am incorrect in my suggestion.

[Duugu]

Originally Posted by sirann If that's what you're saying, I agree, and in no way intended to imply or convey otherwise. I just noticed a relatively common, and small, unoptimization.

Thats it.